andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactoring - removing unused parameter

This commit is contained in:
rusefi 2017-04-09 22:26:11 -04:00
parent c356d916e3
commit 5291f0ec54
4 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
firmware/console/status_loop.cpp
View File

@ -436,7 +436,7 @@ extern fatal_msg_t errorMessageBuffer;
/** /**
* @brief Sends all pending data to dev console * @brief Sends all pending data to dev console
*/ */
void updateDevConsoleState(Engine *engine) { void updateDevConsoleState(void) {
if (!isCommandLineConsoleReady()) { if (!isCommandLineConsoleReady()) {
return; return;
} }
@ -862,7 +862,7 @@ static void unsubscribe(int outputOrdinal) {
subscription[outputOrdinal] = false; subscription[outputOrdinal] = false;
} }
void initStatusLoop(Engine *engine) { void initStatusLoop(void) {
setFullLog(INITIAL_FULL_LOG); setFullLog(INITIAL_FULL_LOG);
addConsoleActionI(FULL_LOGGING_KEY, setFullLog); addConsoleActionI(FULL_LOGGING_KEY, setFullLog);
addConsoleActionI("warn", setWarningEnabled); addConsoleActionI("warn", setWarningEnabled);
@ -888,9 +888,9 @@ void initStatusLoop(Engine *engine) {
#endif /* EFI_PROD_CODE */ #endif /* EFI_PROD_CODE */
} }
void startStatusThreads(Engine *engine) { void startStatusThreads(void) {
// todo: refactoring needed, this file should probably be split into pieces // todo: refactoring needed, this file should probably be split into pieces
chThdCreateStatic(lcdThreadStack, sizeof(lcdThreadStack), NORMALPRIO, (tfunc_t) lcdThread, engine); chThdCreateStatic(lcdThreadStack, sizeof(lcdThreadStack), NORMALPRIO, (tfunc_t) lcdThread, NULL);
#if EFI_PROD_CODE || defined(__DOXYGEN__) #if EFI_PROD_CODE || defined(__DOXYGEN__)
initStatusLeds(); initStatusLeds();
chThdCreateStatic(blinkingStack, sizeof(blinkingStack), NORMALPRIO, (tfunc_t) blinkingThread, NULL); chThdCreateStatic(blinkingStack, sizeof(blinkingStack), NORMALPRIO, (tfunc_t) blinkingThread, NULL);

6
firmware/console/status_loop.h
View File

@ -10,10 +10,10 @@
#include "engine.h" #include "engine.h"
void updateDevConsoleState(Engine *engine); void updateDevConsoleState(void);
void prepareTunerStudioOutputs(void); void prepareTunerStudioOutputs(void);
void startStatusThreads(Engine *engine); void startStatusThreads(void);
void initStatusLoop(Engine *engine); void initStatusLoop(void);
void writeLogLine(void); void writeLogLine(void);
bool getFullLog(void); bool getFullLog(void);
void setFullLog(int value); void setFullLog(int value);

8
firmware/rusefi.cpp
View File

@ -195,7 +195,7 @@ void runRusEfi(void) {
*/ */
initHardware(&sharedLogger); initHardware(&sharedLogger);
initStatusLoop(engine); initStatusLoop();
/** /**
* Now let's initialize actual engine control logic * Now let's initialize actual engine control logic
* todo: should we initialize some? most? controllers before hardware? * todo: should we initialize some? most? controllers before hardware?
@ -209,7 +209,7 @@ void runRusEfi(void) {
#if EFI_ENGINE_EMULATOR || defined(__DOXYGEN__) #if EFI_ENGINE_EMULATOR || defined(__DOXYGEN__)
initEngineEmulator(&sharedLogger, engine); initEngineEmulator(&sharedLogger, engine);
#endif #endif
startStatusThreads(engine); startStatusThreads();
rememberCurrentConfiguration(); rememberCurrentConfiguration();
@ -224,7 +224,7 @@ void runRusEfi(void) {
#if (EFI_CLI_SUPPORT && !EFI_UART_ECHO_TEST_MODE) || defined(__DOXYGEN__) #if (EFI_CLI_SUPPORT && !EFI_UART_ECHO_TEST_MODE) || defined(__DOXYGEN__)
// sensor state + all pending messages for our own dev console // sensor state + all pending messages for our own dev console
updateDevConsoleState(engine); updateDevConsoleState();
#endif /* EFI_CLI_SUPPORT */ #endif /* EFI_CLI_SUPPORT */
chThdSleepMilliseconds(boardConfiguration->consoleLoopPeriod); chThdSleepMilliseconds(boardConfiguration->consoleLoopPeriod);
@ -250,5 +250,5 @@ int getRusEfiVersion(void) {
return 123; // this is here to make the compiler happy about the unused array return 123; // this is here to make the compiler happy about the unused array
if (UNUSED_CCM_SIZE[0] * 0 != 0) if (UNUSED_CCM_SIZE[0] * 0 != 0)
return 3211; // this is here to make the compiler happy about the unused array return 3211; // this is here to make the compiler happy about the unused array
return 20170408; return 20170409;
} }

6
win32_functional_tests/simulator/rusEfiFunctionalTest.cpp
View File

@ -96,7 +96,7 @@ void rusEfiFunctionalTest(void) {
initializeConsole(&sharedLogger); initializeConsole(&sharedLogger);
initStatusLoop(engine); initStatusLoop();
initDataStructures(PASS_ENGINE_PARAMETER_F); initDataStructures(PASS_ENGINE_PARAMETER_F);
@ -124,7 +124,7 @@ void rusEfiFunctionalTest(void) {
initMainEventListener(&sharedLogger, engine); initMainEventListener(&sharedLogger, engine);
startStatusThreads(engine); startStatusThreads();
runChprintfTest(); runChprintfTest();
@ -135,7 +135,7 @@ void rusEfiFunctionalTest(void) {
} }
void printPendingMessages(void) { void printPendingMessages(void) {
updateDevConsoleState(engine); updateDevConsoleState();
waveChart.publishIfFull(); waveChart.publishIfFull();
} }