trigger refactoring: we are long overdue for better api, also reducing CRANK_MODE_MULTIPLIER crazy

This commit is contained in:
Andrey 2023-05-13 15:16:38 -04:00
parent 56a327c6be
commit 56f4d89e33
1 changed files with 5 additions and 15 deletions

View File

@ -125,31 +125,21 @@ void configureKawaKX450F(TriggerWaveform *s) {
addSkippedToothTriggerEvents(TriggerWheel::T_PRIMARY, s, 18, 0, toothWidth, 0, engineCycle, addSkippedToothTriggerEvents(TriggerWheel::T_PRIMARY, s, 18, 0, toothWidth, 0, engineCycle,
NO_LEFT_FILTER, 720 - 39); NO_LEFT_FILTER, 720 - 39);
s->addEvent(0.97, TriggerValue::RISE, TriggerWheel::T_PRIMARY); s->addToothRiseFall(360, /* width*/10.80);
s->addEvent(1, TriggerValue::FALL, TriggerWheel::T_PRIMARY);
} }
void configureQuickStartSenderWheel(TriggerWaveform *s) { void configureQuickStartSenderWheel(TriggerWaveform *s) {
// todo: most cam wheels are defined as 'SyncEdge::Rise' or 'SyncEdge::RiseOnly' shall we unify? // todo: most cam wheels are defined as 'SyncEdge::Rise' or 'SyncEdge::RiseOnly' shall we unify?
s->initialize(FOUR_STROKE_CAM_SENSOR, SyncEdge::Fall); s->initialize(FOUR_STROKE_CAM_SENSOR, SyncEdge::Fall);
int offset = 20;
// our preference is to sync not too close to crank sync point // our preference is to sync not too close to crank sync point
s->setTriggerSynchronizationGap(0.645); s->setTriggerSynchronizationGap(0.645);
s->setSecondTriggerSynchronizationGap(1.556); s->setSecondTriggerSynchronizationGap(1.556);
s->addEvent360(offset + 0, TriggerValue::RISE, TriggerWheel::T_PRIMARY); s->addToothRiseFall(90, /* width*/ 70);
s->addEvent360(offset + 70, TriggerValue::FALL, TriggerWheel::T_PRIMARY); s->addToothRiseFall(130, /* width*/ 20);
s->addToothRiseFall(220, /* width*/ 20);
s->addEvent360(offset + 90, TriggerValue::RISE, TriggerWheel::T_PRIMARY); s->addToothRiseFall(360, /* width*/ 70);
s->addEvent360(offset + 110, TriggerValue::FALL, TriggerWheel::T_PRIMARY);
s->addEvent360(offset + 180, TriggerValue::RISE, TriggerWheel::T_PRIMARY);
s->addEvent360(offset + 200, TriggerValue::FALL, TriggerWheel::T_PRIMARY);
s->addEvent360(offset + 270, TriggerValue::RISE, TriggerWheel::T_PRIMARY);
s->addEvent360(offset + 340, TriggerValue::FALL, TriggerWheel::T_PRIMARY);
} }
// Useful for: // Useful for: