Trigger setup in TS is highly confusing: hide operation mode from users? #4031
This commit is contained in:
parent
6aa948a666
commit
5840a61f55
|
@ -22,7 +22,7 @@ TEST(Actuators, Tachometer) {
|
|||
engineConfiguration->trigger.customTotalToothCount = 8;
|
||||
engineConfiguration->trigger.customSkippedToothCount = 0;
|
||||
engineConfiguration->useOnlyRisingEdgeForTrigger = false;
|
||||
engineConfiguration->ambiguousOperationMode = FOUR_STROKE_CAM_SENSOR;
|
||||
setCamOperationMode(engineConfiguration);
|
||||
eth.applyTriggerWaveform();
|
||||
|
||||
// get the engine running - 6 revolutions
|
||||
|
|
|
@ -39,7 +39,7 @@ TEST(fuelControl, transitionIssue1592) {
|
|||
engineConfiguration->trigger.customTotalToothCount = 6;
|
||||
engineConfiguration->trigger.customSkippedToothCount = 1;
|
||||
eth.setTriggerType(TT_TOOTHED_WHEEL);
|
||||
engineConfiguration->ambiguousOperationMode = FOUR_STROKE_CAM_SENSOR;
|
||||
setCamOperationMode(engineConfiguration);
|
||||
engineConfiguration->isFasterEngineSpinUpEnabled = true;
|
||||
|
||||
setTable(config->injectionPhase, 0.0f);
|
||||
|
|
|
@ -26,7 +26,7 @@ TEST(misc, testEngineMath) {
|
|||
|
||||
EngineTestHelper eth(FORD_ESCORT_GT);
|
||||
|
||||
engineConfiguration->ambiguousOperationMode = FOUR_STROKE_CAM_SENSOR;
|
||||
setCamOperationMode(engineConfiguration);
|
||||
engineConfiguration->fuelAlgorithm = LM_SPEED_DENSITY;
|
||||
|
||||
ASSERT_NEAR( 50, getOneDegreeTimeMs(600) * 180, EPS4D) << "600 RPM";
|
||||
|
|
|
@ -20,7 +20,7 @@ TEST(HPFP, IntegratedSchedule) {
|
|||
engineConfiguration->trigger.customTotalToothCount = 16;
|
||||
engineConfiguration->trigger.customSkippedToothCount = 0;
|
||||
eth.setTriggerType(TT_TOOTHED_WHEEL);
|
||||
engineConfiguration->ambiguousOperationMode = FOUR_STROKE_CAM_SENSOR;
|
||||
setCamOperationMode(engineConfiguration);
|
||||
engineConfiguration->isFasterEngineSpinUpEnabled = true;
|
||||
|
||||
|
||||
|
|
|
@ -58,7 +58,7 @@ TEST_P(AllTriggersFixture, TestTrigger) {
|
|||
EngineTestHelperBase base(engine, &pc.engineConfiguration, &pc);
|
||||
|
||||
engineConfiguration->trigger.type = tt;
|
||||
engineConfiguration->ambiguousOperationMode = FOUR_STROKE_CAM_SENSOR;
|
||||
setCamOperationMode(engineConfiguration);
|
||||
|
||||
TriggerWaveform *shape = &engine->triggerCentral.triggerShape;
|
||||
TriggerFormDetails *triggerFormDetails = &engine->triggerCentral.triggerFormDetails;
|
||||
|
|
Loading…
Reference in New Issue