From 59be867e4780f02db54d1fb463c64e18f84a148e Mon Sep 17 00:00:00 2001 From: rusefillc Date: Sun, 5 Jan 2025 09:57:33 -0500 Subject: [PATCH] fuel level does not handle lack of ignition voltage #7254 only:uaefi --- firmware/controllers/algo/defaults/default_base_engine.cpp | 2 ++ firmware/integration/rusefi_config.txt | 4 ++++ firmware/tunerstudio/tunerstudio.template.ini | 2 ++ 3 files changed, 8 insertions(+) diff --git a/firmware/controllers/algo/defaults/default_base_engine.cpp b/firmware/controllers/algo/defaults/default_base_engine.cpp index aeaaae7553..c1c7f7bad6 100644 --- a/firmware/controllers/algo/defaults/default_base_engine.cpp +++ b/firmware/controllers/algo/defaults/default_base_engine.cpp @@ -110,6 +110,8 @@ void setDefaultBaseEngine() { engineConfiguration->fuelLevelAveragingAlpha = engine_configuration_defaults::FUEL_LEVEL_AVERAGING_ALPHA; engineConfiguration->fuelLevelUpdatePeriodSec = engine_configuration_defaults::FUEL_LEVEL_UPDATE_PERIOD_SEC; + engineConfiguration->fuelLevelLowThresholdVoltage = 0.25; + engineConfiguration->fuelLevelHighThresholdVoltage = 4.5; engineConfiguration->watchOutForLinearTime = true; diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt index a842db6a92..25247805ef 100644 --- a/firmware/integration/rusefi_config.txt +++ b/firmware/integration/rusefi_config.txt @@ -1802,6 +1802,10 @@ uint8_t autoscale knockFuelTrim;Fuel trim when knock, max 30%;"%", 1, 0, 0, 30, float fuelLevelAveragingAlpha;Exponential Average Alpha filtering parameter;"", 1, 0, 0.0001, 1, 4 float fuelLevelUpdatePeriodSec;How often do we update fuel level gauge;"seconds", 1, 0, 0, 60000, 3 + + float fuelLevelLowThresholdVoltage;Error below specified value;"v", 1, 0, 0, 10, 2 + float fuelLevelHighThresholdVoltage;Error above specified value;"v", 1, 0, 0, 10, 2 + #define END_OF_CALIBRATION_PADDING 58 uint8_t[END_OF_CALIBRATION_PADDING] unusedOftenChangesDuringFirmwareUpdate;;"units", 1, 0, 0, 1, 0 diff --git a/firmware/tunerstudio/tunerstudio.template.ini b/firmware/tunerstudio/tunerstudio.template.ini index 2b53c4b32c..b82bfeb9c5 100644 --- a/firmware/tunerstudio/tunerstudio.template.ini +++ b/firmware/tunerstudio/tunerstudio.template.ini @@ -3220,6 +3220,8 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@@@ts_command_e_TS_ dialog = fuelLevelDialog, "Fuel Level Sensor" field = "Input channel", fuelLevelSensor + field = "Low threshold", fuelLevelLowThresholdVoltage, {fuelLevelSensor != @@ADC_CHANNEL_NONE@@} + field = "High threshold", fuelLevelHighThresholdVoltage, {fuelLevelSensor != @@ADC_CHANNEL_NONE@@} field = "Filter Alpha", fuelLevelAveragingAlpha field = "Update period", fuelLevelUpdatePeriodSec panel = fuelLevelCurve