From 5a27aa6c6bc7b92724df6873db2162de2d7a917a Mon Sep 17 00:00:00 2001 From: rusefillc Date: Fri, 21 Feb 2025 20:12:37 -0500 Subject: [PATCH] let's remove "overrideCrankingIacSetting" "Override cranking IAC CLT multiplier" flexibility and always use additional table #7482 --- firmware/config/engines/canam.cpp | 1 - firmware/config/engines/hyundai.cpp | 2 -- firmware/integration/rusefi_config.txt | 2 +- firmware/tunerstudio/tunerstudio.template.ini | 1 - unit_tests/tests/test_idle_controller.cpp | 3 --- 5 files changed, 1 insertion(+), 8 deletions(-) diff --git a/firmware/config/engines/canam.cpp b/firmware/config/engines/canam.cpp index 030935213f..8bd95d9448 100644 --- a/firmware/config/engines/canam.cpp +++ b/firmware/config/engines/canam.cpp @@ -51,7 +51,6 @@ void setMaverickX3() { engineConfiguration->idlePidDeactivationTpsThreshold = 2; engineConfiguration->useSeparateAdvanceForIdle = true; engineConfiguration->vvtControlMinRpm = 2000; - engineConfiguration->overrideCrankingIacSetting = true; engineConfiguration->requireFootOnBrakeToCrank = true; engineConfiguration->startButtonSuppressOnStartUpMs = 1000; diff --git a/firmware/config/engines/hyundai.cpp b/firmware/config/engines/hyundai.cpp index 0aa2c26922..a2f62bab53 100644 --- a/firmware/config/engines/hyundai.cpp +++ b/firmware/config/engines/hyundai.cpp @@ -299,8 +299,6 @@ static void commonGenesisCoupe() { engineConfiguration->crankingIACposition = 70; // default 200.0 engineConfiguration->afterCrankingIACtaperDuration = 100; - // default "false" - engineConfiguration->overrideCrankingIacSetting = true; // default 0.0 engineConfiguration->tpsAccelLookback = 0.3; // default 40.0 diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt index df7ff104f1..47e94b7780 100644 --- a/firmware/integration/rusefi_config.txt +++ b/firmware/integration/rusefi_config.txt @@ -1105,7 +1105,7 @@ custom idle_mode_e 1 bits, U08, @OFFSET@, [0:0], "Open Loop + Closed Loop", "Ope bit complexWallModel,"Advanced (tables)","Basic (constants)";Should we use tables to vary tau/beta based on CLT/MAP, or just with fixed values? bit alwaysInstantRpm;RPM is measured based on last 720 degrees while instant RPM is measured based on the last 90 degrees of crank revolution bit isMapAveragingEnabled - bit overrideCrankingIacSetting;If enabled, use separate temperature multiplier table for cranking idle position.\nIf disabled, use normal running multiplier table applied to the cranking base position. + bit unusedOverrideCrankingIacSetting;If enabled, use separate temperature multiplier table for cranking idle position.\nIf disabled, use normal running multiplier table applied to the cranking base position. bit useSeparateAdvanceForIdle;This activates a separate ignition timing table for idle conditions, this can help idle stability by using ignition retard and advance either side of the desired idle speed. Extra advance at low idle speeds will prevent stalling and extra retard at high idle speeds can help reduce engine power and slow the idle speed. bit isWaveAnalyzerEnabled bit useSeparateVeForIdle;This activates a separate fuel table for Idle, this allows fine tuning of the idle fuelling. diff --git a/firmware/tunerstudio/tunerstudio.template.ini b/firmware/tunerstudio/tunerstudio.template.ini index 342ce463ca..2f7ddd68e7 100644 --- a/firmware/tunerstudio/tunerstudio.template.ini +++ b/firmware/tunerstudio/tunerstudio.template.ini @@ -4589,7 +4589,6 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@@@ts_command_e_TS_ dialog = crankingIAC, "Idle air valve" field = "Cranking base IAC position", crankingIACposition field = "After cranking IAC taper duration",afterCrankingIACtaperDuration - field = "Override cranking IAC CLT multiplier", overrideCrankingIacSetting dialog = crankingIgnition, "Ignition" field = "Timing Advance mode", useSeparateAdvanceForCranking diff --git a/unit_tests/tests/test_idle_controller.cpp b/unit_tests/tests/test_idle_controller.cpp index de71e79c12..ba0813061d 100644 --- a/unit_tests/tests/test_idle_controller.cpp +++ b/unit_tests/tests/test_idle_controller.cpp @@ -122,7 +122,6 @@ TEST(idle_v2, crankingOpenLoop) { config->cltIdleCorr[i] = i * 0.2f; } - engineConfiguration->overrideCrankingIacSetting = true; EXPECT_FLOAT_EQ(5, dut.getCrankingOpenLoop(10)); EXPECT_FLOAT_EQ(25, dut.getCrankingOpenLoop(50)); } @@ -249,8 +248,6 @@ TEST(idle_v2, testOpenLoopCranking) { EngineTestHelper eth(engine_type_e::TEST_ENGINE); StrictMock dut; - engineConfiguration->overrideCrankingIacSetting = true; - EXPECT_CALL(dut, getCrankingOpenLoop(30)).WillOnce(Return(44)); // Should return the value from getCrankingOpenLoop, and ignore running numbers