andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

reducing/moving technical debt

This commit is contained in:
Andrey 2023-08-29 16:53:49 -04:00
parent d2f899e737
commit 63295873b4
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
firmware/controllers/algo/defaults/default_base_engine.cpp
View File

@ -43,13 +43,13 @@ static void setDefaultHPFP() {
// todo: would be nice for unit tests to be happy about these defaults
#if EFI_PROD_CODE
engineConfiguration->hpfpPumpVolume = 0.290;
#endif
engineConfiguration->hpfpMinAngle = 10;
engineConfiguration->hpfpActivationAngle = 30;
engineConfiguration->hpfpTargetDecay = 2000;
engineConfiguration->hpfpPidP = 0.01;
engineConfiguration->hpfpPidI = 0.0003;
engineConfiguration->hpfpPeakPos = 10;
#endif
}
void setDefaultBaseEngine() {

10
unit_tests/tests/test_hpfp.cpp
View File

@ -106,6 +106,11 @@ TEST(HPFP, InjectionReplacementFuel) {
TEST(HPFP, PI) {
EngineTestHelper eth(engine_type_e::TEST_ENGINE);
engineConfiguration->hpfpTargetDecay = 0;
engineConfiguration->hpfpPidP = 0;
engineConfiguration->hpfpPidI = 0;
engineConfiguration->hpfpPeakPos = 0;
engineConfiguration->cylindersCount = 4;
engineConfiguration->hpfpCamLobes = 4;
engine->engineState.injectionMass[0] = 0.05 /* cc/cyl */ * fuelDensity;
@ -163,6 +168,11 @@ TEST(HPFP, PI) {
TEST(HPFP, Angle) {
EngineTestHelper eth(engine_type_e::TEST_ENGINE);
engineConfiguration->hpfpTargetDecay = 0;
engineConfiguration->hpfpPidP = 0;
engineConfiguration->hpfpPidI = 0;
engineConfiguration->hpfpPeakPos = 0;
engineConfiguration->cylindersCount = 4;
engineConfiguration->hpfpCamLobes = 4;
engine->engineState.injectionMass[0] = 0.05 /* cc/cyl */ * fuelDensity;