From 6347b11c27fddbc569e348ebc71f46b1d67e1a2a Mon Sep 17 00:00:00 2001 From: rusefi Date: Fri, 31 Mar 2023 10:03:18 -0400 Subject: [PATCH] VSS input: one step back --- firmware/console/binary/output_channels.txt | 2 +- firmware/controllers/sensors/frequency_sensor.cpp | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/firmware/console/binary/output_channels.txt b/firmware/console/binary/output_channels.txt index ad634cd849..d46f404666 100644 --- a/firmware/console/binary/output_channels.txt +++ b/firmware/console/binary/output_channels.txt @@ -103,7 +103,7 @@ uint16_t rpmAcceleration;dRPM;"RPM/s",1, 0, 0, 5, 2 int16_t autoscale tpsAccelFuel;@@GAUGE_NAME_FUEL_TPS_EXTRA@@;"ms",{1/@@PACK_MULT_MS@@}, 0, 0, 0, 3 ! Ignition int16_t autoscale ignitionAdvance;@@GAUGE_NAME_TIMING_ADVANCE@@;"deg",{1/@@PACK_MULT_ANGLE@@}, 0, 0, 0, 1 - uint16_t globalFrequencyInputCounter;;"",1, 0, 0, 65000, 0, @@GAUGE_CATEGORY_SYNC@@ + uint16_t unusedDwellWasHere uint16_t autoscale coilDutyCycle;@@GAUGE_NAME_DWELL_DUTY@@;"%",{1/@@PACK_MULT_PERCENT@@}, 0, 0, 0, 0 ! Idle & ETB diff --git a/firmware/controllers/sensors/frequency_sensor.cpp b/firmware/controllers/sensors/frequency_sensor.cpp index 4ba888a2d5..3b32077da6 100644 --- a/firmware/controllers/sensors/frequency_sensor.cpp +++ b/firmware/controllers/sensors/frequency_sensor.cpp @@ -26,11 +26,6 @@ void FrequencySensor::initIfValid(brain_pin_e pin, SensorConverter &converter, f m_filter.configureLowpass(1, filterParameter); -#if ! EFI_UNIT_TEST - // a global counter is so much better than nothing right? at least some way to validate VSS input - engine->outputChannels.globalFrequencyInputCounter++; -#endif - setFunction(converter); m_pin = pin; @@ -58,6 +53,7 @@ void FrequencySensor::deInit() { } void FrequencySensor::onEdge(efitick_t nowNt) { + // diagnostics eventCounter++; float frequency = 1 / m_edgeTimer.getElapsedSecondsAndReset(nowNt);