andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

better rpm=0 behavior for VvtController

This commit is contained in:
andreika-git 2023-11-11 02:07:17 +02:00 committed by rusefillc
parent c299d1c331
commit 7957c24552
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
firmware/controllers/actuators/vvt.cpp
View File

@ -58,6 +58,12 @@ expected<angle_t> VvtController::observePlant() {
expected<angle_t> VvtController::getSetpoint() {
int rpm = Sensor::getOrZero(SensorType::Rpm);
bool enabled = rpm > engineConfiguration->vvtControlMinRpm
&& engine->rpmCalculator.getSecondsSinceEngineStart(getTimeNowNt()) > engineConfiguration->vvtActivationDelayMs / MS_PER_SECOND
;
if (!enabled)
return unexpected;
float load = getFuelingLoad();
float target = m_targetMap->getValue(rpm, load);
@ -104,14 +110,9 @@ expected<percent_t> VvtController::getClosedLoop(angle_t target, angle_t observa
void VvtController::setOutput(expected<percent_t> outputValue) {
#if EFI_SHAFT_POSITION_INPUT
float rpm = Sensor::getOrZero(SensorType::Rpm);
bool enabled = rpm > engineConfiguration->vvtControlMinRpm
&& engine->rpmCalculator.getSecondsSinceEngineStart(getTimeNowNt()) > engineConfiguration->vvtActivationDelayMs / MS_PER_SECOND
;
vvtOutput = outputValue.value_or(0);
if (outputValue && enabled) {
if (outputValue) {
m_pwm->setSimplePwmDutyCycle(PERCENT_TO_DUTY(outputValue.Value));
} else {
m_pwm->setSimplePwmDutyCycle(0);