* only:moving isIdleClosedLoop into idle live data

* only:moving isIdleClosedLoop into idle live data

---------

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
This commit is contained in:
rusefillc 2023-09-26 21:10:47 -04:00 committed by GitHub
parent e29480622e
commit 7c1ec7843e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 6 deletions

View File

@ -33,7 +33,6 @@ bit isPedalError;Error: Pedal
bit isKnockChipOk; bit isKnockChipOk;
bit launchTriggered;Launch Control Triggered bit launchTriggered;Launch Control Triggered
bit isTps2Error;Error: TPS2 bit isTps2Error;Error: TPS2
bit isIdleClosedLoop;Idle: Closed Loop
bit injectorFault;Injector Fault bit injectorFault;Injector Fault
bit ignitionFault;Ignition Fault bit ignitionFault;Ignition Fault
bit isMainRelayOn; bit isMainRelayOn;

View File

@ -10,7 +10,7 @@ custom idle_state_e 4 bits, S32, @OFFSET@, [0:2], "not important"
percent_t iacByTpsTaper;idle: iacByTpsTaper portion percent_t iacByTpsTaper;idle: iacByTpsTaper portion
int throttlePedalUpState;idle: throttlePedalUpState\ntrue in IDLE throttle pedal state, false if driver is touching the pedal\ntodo: better name for this field? int throttlePedalUpState;idle: throttlePedalUpState\ntrue in IDLE throttle pedal state, false if driver is touching the pedal\ntodo: better name for this field?
bit mightResetPid;idle: mightResetPid\nThe idea of 'mightResetPid' is to reset PID only once - each time when TPS > idlePidDeactivationTpsThreshold.\nThe throttle pedal can be pressed for a long time, making the PID data obsolete (thus the reset is required).\nWe set 'mightResetPid' to true only if PID was actually used (i.e. idlePid.getOutput() was called) to save some CPU resources.\nSee automaticIdleController(). bit mightResetPid;idle: mightResetPid\nThe idea of 'mightResetPid' is to reset PID only once - each time when TPS > idlePidDeactivationTpsThreshold.\nThe throttle pedal can be pressed for a long time, making the PID data obsolete (thus the reset is required).\nWe set 'mightResetPid' to true only if PID was actually used (i.e. idlePid.getOutput() was called) to save some CPU resources.\nSee automaticIdleController().
bit shouldResetPid;Idle: shouldResetPid bit shouldResetPid;Idle: shouldResetPid
bit wasResetPid;Idle: wasResetPid\nThis is needed to slowly turn on the PID back after it was reset. bit wasResetPid;Idle: wasResetPid\nThis is needed to slowly turn on the PID back after it was reset.
@ -21,13 +21,13 @@ bit mightResetPid;idle: mightResetPid\nThe idea of 'mightResetPid' is to reset P
bit needReset;Idle: reset bit needReset;Idle: reset
bit isInDeadZone;Idle: dead zone bit isInDeadZone;Idle: dead zone
bit isBlipping bit isBlipping
bit useClosedLoop bit useClosedLoop
bit badTps bit badTps
bit looksLikeRunning bit looksLikeRunning
bit looksLikeCoasting bit looksLikeCoasting
bit looksLikeCrankToIdle bit looksLikeCrankToIdle
bit isIdleCoasting;Idle: coasting bit isIdleCoasting;Idle: coasting
bit isIdleClosedLoop;Idle: Closed loop active
int targetRpmByClt;idle: target by CLT int targetRpmByClt;idle: target by CLT
int targetRpmAcBump;idle: A/C bump int targetRpmAcBump;idle: A/C bump

View File

@ -357,7 +357,7 @@ float IdleController::getIdlePosition(float rpm) {
} }
#if EFI_TUNER_STUDIO && (EFI_PROD_CODE || EFI_SIMULATOR) #if EFI_TUNER_STUDIO && (EFI_PROD_CODE || EFI_SIMULATOR)
engine->outputChannels.isIdleClosedLoop = phase == Phase::Idling; isIdleClosedLoop = phase == Phase::Idling;
if (engineConfiguration->idleMode == IM_AUTO) { if (engineConfiguration->idleMode == IM_AUTO) {
// see also tsOutputChannels->idlePosition // see also tsOutputChannels->idlePosition