andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Usability: turn on boost controller without ECU power cycle fix #6761 

shame on me for lack of TDD
This commit is contained in:
rusefi 2024-08-01 18:30:05 -04:00
parent 70f32ce81a
commit 82db3bfa6d
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
firmware/CHANGELOG.md
View File

@ -44,6 +44,7 @@ Release template (copy/paste this for new release):
- STM32Cube v2.17 - STM32Cube v2.17
- Better validation of thermistor configuration #6724 - Better validation of thermistor configuration #6724
- Full layout vs tuning layout #5154 - Full layout vs tuning layout #5154
- Usability: turn on boost controller without ECU power cycle #6761
### Fixed ### Fixed
- knock logic not activated until any configuration change via TS #6462 - knock logic not activated until any configuration change via TS #6462

8
firmware/controllers/actuators/boost_control.cpp
View File

@ -53,6 +53,10 @@ void BoostController::resetLua() {
} }
void BoostController::onConfigurationChange(engine_configuration_s const * previousConfig) { void BoostController::onConfigurationChange(engine_configuration_s const * previousConfig) {
#if EFI_PROD_CODE
initBoostCtrl();
#endif
if (!previousConfig || !m_pid.isSame(&previousConfig->boostPid)) { if (!previousConfig || !m_pid.isSame(&previousConfig->boostPid)) {
m_shouldResetPid = true; m_shouldResetPid = true;
} }
@ -305,6 +309,10 @@ void startBoostPin() {
void initBoostCtrl() { void initBoostCtrl() {
#if EFI_PROD_CODE #if EFI_PROD_CODE
if (engine->module<BoostController>().unmock().hasInitBoost) {
// already initialized - nothing to do here
return;
}
// todo: why do we have 'isBoostControlEnabled' setting exactly? // todo: why do we have 'isBoostControlEnabled' setting exactly?
// 'initVvtActuators' is an example of a subsystem without explicit enable // 'initVvtActuators' is an example of a subsystem without explicit enable
if (!engineConfiguration->isBoostControlEnabled) { if (!engineConfiguration->isBoostControlEnabled) {