ISO-TP does not work on real car #4427

oh shit :(

firmware/config/boards/hellen/hellen81/board.mk

@@ -8,7 +8,6 @@ DDEFS += -DEFI_MAIN_RELAY_CONTROL=TRUE
 
 # Disable serial ports on this board as UART3 causes a DMA conflict with the SD card
 DDEFS += -DTS_NO_PRIMARY
-DDEFS += -DEFI_CAN_SERIAL=TRUE
 
 # Add them all together
 DDEFS += -DFIRMWARE_ID=\"hellen81\"

firmware/config/boards/microrusefi/board.mk

@@ -29,9 +29,7 @@ DDEFS += -DEFI_USE_UART_DMA=FALSE -DTS_NO_PRIMARY=TRUE
 # maybe a way to disable SPI2 privately
 #DDEFS += -DSTM32_SPI_USE_SPI2=FALSE
 
-DDEFS += -DEFI_CAN_SERIAL=TRUE
-
-DDEFS += -DEFI_CJ125=FALSE -DBOARD_L9779_COUNT=0 -DEFI_HD44780_LCD=FALSE -DEFI_LCD=FALSE 
+DDEFS += -DEFI_CJ125=FALSE -DBOARD_L9779_COUNT=0 -DEFI_HD44780_LCD=FALSE -DEFI_LCD=FALSE
 
 DDEFS += -DFIRMWARE_ID=\"microRusEFI\"
 DDEFS += -DEFI_SOFTWARE_KNOCK=TRUE -DSTM32_ADC_USE_ADC3=TRUE

firmware/config/boards/proteus/board.mk

@@ -15,8 +15,6 @@ DDEFS += $(VAR_DEF_ENGINE_TYPE)
 
 DDEFS += -DEFI_MAIN_RELAY_CONTROL=TRUE
 
-DDEFS += -DEFI_CAN_SERIAL=TRUE
-
 # Turn off stuff proteus doesn't have/need
 DDEFS += -DEFI_CJ125=FALSE -DEFI_MAX_31855=FALSE -DBOARD_L9779_COUNT=0 -DBOARD_TLE8888_COUNT=0 -DEFI_HD44780_LCD=FALSE -DEFI_LCD=FALSE 
 

firmware/config/boards/tdg-pdm8/board.mk

@@ -14,7 +14,5 @@ DDEFS += -DEFI_USB_SERIAL=FALSE
 # We're running on TDG PDM hardware!
 DDEFS += -DHW_TDG_PDM8=1
 
-DDEFS += -DEFI_CAN_SERIAL=TRUE
-
 DDEFS += -DFIRMWARE_ID=\"tdg-pdm8\" -DSHORT_BOARD_NAME=tdg-pdm8
 DDEFS += -DDEFAULT_ENGINE_TYPE=MINIMAL_PINS

firmware/config/stm32f4ems/efifeatures.h

@@ -208,6 +208,10 @@
 #define EFI_CAN_SUPPORT TRUE
 #endif
 
+#ifndef EFI_CAN_SERIAL
+#define EFI_CAN_SERIAL TRUE
+#endif
+
 #define EFI_WIDEBAND_FIRMWARE_UPDATE TRUE
 
 #ifndef EFI_AUX_SERIAL

firmware/console/binary/ts_can_channel.cpp

@@ -10,7 +10,7 @@
 #include "tunerstudio.h"
 #include "tunerstudio_io.h"
 
-#ifdef EFI_CAN_SERIAL
+#if EFI_CAN_SERIAL
 #include "serial_can.h"
 #include "can_hw.h"
 
@@ -106,4 +106,4 @@ void startCanConsole() {
 	canStreamInit();
 }
 
-#endif // def EFI_CAN_SERIAL
+#endif // EFI_CAN_SERIAL