andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Stricter compile options (#1132) 

* stricter

* don't warn on that one

* this code was dead
This commit is contained in:
Matthew Kennedy 2020-02-08 03:05:40 -08:00 committed by GitHub
parent a00c1a5be9
commit 8c118f2fbe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 11 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
firmware/Makefile
View File

@ -37,21 +37,19 @@ endif
# Compiler options here.
ifeq ($(USE_OPT),)
USE_OPT = $(EXTRA_PARAMS) $(DEBUG_LEVEL_OPT) $(RFLAGS) -Wno-error=implicit-fallthrough -Wno-error=bool-operation -fomit-frame-pointer -falign-functions=16 -Werror=type-limits -Wno-error=strict-aliasing -Wno-error=attributes
USE_OPT = $(EXTRA_PARAMS) $(DEBUG_LEVEL_OPT) $(RFLAGS) -fomit-frame-pointer -falign-functions=16
endif
USE_OPT += $(RUSEFI_OPT)
# C specific options here (added to USE_OPT).
ifeq ($(USE_COPT),)
USE_COPT = -fgnu89-inline -std=gnu99 -Werror-implicit-function-declaration
USE_COPT = -fgnu89-inline -std=gnu99 -Wno-error=implicit-fallthrough
endif
# C++ specific options here (added to USE_OPT).
ifeq ($(USE_CPPOPT),)
# constexpr float expf_taylor_impl probably needs just c++14 but why not go with 17?
USE_CPPOPT = -std=c++17 -Wno-register -fno-rtti -fno-threadsafe-statics -fno-exceptions -fno-use-cxa-atexit -Werror=write-strings -Werror=type-limits
USE_CPPOPT = -std=c++17 -Wno-register -fno-rtti -fno-threadsafe-statics -fno-exceptions -fno-use-cxa-atexit
endif
# Enable this if you want the linker to remove unused code and data

2
firmware/controllers/core/common_headers.h
View File

@ -88,6 +88,8 @@
#define EXPAND_Engine \
engine_configuration_s *engineConfiguration = engine->engineConfigurationPtr; \
persistent_config_s *config = engine->config; \
(void)engineConfiguration; \
(void)config; \
#ifndef EFI_ACTIVE_CONFIGURATION_IN_FLASH

4
firmware/controllers/math/engine_math.cpp
View File

@ -65,8 +65,8 @@ float getEngineLoadT(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
}
return getMafVoltage(PASS_ENGINE_PARAMETER_SIGNATURE);
case LM_SPEED_DENSITY:
// SD engine load is used for timing lookup but not for fuel calculation
[[fallthrough]]
// SD engine load is used for timing lookup but not for fuel calculation,
// so fall thru to the MAP case.
case LM_MAP:
return getMap(PASS_ENGINE_PARAMETER_SIGNATURE);
case LM_ALPHA_N:

12
firmware/hw_layer/servo.cpp
View File

@ -27,18 +27,6 @@ THD_WORKING_AREA(servoThreadStack, UTILITY_THREAD_STACK_SIZE * 3);
static OutputPin pins[SERVO_COUNT];
static int countServos() {
int result = 0;
for (int i = 0; i < SERVO_COUNT; i++) {
if (engineConfiguration->servoOutputPins[i] != GPIO_UNASSIGNED) {
result++;
}
}
return result;
}
static scheduling_s servoTurnSignalOff;
// todo: extract common 'pin off' callback?

8
firmware/rusefi_rules.mk
View File

@ -1,5 +1,5 @@
RUSEFI_OPT=-Werror -Wno-error=pointer-sign -Wno-error=unused-function -Wno-error=unused-variable -Wno-error=sign-compare -Wno-error=unused-parameter -Werror=missing-field-initializers
# Warnings-as-errors...
RUSEFI_OPT = -Werror
RUSEFI_OPT+=-Wno-error=missing-prototypes
RUSEFI_OPT+=-Werror=switch
# ...except these few
RUSEFI_OPT += -Wno-error=unused-function -Wno-error=unused-variable -Wno-error=sign-compare -Wno-error=unused-parameter