diff --git a/unit_tests/tests/test_idle_controller.cpp b/unit_tests/tests/test_idle_controller.cpp index aa6a81eb80..5d6abb05a7 100644 --- a/unit_tests/tests/test_idle_controller.cpp +++ b/unit_tests/tests/test_idle_controller.cpp @@ -129,12 +129,12 @@ TEST(idle_v2, crankingOpenLoop) { TEST(idle_v2, runningOpenLoopBasic) { EngineTestHelper eth(engine_type_e::TEST_ENGINE); IdleController dut; - - engineConfiguration->manIdlePosition = 50; + // this config would be removed (cltIdleCorr will contain the position not the multiplier) + engineConfiguration->manIdlePosition = 1; for (size_t i = 0; i < efi::size(config->cltIdleCorrBins); i++) { config->cltIdleCorrBins[i] = i * 10; - config->cltIdleCorr[i] = i * 0.1f; + config->cltIdleCorr[i] = 50 * (i * 0.1f); } EXPECT_FLOAT_EQ(5, dut.getRunningOpenLoop(IIdleController::Phase::Cranking, 0, 10, 0)); @@ -145,12 +145,12 @@ TEST(idle_v2, runningFanAcBump) { EngineTestHelper eth(engine_type_e::TEST_ENGINE); IdleController dut; - engineConfiguration->manIdlePosition = 50; + engineConfiguration->manIdlePosition = 1; engineConfiguration->acIdleExtraOffset = 9; engineConfiguration->fan1ExtraIdle = 7; engineConfiguration->fan2ExtraIdle = 3; - setArrayValues(config->cltIdleCorr, 1.0f); + setArrayValues(config->cltIdleCorr, 50.0f); // Start with fan off enginePins.fanRelay.setValue(0); @@ -185,10 +185,10 @@ TEST(idle_v2, idleAdderShouldNotAffectNonIdleAreas) { EngineTestHelper eth(engine_type_e::TEST_ENGINE); IdleController dut; - engineConfiguration->manIdlePosition = 50; + engineConfiguration->manIdlePosition = 1; engineConfiguration->acIdleExtraOffset = 9; - setArrayValues(config->cltIdleCorr, 1.0f); + setArrayValues(config->cltIdleCorr, 50.0f); // Should be base position EXPECT_FLOAT_EQ(50, dut.getRunningOpenLoop(IIdleController::Phase::Cranking, 0, 10, 0));