andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

enhance formatting

This commit is contained in:
kifir 2024-04-21 22:00:59 +03:00 committed by rusefillc
parent 45397a814a
commit 965d758ad1
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
firmware/controllers/engine_cycle/spark_logic.cpp
View File

@ -294,23 +294,23 @@ static bool startDwellByTurningSparkPinHigh(IgnitionEvent *event, IgnitionOutput
output->currentLogicValue, output->outOfOrder, event->sparkCounter);
#endif /* SPARK_EXTREME_LOGGING */
if (output->signalFallSparkId >= event->sparkCounter) {
/**
* fact: we schedule both start of dwell and spark firing using a combination of time and trigger event domain
* in case of bad/noisy signal we can get unexpected trigger events and a small time delay for spark firing before
* we even start dwell if it scheduled with a longer time-only delay with fewer trigger events
*
* here we are detecting such out-of-order processing and choose the safer route of not even starting dwell
* [tag] #6349
*/
if (output->signalFallSparkId >= event->sparkCounter) {
/**
* fact: we schedule both start of dwell and spark firing using a combination of time and trigger event domain
* in case of bad/noisy signal we can get unexpected trigger events and a small time delay for spark firing before
* we even start dwell if it scheduled with a longer time-only delay with fewer trigger events
*
* here we are detecting such out-of-order processing and choose the safer route of not even starting dwell
* [tag] #6349
*/
#if SPARK_EXTREME_LOGGING
efiPrintf("[%s] bail spark dwell\n", output->getName());
efiPrintf("[%s] bail spark dwell\n", output->getName());
#endif /* SPARK_EXTREME_LOGGING */
// let's save this coil if things do not look right
engine->engineState.sparkOutOfOrderCounter++;
return true;
}
// let's save this coil if things do not look right
engine->engineState.sparkOutOfOrderCounter++;
return true;
}
if (output->outOfOrder) {
output->outOfOrder = false;
@ -410,7 +410,7 @@ static void scheduleSparkEvent(bool limitedSpark, IgnitionEvent *event,
#endif /* SPARK_EXTREME_LOGGING */
/**
/**
* Note how we do not check if spark is limited or not while scheduling 'spark down'
* This way we make sure that coil dwell started while spark was enabled would fire and not burn
* the coil.