andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

basic hw in the loop - pwm self validation #2028

This commit is contained in:
rusefillc 2020-12-07 20:42:47 -05:00
parent 6b80297245
commit 96c29840ce
4 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
firmware/development/logic_analyzer.cpp
View File

@ -233,7 +233,7 @@ void startLogicAnalyzerPins() {
void stopLogicAnalyzerPins() { void stopLogicAnalyzerPins() {
for (int index = 0; index < LOGIC_ANALYZER_CHANNEL_COUNT; index++) { for (int index = 0; index < LOGIC_ANALYZER_CHANNEL_COUNT; index++) {
brain_pin_e brainPin = CONFIG(logicAnalyzerPins)[index]; brain_pin_e brainPin = activeConfiguration.logicAnalyzerPins[index];
if (brainPin != GPIO_UNASSIGNED) { if (brainPin != GPIO_UNASSIGNED) {
stopDigitalCapture("wave input", brainPin); stopDigitalCapture("wave input", brainPin);

2
firmware/hw_layer/digital_input/digital_input_icu.cpp
View File

@ -219,7 +219,7 @@ void stopDigitalCapture(const char *msg, brain_pin_e brainPin) {
if (driver == NULL) { if (driver == NULL) {
return; return;
} }
efiSetPadUnused(brainPin);
int regSize = registeredIcus.size; int regSize = registeredIcus.size;
for (int i = 0; i < regSize; i++) { for (int i = 0; i < regSize; i++) {
if (registeredIcus.elements[i].driver == driver) { if (registeredIcus.elements[i].driver == driver) {

1
firmware/hw_layer/drivers/can/can_hw.cpp
View File

@ -151,6 +151,7 @@ void enableFrankensoCan(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
engineConfiguration->canReadEnabled = false; engineConfiguration->canReadEnabled = false;
} }
// todo: we usually use 'activeConfiguration' for 'stopPin' why this unusual code here?
// this is related to #1375 // this is related to #1375
static brain_pin_e currentTxPin = GPIO_UNASSIGNED; static brain_pin_e currentTxPin = GPIO_UNASSIGNED;
static brain_pin_e currentRxPin = GPIO_UNASSIGNED; static brain_pin_e currentRxPin = GPIO_UNASSIGNED;

10
firmware/hw_layer/hardware.cpp
View File

@ -304,8 +304,14 @@ void stopSpi(spi_device_e device) {
*/ */
void applyNewHardwareSettings(void) { void applyNewHardwareSettings(void) {
// all 'stop' methods need to go before we begin starting pins /**
* All 'stop' methods need to go before we begin starting pins.
*
* We take settings from 'activeConfiguration' not 'engineConfiguration' while stopping hardware.
* Some hardware is restart unconditionally on change of parameters while for some systems we make extra effort and restart only
* relevant settings were changes.
*
*/
ButtonDebounce::stopConfigurationList(); ButtonDebounce::stopConfigurationList();
#if EFI_SHAFT_POSITION_INPUT #if EFI_SHAFT_POSITION_INPUT