From 9d321489717dfe0ee08e9dd6508a745733ffbe8f Mon Sep 17 00:00:00 2001 From: Matthew Kennedy Date: Sat, 6 Jan 2024 20:28:02 -0800 Subject: [PATCH] remove inaccurate comments - we have ignition overdwell protect --- firmware/controllers/engine_cycle/main_trigger_callback.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/firmware/controllers/engine_cycle/main_trigger_callback.cpp b/firmware/controllers/engine_cycle/main_trigger_callback.cpp index 5af043d661..cbba9e101e 100644 --- a/firmware/controllers/engine_cycle/main_trigger_callback.cpp +++ b/firmware/controllers/engine_cycle/main_trigger_callback.cpp @@ -224,7 +224,6 @@ void mainTriggerCallback(uint32_t trgEventIndex, efitick_t edgeTimestamp, angle_ if (hasFirmwareError()) { /** * In case on a major error we should not process any more events. - * TODO: add 'pin shutdown' invocation somewhere - coils might be still open here! */ return; } @@ -235,12 +234,10 @@ void mainTriggerCallback(uint32_t trgEventIndex, efitick_t edgeTimestamp, angle_ // this happens while we just start cranking // todo: check for 'trigger->is_synchnonized?' - // TODO: add 'pin shutdown' invocation somewhere - coils might be still open here! return; } if (rpm == NOISY_RPM) { warning(ObdCode::OBD_Crankshaft_Position_Sensor_A_Circuit_Malfunction, "noisy trigger"); - // TODO: add 'pin shutdown' invocation somewhere - coils might be still open here! return; }