From a59ac4ad0e3d967e0bae9fe5b80a2a2c67f14102 Mon Sep 17 00:00:00 2001 From: rusefi Date: Sun, 5 May 2019 12:48:04 -0400 Subject: [PATCH] 8888 usability --- firmware/config/engines/custom_engine.cpp | 14 ++++++++++---- .../controllers/actuators/electronic_throttle.cpp | 4 +--- firmware/tunerstudio/rusefi.ini | 5 ++++- firmware/tunerstudio/rusefi.input | 3 +++ 4 files changed, 18 insertions(+), 8 deletions(-) diff --git a/firmware/config/engines/custom_engine.cpp b/firmware/config/engines/custom_engine.cpp index 6a08af3f31..6629f3079d 100644 --- a/firmware/config/engines/custom_engine.cpp +++ b/firmware/config/engines/custom_engine.cpp @@ -390,10 +390,16 @@ void setTle8888TestConfiguration(DECLARE_CONFIG_PARAMETER_SIGNATURE) { engineConfiguration->tps1_1AdcChannel = EFI_ADC_3; // PA3 engineConfiguration->throttlePedalPositionAdcChannel = EFI_ADC_7; // PA7 - engineConfiguration->etb.pFactor = 1.07; - engineConfiguration->etb.iFactor = 0.18; - engineConfiguration->etb.dFactor = 0.24; - engineConfiguration->etb.offset = 80; +// engineConfiguration->etb.pFactor = 1.07; +// engineConfiguration->etb.iFactor = 0.18; +// engineConfiguration->etb.dFactor = 0.24; +// engineConfiguration->etb.offset = 80; + + engineConfiguration->etb.pFactor = 22; + engineConfiguration->etb.iFactor = 0; + engineConfiguration->etb.dFactor = 0; + engineConfiguration->etb.offset = 0; + #if EFI_PROD_CODE engineConfiguration->etb.periodMs = (1000 / DEFAULT_ETB_LOOP_FREQUENCY); engineConfiguration->etbFreq = DEFAULT_ETB_PWM_FREQUENCY; diff --git a/firmware/controllers/actuators/electronic_throttle.cpp b/firmware/controllers/actuators/electronic_throttle.cpp index 319a3e31d2..5cc6f0fad1 100644 --- a/firmware/controllers/actuators/electronic_throttle.cpp +++ b/firmware/controllers/actuators/electronic_throttle.cpp @@ -4,12 +4,10 @@ * * todo: make this more universal if/when we get other hardware options * + * May 2019 two-wire TLE7209 now behaves same as three-wire VNH2SP30 * Apr 2019 two-wire TLE7209 support added - * * Mar 2019 best results so far achieved with three-wire H-bridges like VNH2SP30 - * * Jan 2019 actually driven around the block but still need some work. - * * Jan 2017 status: * Electronic throttle body with it's spring is definitely not linear - both P and I factors of PID are required to get any results * PID implementation tested on a bench only diff --git a/firmware/tunerstudio/rusefi.ini b/firmware/tunerstudio/rusefi.ini index 7dfafd494f..c1a6b3691f 100644 --- a/firmware/tunerstudio/rusefi.ini +++ b/firmware/tunerstudio/rusefi.ini @@ -68,7 +68,7 @@ enable2ndByteCanID = false ; see PAGE_0_SIZE in C source code ; CONFIG_DEFINITION_START -; this section was generated automatically by ConfigDefinition.jar based on rusefi_config.txt Sun May 05 11:03:35 EDT 2019 +; this section was generated automatically by ConfigDefinition.jar based on rusefi_config.txt Sun May 05 12:45:28 EDT 2019 pageSize = 20000 page = 1 @@ -2186,6 +2186,8 @@ cmd_set_engine_type_Miata_NA6_VAF = "w\x00\x30\x00\x39" cmd_set_engine_type_Miata_NA2 = "w\x00\x30\x00\x2F" ; ETB_BENCH_ENGINE = 58 cmd_set_engine_type_etb_test = "w\x00\x30\x00\x3A" +; ETB_BENCH_ENGINE = 59 +cmd_set_engine_type_8888_test = "w\x00\x30\x00\x3B" cmd_set_engine_type_default = "w\x00\x31\x00\x00" [UserDefined] @@ -3365,6 +3367,7 @@ cmd_set_engine_type_default = "w\x00\x31\x00\x00" commandButton = "Miata NA6 Stage 1", cmd_set_engine_type_Miata_NA6_MAP commandButton = "Miata NB2 MAP", cmd_set_engine_type_Miata_NA2 commandButton = "ETB test bench", cmd_set_engine_type_etb_test + commandButton = "TLE8888B test bench", cmd_set_engine_type_8888_test commandButton = "Reset firmware settings", cmd_set_engine_type_default diff --git a/firmware/tunerstudio/rusefi.input b/firmware/tunerstudio/rusefi.input index 9a63caccbd..d02e395896 100644 --- a/firmware/tunerstudio/rusefi.input +++ b/firmware/tunerstudio/rusefi.input @@ -1257,6 +1257,8 @@ cmd_set_engine_type_Miata_NA6_VAF = "w\x00\x30\x00\x39" cmd_set_engine_type_Miata_NA2 = "w\x00\x30\x00\x2F" ; ETB_BENCH_ENGINE = 58 cmd_set_engine_type_etb_test = "w\x00\x30\x00\x3A" +; ETB_BENCH_ENGINE = 59 +cmd_set_engine_type_8888_test = "w\x00\x30\x00\x3B" cmd_set_engine_type_default = "w\x00\x31\x00\x00" [UserDefined] @@ -2436,6 +2438,7 @@ cmd_set_engine_type_default = "w\x00\x31\x00\x00" commandButton = "Miata NA6 Stage 1", cmd_set_engine_type_Miata_NA6_MAP commandButton = "Miata NB2 MAP", cmd_set_engine_type_Miata_NA2 commandButton = "ETB test bench", cmd_set_engine_type_etb_test + commandButton = "TLE8888B test bench", cmd_set_engine_type_8888_test commandButton = "Reset firmware settings", cmd_set_engine_type_default