andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

only: onKnockSenseCompleted return value is never used

This commit is contained in:
rusefillc 2024-08-03 15:17:34 -04:00
parent 71f0f7ed4b
commit a94d463d9a
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
firmware/controllers/engine_cycle/knock_controller.cpp
View File

@ -44,7 +44,7 @@ int getCylinderKnockBank(uint8_t cylinderNumber) {
} }
} }
bool KnockControllerBase::onKnockSenseCompleted(uint8_t cylinderNumber, float dbv, float frequency, efitick_t lastKnockTime) { void KnockControllerBase::onKnockSenseCompleted(uint8_t cylinderNumber, float dbv, float frequency, efitick_t lastKnockTime) {
bool isKnock = dbv > m_knockThreshold; bool isKnock = dbv > m_knockThreshold;
// Per-cylinder peak detector // Per-cylinder peak detector
@ -74,8 +74,6 @@ bool KnockControllerBase::onKnockSenseCompleted(uint8_t cylinderNumber, float db
m_knockRetard = clampF(0, newRetard, m_maximumRetard); m_knockRetard = clampF(0, newRetard, m_maximumRetard);
} }
} }
return isKnock;
} }
float KnockControllerBase::getKnockRetard() const { float KnockControllerBase::getKnockRetard() const {

2
firmware/controllers/engine_cycle/knock_logic.h
View File

@ -22,7 +22,7 @@ public:
void onFastCallback() override; void onFastCallback() override;
// onKnockSenseCompleted is the callback from the knock sense driver to report a sensed knock level // onKnockSenseCompleted is the callback from the knock sense driver to report a sensed knock level
bool onKnockSenseCompleted(uint8_t cylinderNumber, float dbv, float frequency, efitick_t lastKnockTime); void onKnockSenseCompleted(uint8_t cylinderNumber, float dbv, float frequency, efitick_t lastKnockTime);
float getKnockRetard() const; float getKnockRetard() const;
uint32_t getKnockCount() const; uint32_t getKnockCount() const;