andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Better handling in case of ETB idle without ETB #1332

This commit is contained in:
rusefi 2020-04-19 23:55:27 -04:00
parent 1ced7eafbc
commit ad7c4f23bc
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
firmware/controllers/actuators/idle_thread.cpp
View File

@ -154,6 +154,13 @@ static void applyIACposition(percent_t position) {
float duty = PERCENT_TO_DUTY(position); float duty = PERCENT_TO_DUTY(position);
if (CONFIG(useETBforIdleControl)) { if (CONFIG(useETBforIdleControl)) {
if (!Sensor::hasSensor(SensorType::AcceleratorPedal)) {
firmwareError(CUSTOM_NO_ETB_FOR_IDLE, "No ETB to use for idle");
return;
}
engine->engineState.idle.etbIdleAddition = duty * CONFIG(etbIdleThrottleRange); engine->engineState.idle.etbIdleAddition = duty * CONFIG(etbIdleThrottleRange);
#if ! EFI_UNIT_TEST #if ! EFI_UNIT_TEST
} if (CONFIG(useStepperIdle)) { } if (CONFIG(useStepperIdle)) {

2
firmware/controllers/core/error_handling.h
View File

@ -26,6 +26,8 @@ bool warning(obd_code_e code, const char *fmt, ...);
typedef uint8_t critical_msg_t[ERROR_BUFFER_SIZE]; typedef uint8_t critical_msg_t[ERROR_BUFFER_SIZE];
/** /**
* Something really bad had happened - firmware cannot function, we cannot run the engine * Something really bad had happened - firmware cannot function, we cannot run the engine
* We definitely use this critical error approach in case of invalid configuration. If user sets a self-contradicting
* configuration we have to just put a hard stop on this.
* *
* see also warning() * see also warning()
*/ */