ETB jam detection #6925

meta
This commit is contained in:
Matthew Kennedy 2024-09-17 18:50:06 -07:00 committed by Andrey
parent cecc471ad8
commit b160bdd9a4
4 changed files with 6 additions and 5 deletions

View File

@ -653,7 +653,7 @@ void EtbController::checkOutput(percent_t output) {
prevOutput = output;
#if EFI_UNIT_TEST
auto integratorLimit = engineConfiguration->etbJamIntegratorLimit;
auto integratorLimit = engineConfiguration->jamDetectThreshold;
if (integratorLimit != 0) {
float integrator = absF(m_pid.getIntegration());

View File

@ -1505,7 +1505,7 @@ tChargeMode_e tChargeMode;
uint16_t autoscale fordInjectorSmallPulseBreakPoint;;"mg", 0.001, 0, 0, 65, 3
uint8_t etbJamIntegratorLimit;;"%", 1, 0, 0, 50, 0
uint8_t jamDetectThreshold;;"%", 1, 0, 0, 50, 0
! Someday there will be a 6th option for BMW S55 that uses a separate shaft just for HPFP
#define hpfp_cam_e_enum "NONE", "Intake 1", "Exhaust 1", "Intake 2", "Exhaust 2"

View File

@ -4738,8 +4738,9 @@ dialog = tcuControls, "Transmission Settings"
field = "PWM Frequency", etbFreq
field = "Minimum ETB position", etbMinimumPosition
field = "Maximum ETB position", etbMaximumPosition
; field = "Jam detection integrator max", etbJamIntegratorLimit
; field = "Jam detection timeout period", etbJamTimeout
field = ""
field = "Jam detection error max", jamDetectThreshold
field = "Jam detection timeout period", etbJamTimeout
; we need the term about stepper idle in here, because there's a bug in TS that you can't have different visibility
; criteria for the same panel when used in multiple places
; todo: report bug to TS?

View File

@ -778,7 +778,7 @@ TEST(etb, jamDetection) {
Sensor::setMockValue(SensorType::AcceleratorPedal, 0.0f, true);
// Limit of 5%, 1 second
engineConfiguration->etbJamIntegratorLimit = 5;
engineConfiguration->jamDetectThreshold = 5;
engineConfiguration->etbJamTimeout = 1;
EtbController etb;