TS: do we need pageActivate ? (#7040)

firmware/console/binary/tunerstudio.cpp

@@ -93,8 +93,8 @@ static void printErrorCounters() {
 	efiPrintf("TunerStudio size=%d / total=%d / errors=%d / H=%d / O=%d / P=%d / B=%d",
 			sizeof(engine->outputChannels), tsState.totalCounter, tsState.errorCounter, tsState.queryCommandCounter,
 			tsState.outputChannelsCommandCounter, tsState.readPageCommandsCounter, tsState.burnCommandCounter);
-	efiPrintf("TunerStudio W=%d / C=%d / P=%d", tsState.writeValueCommandCounter,
+	efiPrintf("TunerStudio W=%d / C=%d", tsState.writeValueCommandCounter,
-			tsState.writeChunkCommandCounter, tsState.pageCommandCounter);
+			tsState.writeChunkCommandCounter);
 	efiPrintf("TunerStudio errors: underrun=%d / overrun=%d / crc=%d / unrecognized=%d / outofrange=%d / other=%d",
 			tsState.errorUnderrunCounter, tsState.errorOverrunCounter, tsState.errorCrcCounter,
 			tsState.errorUnrecognizedCommand, tsState.errorOutOfRange, tsState.errorOther);
@@ -191,14 +191,6 @@ void TunerStudio::sendErrorCode(TsChannelBase* tsChannel, uint8_t code, const ch
 	::sendErrorCode(tsChannel, code, msg);
 }
 
-void TunerStudio::handlePageSelectCommand(TsChannelBase *tsChannel) {
-	tsState.pageCommandCounter++;
-
-	efiPrintf("TS -> Set page (no-op)");
-
-	sendOkResponse(tsChannel);
-}
-
 bool validateOffsetCount(size_t offset, size_t count, TsChannelBase* tsChannel);
 
 extern bool rebootForPresetPending;
@@ -379,7 +371,7 @@ static void handleBurnCommand(TsChannelBase* tsChannel) {
 
 static bool isKnownCommand(char command) {
 	return command == TS_HELLO_COMMAND || command == TS_READ_COMMAND || command == TS_OUTPUT_COMMAND
-			|| command == TS_PAGE_COMMAND || command == TS_BURN_COMMAND || command == TS_SINGLE_WRITE_COMMAND
+			|| command == TS_BURN_COMMAND || command == TS_SINGLE_WRITE_COMMAND
 			|| command == TS_CHUNK_WRITE_COMMAND || command == TS_EXECUTE
 			|| command == TS_IO_TEST_COMMAND
 #if EFI_SIMULATOR
@@ -733,9 +725,6 @@ int TunerStudio::handleCrcCommand(TsChannelBase* tsChannel, char *data, int inco
 	case TS_EXECUTE:
 		handleExecuteCommand(tsChannel, data, incomingPacketSize - 1);
 		break;
-	case TS_PAGE_COMMAND:
-		handlePageSelectCommand(tsChannel);
-		break;
 	case TS_CHUNK_WRITE_COMMAND:
 		handleWriteChunkCommand(tsChannel, offset, count, data + sizeof(TunerStudioWriteChunkRequest));
 		break;

firmware/console/binary/tunerstudio_impl.h

@@ -31,8 +31,6 @@ public:
 	 */
 	void handleQueryCommand(TsChannelBase* tsChannel, ts_response_format_e mode);
 	void handleExecuteCommand(TsChannelBase* tsChannel, char *data, int incomingPacketSize);
-	// does more or less nothing, we only handle the command to make frontend application happy
-	void handlePageSelectCommand(TsChannelBase *tsChannel);
 	void handleWriteChunkCommand(TsChannelBase* tsChannel, uint16_t offset, uint16_t count,
 			void *content);
 	void handleCrc32Check(TsChannelBase *tsChannel, uint16_t offset, uint16_t count);

firmware/integration/ts_protocol.txt

@@ -14,9 +14,6 @@
 ! 0x6B 107
 #define TS_CRC_CHECK_COMMAND 'k'
 
-
-! 0x50 80
-#define TS_PAGE_COMMAND 'P'
 ! 0x46
 #define TS_COMMAND_F 'F'
 #define TS_GET_PROTOCOL_VERSION_COMMAND_F 'F'

java_console/io/src/main/java/com/rusefi/binaryprotocol/BinaryProtocol.java

@@ -76,8 +76,6 @@ public class BinaryProtocol {
 
     public static String findCommand(byte command) {
         switch (command) {
-            case Integration.TS_PAGE_COMMAND:
-                return "PAGE";
             case Integration.TS_COMMAND_F:
                 return "PROTOCOL";
             case Integration.TS_CRC_CHECK_COMMAND:

java_console/io/src/main/java/com/rusefi/io/tcp/BinaryProtocolServer.java

@@ -168,8 +168,6 @@ public class BinaryProtocolServer {
                 stream.sendPacket((TS_OK + "rusEFI proxy").getBytes());
             } else if (command == Integration.TS_CRC_CHECK_COMMAND) {
                 handleCrc(linkManager, stream);
-            } else if (command == Integration.TS_PAGE_COMMAND) {
-                stream.sendPacket(TS_OK.getBytes());
             } else if (command == Integration.TS_READ_COMMAND) {
                 ByteRange byteRange = ByteRange.valueOf(payload);
                 handleRead(linkManager, byteRange, stream);

java_console/io/src/test/java/com/rusefi/binaryprotocol/test/TcpServerSandbox.java

@@ -100,8 +100,6 @@ public class TcpServerSandbox {
             new HelloCommand(Fields.TS_SIGNATURE).handle(stream);
         } else if (command == Integration.TS_GET_PROTOCOL_VERSION_COMMAND_F) {
             stream.sendPacket((TS_OK + TS_PROTOCOL).getBytes());
-        } else if (command == Integration.TS_PAGE_COMMAND) {
-            stream.sendPacket(TS_OK.getBytes());
         } else if (command == Integration.TS_CRC_CHECK_COMMAND) {
             stream.sendPacket(BinaryProtocolServer.createCrcResponse(TOTALLY_EMPTY_CONFIGURATION));
         } else if (command == Integration.TS_SET_LOGGER_SWITCH) {