From b75ab76f1f630b46970cfeb95ec213bb8464bd9a Mon Sep 17 00:00:00 2001 From: rusefillc Date: Thu, 26 Nov 2020 16:56:18 -0500 Subject: [PATCH] Starter is engaged on start-up in pull-up configuration #1969 --- firmware/config/engines/bmw_e34.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/firmware/config/engines/bmw_e34.cpp b/firmware/config/engines/bmw_e34.cpp index ef12236e51..0d1ec0bf42 100644 --- a/firmware/config/engines/bmw_e34.cpp +++ b/firmware/config/engines/bmw_e34.cpp @@ -132,7 +132,10 @@ void setBmwE34(DECLARE_CONFIG_PARAMETER_SIGNATURE) { // idle engineConfiguration->idle.solenoidPin = GPIOC_14; + /* + * this configuration is used on HW CI - in HW CI 'inverted' would rightfully fail unless there is pull-up engineConfiguration->idle.solenoidPinMode = OM_INVERTED; +*/ engineConfiguration->idle.solenoidFrequency = 300; engineConfiguration->manIdlePosition = 50; // set_idle_pwm 50