From beebe4c233da804cbfdc1cc655ccbb1880ccfd27 Mon Sep 17 00:00:00 2001 From: pchmura4 Date: Sun, 22 Oct 2023 19:50:43 +0200 Subject: [PATCH] Renamed "bump" to "target", changed CHANGELOG --- firmware/CHANGELOG.md | 3 +++ firmware/controllers/actuators/idle_thread.cpp | 4 ++-- firmware/controllers/algo/engine_configuration.cpp | 2 +- firmware/integration/rusefi_config.txt | 2 +- firmware/tunerstudio/rusefi.input | 4 ++-- 5 files changed, 9 insertions(+), 6 deletions(-) diff --git a/firmware/CHANGELOG.md b/firmware/CHANGELOG.md index ee70198c6d..c008d0614a 100644 --- a/firmware/CHANGELOG.md +++ b/firmware/CHANGELOG.md @@ -28,6 +28,9 @@ Release template (copy/paste this for new release): ## Unreleased +### Breaking Changes + - "acIdleRpmBump" renamed to "acIdleRpmTarget", and changed the way of RPM rise needed for proper A/C operation from added to absolute target #5628 + ### Added - DAC with Lua #5601 - TunerStudio cacerts fix script #5536 diff --git a/firmware/controllers/actuators/idle_thread.cpp b/firmware/controllers/actuators/idle_thread.cpp index a81412e465..296d242584 100644 --- a/firmware/controllers/actuators/idle_thread.cpp +++ b/firmware/controllers/actuators/idle_thread.cpp @@ -30,9 +30,9 @@ int IdleController::getTargetRpm(float clt) { // Why do we bump based on button not based on actual A/C relay state? // Because AC output has a delay to allow idle bump to happen first, so that the airflow increase gets a head start on the load increase // alternator duty cycle has a similar logic - targetRpmAcBump = engine->module().unmock().acButtonState ? engineConfiguration->acIdleRpmBump : 0; + targetRpmAcTarget = engine->module().unmock().acButtonState ? engineConfiguration->acIdleRpmTarget : 0; - auto target = (targetRpmByClt < targetRpmAcBump) ? targetRpmAcBump : targetRpmByClt; + auto target = (targetRpmByClt < targetRpmAcTarget) ? targetRpmAcTarget : targetRpmByClt; idleTarget = target; return target; } diff --git a/firmware/controllers/algo/engine_configuration.cpp b/firmware/controllers/algo/engine_configuration.cpp index 7bf651eba5..61a603c1b8 100644 --- a/firmware/controllers/algo/engine_configuration.cpp +++ b/firmware/controllers/algo/engine_configuration.cpp @@ -593,7 +593,7 @@ static void setDefaultEngineConfiguration() { engineConfiguration->isMapAveragingEnabled = true; engineConfiguration->isWaveAnalyzerEnabled = true; - engineConfiguration->acIdleRpmBump = 50; + engineConfiguration->acIdleRpmTarget = 900; engineConfiguration->acDelay = 0.5; engineConfiguration->acIdleExtraOffset = 15; diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt index 2e6751185c..1884b6eb0a 100644 --- a/firmware/integration/rusefi_config.txt +++ b/firmware/integration/rusefi_config.txt @@ -1060,7 +1060,7 @@ bit tempBooleanForVerySpecialLogic float turboSpeedSensorMultiplier;;"mult", 1, 0, 0, 7000, 3 Gpio[CAM_INPUTS_COUNT iterate] camInputsDebug; - int16_t acIdleRpmBump;Idle target speed when A/C is enabled. Some cars need the extra speed to keep the AC efficient while idling.;"RPM", 1, 0, 0, 2000, 0 + int16_t acIdleRpmTarget;Idle target speed when A/C is enabled. Some cars need the extra speed to keep the AC efficient while idling.;"RPM", 1, 0, 0, 2000, 0 int16_t warningPeriod;set warningPeriod X;"seconds", 1, 0, 0, 60, 0 diff --git a/firmware/tunerstudio/rusefi.input b/firmware/tunerstudio/rusefi.input index 327d5acaad..8caf4a3f5d 100644 --- a/firmware/tunerstudio/rusefi.input +++ b/firmware/tunerstudio/rusefi.input @@ -3421,7 +3421,7 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@@@ts_command_e_TS_ dialog = idleOpenLoop, "Open Loop Idle" slider = "Open loop base position", manIdlePosition, horizontal field = "A/C adder", acIdleExtraOffset - field = "A/C target adder", acIdleRpmBump + field = "A/C RPM target", acIdleRpmTarget field = "Fan #1 adder", fan1ExtraIdle field = "Fan #2 adder", fan2ExtraIdle field = "Dashpot/Taper Initial IAC Adder", iacByTpsTaper @@ -3504,7 +3504,7 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@@@ts_command_e_TS_ field = "Max CLT", maxAcClt field = "Max TPS", maxAcTps field = "A/C Idle adder", acIdleExtraOffset - field = "A/C Idle RPM", acIdleRpmBump + field = "A/C Idle RPM", acIdleRpmTarget dialog = acSettings, "", border panel = acSettingsWest, West