From c552c4800b9cb0ae67e898f3a1761d957b6e895f Mon Sep 17 00:00:00 2001 From: rusefi Date: Sat, 8 Jul 2017 15:46:34 -0400 Subject: [PATCH] docs --- firmware/controllers/core/fsio_impl.cpp | 2 ++ firmware/controllers/trigger/rpm_calculator.cpp | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/firmware/controllers/core/fsio_impl.cpp b/firmware/controllers/core/fsio_impl.cpp index c0cf1b3d9c..47bbb79f80 100644 --- a/firmware/controllers/core/fsio_impl.cpp +++ b/firmware/controllers/core/fsio_impl.cpp @@ -379,6 +379,8 @@ void runFsio(void) { /** * o2 heater is off during cranking + * todo: convert to FSIO? + * open question if heater should be ON during cranking */ enginePins.o2heater.setValue(engine->rpmCalculator.isRunning()); diff --git a/firmware/controllers/trigger/rpm_calculator.cpp b/firmware/controllers/trigger/rpm_calculator.cpp index 46725638c5..66d49be3ef 100644 --- a/firmware/controllers/trigger/rpm_calculator.cpp +++ b/firmware/controllers/trigger/rpm_calculator.cpp @@ -128,6 +128,10 @@ void RpmCalculator::setRpmValue(int value DECLARE_ENGINE_PARAMETER_SUFFIX) { } else if (rpmValue >= CONFIG(cranking.rpm)) { state = RUNNING; } else if (state == STOPPED) { + /** + * We are here if RPM is above zero but we have not seen running RPM yet. + * This gives us cranking hysteresis - a drop of RPM during running is still running, not cranking. + */ state = CRANKING; } }