diff --git a/firmware/controllers/actuators/electronic_throttle.cpp b/firmware/controllers/actuators/electronic_throttle.cpp index 1963acdd18..8e5debca8c 100644 --- a/firmware/controllers/actuators/electronic_throttle.cpp +++ b/firmware/controllers/actuators/electronic_throttle.cpp @@ -878,42 +878,6 @@ static void etbReset() { } #endif /* EFI_PROD_CODE */ -/** - * set etb_p X - */ -void setEtbPFactor(float value) { - engineConfiguration->etb.pFactor = value; - etbPidReset(); - showEtbInfo(); -} - -/** - * set etb_i X - */ -void setEtbIFactor(float value) { - engineConfiguration->etb.iFactor = value; - etbPidReset(); - showEtbInfo(); -} - -/** - * set etb_d X - */ -void setEtbDFactor(float value) { - engineConfiguration->etb.dFactor = value; - etbPidReset(); - showEtbInfo(); -} - -/** - * set etb_o X - */ -void setEtbOffset(int value) { - engineConfiguration->etb.offset = value; - etbPidReset(); - showEtbInfo(); -} - void etbAutocal(size_t throttleIndex) { if (throttleIndex >= ETB_COUNT) { return; diff --git a/firmware/controllers/actuators/electronic_throttle.h b/firmware/controllers/actuators/electronic_throttle.h index 5c5708e707..bd28cc75c9 100644 --- a/firmware/controllers/actuators/electronic_throttle.h +++ b/firmware/controllers/actuators/electronic_throttle.h @@ -28,10 +28,6 @@ void setBoschVAGETB(); void setDefaultEtbBiasCurve(); void setDefaultEtbParameters(); void setBoschVNH2SP30Curve(); -void setEtbPFactor(float value); -void setEtbIFactor(float value); -void setEtbDFactor(float value); -void setEtbOffset(int value); void setThrottleDutyCycle(percent_t level); void onConfigurationChangeElectronicThrottleCallback(engine_configuration_s *previousConfiguration); void unregisterEtbPins(); diff --git a/firmware/controllers/actuators/idle_thread.h b/firmware/controllers/actuators/idle_thread.h index 026b457f82..67acfcdfae 100644 --- a/firmware/controllers/actuators/idle_thread.h +++ b/firmware/controllers/actuators/idle_thread.h @@ -113,9 +113,6 @@ void setManualIdleValvePosition(int positionPercent); void startIdleThread(); void setDefaultIdleParameters(); void startIdleBench(void); -void setIdlePFactor(float value); -void setIdleIFactor(float value); -void setIdleDFactor(float value); void setIdleMode(idle_mode_e value); void setTargetIdleRpm(int value); void startPedalPins(); diff --git a/firmware/controllers/actuators/idle_thread_io.cpp b/firmware/controllers/actuators/idle_thread_io.cpp index 789783ca4a..84953d0f5e 100644 --- a/firmware/controllers/actuators/idle_thread_io.cpp +++ b/firmware/controllers/actuators/idle_thread_io.cpp @@ -94,24 +94,6 @@ void setTargetIdleRpm(int value) { efiPrintf("target idle RPM %d", value); } -void setIdlePFactor(float value) { - engineConfiguration->idleRpmPid.pFactor = value; - applyPidSettings(); - showIdleInfo(); -} - -void setIdleIFactor(float value) { - engineConfiguration->idleRpmPid.iFactor = value; - applyPidSettings(); - showIdleInfo(); -} - -void setIdleDFactor(float value) { - engineConfiguration->idleRpmPid.dFactor = value; - applyPidSettings(); - showIdleInfo(); -} - /** * Idle test would activate the solenoid for three seconds */ diff --git a/firmware/controllers/settings.cpp b/firmware/controllers/settings.cpp index a80cfbf400..eb46fe1d63 100644 --- a/firmware/controllers/settings.cpp +++ b/firmware/controllers/settings.cpp @@ -745,27 +745,6 @@ const command_f_s commandsF[] = { #endif // EFI_ENGINE_CONTROL {"script_curve_1_value", setScriptCurve1Value}, {"script_curve_2_value", setScriptCurve2Value}, -#if EFI_PROD_CODE -#if EFI_IDLE_CONTROL - {"idle_p", setIdlePFactor}, - {"idle_i", setIdleIFactor}, - {"idle_d", setIdleDFactor}, -#endif // EFI_IDLE_CONTROL -#endif // EFI_PROD_CODE - -#if EFI_ELECTRONIC_THROTTLE_BODY - {"etb_p", setEtbPFactor}, - {"etb_i", setEtbIFactor}, - {"etb_d", setEtbDFactor}, - {"etb", setThrottleDutyCycle}, -#endif // EFI_ELECTRONIC_THROTTLE_BODY - - // {"", }, -// {"", }, -// {"", }, - // {"", }, - // {"", }, - // {"", }, }; static void setTpsErrorDetectionTooLow(int v) { @@ -817,13 +796,6 @@ const command_i_s commandsI[] = {{"ignition_mode", setIgnitionMode}, #endif // EFI_IDLE_CONTROL #endif // EFI_PROD_CODE -#if EFI_ELECTRONIC_THROTTLE_BODY - {"etb_o", setEtbOffset}, -#endif // EFI_ELECTRONIC_THROTTLE_BODY - - // {"", }, - // {"", }, - // {"", }, // {"", }, // {"", }, };