only: refactoring: moving stuff to confirm loose coupling

This commit is contained in:
rusefillc 2023-11-25 11:29:24 -05:00
parent 36e714bab7
commit c9c8417aed
6 changed files with 10 additions and 5 deletions

View File

@ -11,11 +11,11 @@ public class FileSystemBoardInputsImpl extends FileSystemBoardInputsReaderImpl {
@Override
public Writer getBoardNamesWriter() throws IOException {
return new FileWriter(boardName + PinoutLogic.CONNECTORS + File.separator + "generated_ts_name_by_pin.cpp");
return new FileWriter(boardName + PinoutLogicConstants.CONNECTORS + File.separator + "generated_ts_name_by_pin.cpp");
}
@Override
public Writer getOutputsWriter() throws IOException {
return new FileWriter(boardName + PinoutLogic.CONNECTORS + File.separator + "generated_outputs.h");
return new FileWriter(boardName + PinoutLogicConstants.CONNECTORS + File.separator + "generated_outputs.h");
}
}

View File

@ -13,14 +13,14 @@ import java.util.List;
import static com.devexperts.logging.Logging.getLogging;
public abstract class FileSystemBoardInputsReaderImpl implements BoardInputs {
private static final Logging log = getLogging(FileSystemBoardInputsImpl.class);
private static final Logging log = getLogging(FileSystemBoardInputsReaderImpl.class);
protected final String boardName;
private final List<File> boardYamlFiles;
public static String PREFIX = "";
public FileSystemBoardInputsReaderImpl(String boardName) {
this.boardName = boardName;
String dirPath = boardName + PinoutLogic.CONNECTORS;
String dirPath = boardName + PinoutLogicConstants.CONNECTORS;
File dirName = new File(dirPath);
FilenameFilter filter = (f, name) -> name.endsWith(".yaml");
File[] boardYamlFilesArray = dirName.listFiles(filter);
@ -53,7 +53,7 @@ public abstract class FileSystemBoardInputsReaderImpl implements BoardInputs {
public List<String> getInputFiles() {
List<String> result = new ArrayList<>();
for (File yamlFile : boardYamlFiles) {
result.add(boardName + PinoutLogic.CONNECTORS + File.separator + yamlFile.getName());
result.add(boardName + PinoutLogicConstants.CONNECTORS + File.separator + yamlFile.getName());
}
return result;
}

View File

@ -0,0 +1,5 @@
package com.rusefi.pinout;
public class PinoutLogicConstants {
static final String CONNECTORS = "/connectors";
}