refactoring

firmware/controllers/algo/nmea.c

@@ -20,7 +20,6 @@
  * see #testGpsParser
  */
 #include "global.h"
-#include <math.h>
 #include <time.h>
 #include "nmea.h"
 

firmware/controllers/core/common_headers.h

@@ -0,0 +1,28 @@
+/*
+ * @file common_headers.h
+ *
+ * @date Sep 16, 2018
+ * @author Andrey Belomutskiy, (c) 2012-2018
+ */
+
+#ifndef CONTROLLERS_CORE_COMMON_HEADERS_H_
+#define CONTROLLERS_CORE_COMMON_HEADERS_H_
+
+#include "efifeatures.h"
+
+#include <math.h>
+#include <string.h>
+#include <stdio.h>
+
+#include "error_handling.h"
+#include "auto_generated_enums.h"
+#include "rusefi_enums.h"
+#include "efilib.h"
+#include "efitime.h"
+
+#ifdef __cplusplus
+#include "datalogging.h"
+#include "loggingcentral.h"
+#endif /* __cplusplus */
+
+#endif /* CONTROLLERS_CORE_COMMON_HEADERS_H_ */

firmware/controllers/core/interpolation.cpp

@@ -11,11 +11,6 @@
  */
 
 #include "global.h"
-#if DEBUG_FUEL
-#include <stdio.h>
-#endif
-
-#include <math.h>
 
 #include "efilib2.h"
 #include "interpolation.h"

firmware/controllers/error_handling.cpp

@@ -5,11 +5,9 @@
  * @author Andrey Belomutskiy, (c) 2012-2018
  */
 
-#include "global.h"
-#include "error_handling.h"
+#include "engine.h"
 #include "io_pins.h"
 #include "efilib2.h"
-#include "engine.h"
 
 #if EFI_SIMULATOR || EFI_PROD_CODE
 //todo: move into simulator global

firmware/controllers/error_handling.h

@@ -15,7 +15,6 @@ extern "C"
 
 #include "global.h"
 #include "obd_error_codes.h"
-#include "efifeatures.h"
 #include "stdbool.h"
 #include "rusefi_types.h"
 

firmware/controllers/lcd_controller.cpp

@@ -19,7 +19,6 @@
 #include "global.h"
 #include "lcd_controller.h"
 #include "lcd_HD44780.h"
-#include "efilib.h"
 #include "rpm_calculator.h"
 #include "allsensors.h"
 #include "engine.h"

firmware/controllers/sensors/map.cpp

@@ -10,7 +10,6 @@
 #include "engine_math.h"
 #include "analog_input.h"
 #include "interpolation.h"
-#include "error_handling.h"
 #include "map.h"
 #include "engine_controller.h"
 

firmware/controllers/trigger/trigger_central.cpp

@@ -431,7 +431,6 @@ static void triggerShapeInfo(void) {
 }
 
 #if EFI_UNIT_TEST || defined(__DOXYGEN__)
-#include <stdio.h>
 #include <stdlib.h>
 
 #define TRIGGERS_FILE_NAME "triggers.txt"

firmware/controllers/trigger/trigger_structure.cpp

@@ -20,7 +20,6 @@
 
 #include "global.h"
 #include "trigger_structure.h"
-#include "error_handling.h"
 #include "trigger_decoder.h"
 #include "engine_math.h"
 #include "trigger_universal.h"

firmware/global.h

@@ -18,9 +18,7 @@ extern "C"
 #include <ch.h>
 #include <hal.h>
     
-#include <math.h>
 #include <float.h>
-#include <string.h>
 
 #ifndef DEFAULT_ENGINE_TYPE
 #define DEFAULT_ENGINE_TYPE CUSTOM_ENGINE
@@ -38,16 +36,17 @@ typedef unsigned int time_t;
 #define ALWAYS_INLINE INLINE
 #endif
 
-#include "efifeatures.h"
-#include "rusefi_types.h"
-#include "rusefi_enums.h"
-#include "io_pins.h"
-#include "auto_generated_enums.h"
-#include "obd_error_codes.h"
-#include "error_handling.h"
+#include "common_headers.h"
 
-#include "efitime.h"
-#include "efilib.h"
+#include "io_pins.h"
+
+#ifdef __cplusplus
+#include "cli_registry.h"
+
+#include "eficonsole.h"
+#endif /* __cplusplus */
+
+#include "chprintf.h"
 
 /* definition to expand macro then apply to pragma message */
 #define VALUE_TO_STRING(x) #x
@@ -143,18 +142,6 @@ typedef unsigned int time_t;
  */
 int getRemainingStack(thread_t *otp);
 
-
-
-
-#ifdef __cplusplus
-#include "cli_registry.h"
-#include "datalogging.h"
-#include "loggingcentral.h"
-#include "eficonsole.h"
-#endif /* __cplusplus */
-
-#include "chprintf.h"
-
 #ifdef __cplusplus
 }
 #endif /* __cplusplus */

firmware/main.h

@@ -1,8 +0,0 @@
-/**
- * @file	main.h
- *
- * @date Nov 29, 2012
- * @author Andrey Belomutskiy, (c) 2012-2017
- */
-
-#include "global.h"

simulator/main.h

@@ -1,3 +0,0 @@
-
-#include "global.h"
-

simulator/simulator/global.h

@@ -15,29 +15,18 @@
 #include <ch.h>
 #include <hal.h>
 
-#include <stdio.h>
-#include <string.h>
 #include <stdlib.h>
 #include <time.h>
-#include <math.h>
 #include <float.h>
 
-#include "efifeatures.h"
+#include "common_headers.h"
 
-#include "auto_generated_enums.h"
 #include "boards.h"
-#include "efilib.h"
-#include "efitime.h"
-#include "error_handling.h"
-#include "rusefi_enums.h"
-#include "obd_error_codes.h"
 
 #ifdef __cplusplus
 #include "chprintf.h"
 #include "cli_registry.h"
-#include "datalogging.h"
 #include "eficonsole.h"
-#include "loggingcentral.h"
 #endif /* __cplusplus */
 
 #define EFI_UNIT_TEST FALSE
@@ -62,8 +51,6 @@
 
 #define CCM_OPTIONAL
 
-#include "rusefi_enums.h"
-
 #define EFI_CUSTOM_PANIC_METHOD 1
 
 // project-wide default thread stack size

unit_tests/global.h

@@ -13,27 +13,15 @@
 #define DEFAULT_ENGINE_TYPE CUSTOM_ENGINE
 
 #include <stdbool.h>
-#include <string.h>
+#include <stdio.h>
 #include <time.h>
 
-#include "efitime.h"
-#include "auto_generated_enums.h"
-
-#include <stdio.h>
-#include <math.h>
-#include "efitime.h"
-
-#include "error_handling.h"
-#include "efifeatures.h"
-
-#include "efilib.h"
-#include "efitime.h"
+#include "common_headers.h"
 
 #include "boards.h"
 
 #ifdef __cplusplus
-#include "datalogging.h"
-#include "loggingcentral.h"
+
 
 extern "C"
 {

unit_tests/main.cpp

@@ -5,13 +5,10 @@
  * @author Andrey Belomutskiy (c) 2012-2018
  */
 
-#include <stdio.h>
-#include <stdlib.h>
-#include <math.h>
 
+#include <stdlib.h>
 
 #include "global.h"
-#include "error_handling.h"
 #include "test_accel_enrichment.h"
 #include "test_interpolation_3d.h"
 #include "test_find_index.h"

unit_tests/main.h

@@ -1,11 +0,0 @@
-/**
- * @file	main.h
- * @brief	Test version of main.h
- *
- * @date Oct 17, 2013
- * @author Andrey Belomutskiy, (c) 2012-2017
- */
-
-#include "global.h"
-
-

unit_tests/map_resize.cpp

@@ -5,11 +5,9 @@
  * @author Andrey Belomutskiy, (c) 2012-2018
  */
 
-#include <stdio.h>
+#include "engine_configuration.h"
 #include "fuel_math.h"
 #include "interpolation.h"
-#include "engine_configuration.h"
-#include "global.h"
 
 #if 1
 

unit_tests/test_idle_controller.cpp

@@ -5,13 +5,9 @@
  * @author Andrey Belomutskiy, (c) 2012-2018
  */
 
-#include <stdio.h>
-
-#include "efitime.h"
 #include "engine_test_helper.h"
 #include "pid.h"
 
-
 void testPidController(void) {
 	print("******************************************* testPidController\r\n");
 	pid_s pidS;