From d2f899e7375bdddad9b13a3f458eeabaa18a2ecd Mon Sep 17 00:00:00 2001 From: Andrey Date: Tue, 29 Aug 2023 16:46:04 -0400 Subject: [PATCH] reducing/moving technical debt --- firmware/controllers/algo/defaults/default_base_engine.cpp | 2 +- unit_tests/tests/trigger/test_trigger_decoder.cpp | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/firmware/controllers/algo/defaults/default_base_engine.cpp b/firmware/controllers/algo/defaults/default_base_engine.cpp index 2436a50ee1..f66b0d6ac0 100644 --- a/firmware/controllers/algo/defaults/default_base_engine.cpp +++ b/firmware/controllers/algo/defaults/default_base_engine.cpp @@ -39,9 +39,9 @@ void setLeftRightBanksNeedBetterName() { } static void setDefaultHPFP() { + engineConfiguration->hpfpCamLobes = 3; // todo: would be nice for unit tests to be happy about these defaults #if EFI_PROD_CODE - engineConfiguration->hpfpCamLobes = 3; engineConfiguration->hpfpPumpVolume = 0.290; engineConfiguration->hpfpMinAngle = 10; engineConfiguration->hpfpActivationAngle = 30; diff --git a/unit_tests/tests/trigger/test_trigger_decoder.cpp b/unit_tests/tests/trigger/test_trigger_decoder.cpp index 3ba0ef71a1..a0dfb89d15 100644 --- a/unit_tests/tests/trigger/test_trigger_decoder.cpp +++ b/unit_tests/tests/trigger/test_trigger_decoder.cpp @@ -867,6 +867,7 @@ TEST(big, testBatch) { TEST(big, testSinglePoint) { EngineTestHelper eth(engine_type_e::TEST_ENGINE); + engineConfiguration->hpfpCamLobes = 0; setTable(config->injectionPhase, -180.0f); EXPECT_CALL(*eth.mockAirmass, getAirmass(_, _)) .WillRepeatedly(Return(AirmassResult{0.1008f, 50.0f})); @@ -895,6 +896,7 @@ TEST(big, testSinglePoint) { TEST(big, testFuelSchedulerBug299smallAndLarge) { EngineTestHelper eth(engine_type_e::TEST_ENGINE); + engineConfiguration->hpfpCamLobes = 0; setTable(config->injectionPhase, -180.0f); engineConfiguration->isFasterEngineSpinUpEnabled = false; engine->tdcMarkEnabled = false;