andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

mc33810: commencts, typos, data types

This commit is contained in:
Andrey Gusakov 2024-05-26 11:50:21 +03:00 committed by rusefillc
parent 49183a53de
commit d75cd67b4a
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
firmware/hw_layer/drivers/gpio/mc33810.cpp
View File

@ -15,7 +15,7 @@
* Masks bits/inputs numbers: * Masks bits/inputs numbers:
* 0..3 - OUT1 .. 3 - Low-Side Injector drivers, 4.5A max * 0..3 - OUT1 .. 3 - Low-Side Injector drivers, 4.5A max
* driven through DIN0 .. 3 or SPI (not supported) * driven through DIN0 .. 3 or SPI (not supported)
* 4..7 - GD0 .. 3 - Gate Driver outputs - IGBT of MOSFET pre-drivers, * 4..7 - GD0 .. 3 - Gate Driver outputs - IGBT or MOSFET pre-drivers,
* driven throug GIN0 .. 3 or SPI in GPGD mode (not supported) * driven throug GIN0 .. 3 or SPI in GPGD mode (not supported)
*/ */
@ -399,7 +399,8 @@ int Mc33810::chip_init()
recentTx = MC_CMD_INVALID; recentTx = MC_CMD_INVALID;
/* check SPI communication */ /* check SPI communication */
/* 0. set echo mode, chip number - don't care */ /* 0. set echo mode, chip number - don't care,
* NOTE: chip replyes on NEXT spi transaction */
ret = spi_rw(MC_CMD_SPI_CHECK, &rxSpiCheck); ret = spi_rw(MC_CMD_SPI_CHECK, &rxSpiCheck);
/* 1. check loopback */ /* 1. check loopback */
ret |= spi_rw(MC_CMD_READ_REG(REG_REV), &rx); ret |= spi_rw(MC_CMD_READ_REG(REG_REV), &rx);
@ -421,7 +422,7 @@ int Mc33810::chip_init()
} else { } else {
msg = "unexpected"; msg = "unexpected";
} }
efiPrintf(DRIVER_NAME " spi loopback test failed [%d][%d][%s] vBatt=%f", rxSpiCheck, rx, msg, vBatt); efiPrintf(DRIVER_NAME " spi loopback test failed [first 0x%04x][spi check 0x%04x][%s] vBatt=%f", rxSpiCheck, rx, msg, vBatt);
} }
ret = -2; ret = -2;
goto err_exit; goto err_exit;
@ -613,7 +614,7 @@ int Mc33810::writePad(size_t pin, int value)
brain_pin_diag_e Mc33810::getDiag(size_t pin) brain_pin_diag_e Mc33810::getDiag(size_t pin)
{ {
int val; uint16_t val;
int diag = PIN_OK; int diag = PIN_OK;
if (pin >= MC33810_DIRECT_OUTPUTS) if (pin >= MC33810_DIRECT_OUTPUTS)