From d90db2354f1be2ba2deb35075ee9fbd0bd57ecf1 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Fri, 16 Feb 2024 19:10:52 -0500 Subject: [PATCH] only:a note of fresh technical debt --- firmware/bin/upload_bundle.sh | 1 + misc/jenkins/build_working_folder.sh | 1 + 2 files changed, 2 insertions(+) diff --git a/firmware/bin/upload_bundle.sh b/firmware/bin/upload_bundle.sh index 4dfb215345..1d689d2c9f 100755 --- a/firmware/bin/upload_bundle.sh +++ b/firmware/bin/upload_bundle.sh @@ -1,6 +1,7 @@ #!/usr/bin/env bash SCRIPT_NAME=$(basename "$0") +# technical debt: more than one file uses magic 'rusefi_bundle_' constant, can we extract constant? FULL_BUNDLE_FILE="rusefi_bundle_${BUNDLE_NAME}.zip" UPDATE_BUNDLE_FILE="rusefi_bundle_${BUNDLE_NAME}_autoupdate.zip" diff --git a/misc/jenkins/build_working_folder.sh b/misc/jenkins/build_working_folder.sh index 2aefc5b70f..604ab81383 100755 --- a/misc/jenkins/build_working_folder.sh +++ b/misc/jenkins/build_working_folder.sh @@ -22,6 +22,7 @@ else fi INI_FILE_OVERRIDE="firmware/tunerstudio/generated/rusefi_$SHORT_BOARD_NAME.ini" +# technical debt: more than one file uses magic 'rusefi_bundle_' constant, can we extract constant? BUNDLE_FULL_NAME="rusefi_bundle_${BUNDLE_NAME}" echo "$SCRIPT_NAME: Will use $INI_FILE_OVERRIDE"