andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

usability of 3 lobe vs 4 lobe profile curve fix #7583 

only:uaefi
This commit is contained in:
rusefillc 2025-03-09 12:59:53 -04:00
parent 5efe2bbf4a
commit da3ef84b5f
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
firmware/controllers/engine_controller.cpp
View File

@ -520,11 +520,29 @@ PUBLIC_API_WEAK bool validateBoardConfig() {
return true; return true;
} }
static bool validateGdi() {
auto lobes = engineConfiguration->hpfpCamLobes;
if (!lobes) {
return true;
}
int expectedLastLobeProfileAngle = 360 / lobes;
float actualLastAngle = config->hpfpLobeProfileAngle[HpfpLobeProfile_SIZE - 1];
if (expectedLastLobeProfileAngle != actualLastAngle) {
criticalError("Last HPFP angle expected %d got %f", expectedLastLobeProfileAngle, actualLastAngle);
return false;
}
return true;
}
// Returns false if there's an obvious problem with the loaded configuration // Returns false if there's an obvious problem with the loaded configuration
bool validateConfigOnStartUpOrBurn() { bool validateConfigOnStartUpOrBurn() {
if (!validateBoardConfig()) { if (!validateBoardConfig()) {
return false; return false;
} }
if (!validateGdi()) {
return false;
}
if (config->dynoCarCarMassKg == 0) { if (config->dynoCarCarMassKg == 0) {
setDynoDefaults(); setDynoDefaults();
} }

2
unit_tests/tests/test_hpfp.cpp
View File

@ -13,6 +13,8 @@ TEST(HPFP, Lobe) {
engineConfiguration->hpfpPeakPos = 123; engineConfiguration->hpfpPeakPos = 123;
engineConfiguration->hpfpCamLobes = 3; engineConfiguration->hpfpCamLobes = 3;
validateConfigOnStartUpOrBurn();
engine->triggerCentral.vvtPosition[0][0] = 40; // Bank 0 engine->triggerCentral.vvtPosition[0][0] = 40; // Bank 0
engine->triggerCentral.vvtPosition[0][1] = 80; engine->triggerCentral.vvtPosition[0][1] = 80;
engine->triggerCentral.vvtPosition[1][0] =120; // Bank 1 engine->triggerCentral.vvtPosition[1][0] =120; // Bank 1