andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove alternator on/off mode fix #4548

This commit is contained in:
Andrey 2022-09-07 22:46:42 -04:00
parent 27c40e162b
commit dab9e04b25
5 changed files with 10 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
firmware/CHANGELOG.md
View File

@ -42,6 +42,7 @@ Release template (copy/paste this for new release):
- Injection Offset for skipped wheel triggers #4536 - Injection Offset for skipped wheel triggers #4536
### Removed ### Removed
- Alternator on/off mode #4548
## August 2022 Release - "Day 170" ## August 2022 Release - "Day 170"

2
firmware/console/binary/output_channels.txt
View File

@ -22,7 +22,7 @@ bit needBurn;
bit sd_msd bit sd_msd
bit isFan2On bit isFan2On
bit alternatorOnOff; bit unusedBitLAtwfs;
bit toothLogReady; bit toothLogReady;
bit unused3123 bit unused3123
bit isTpsError; bit isTpsError;

18
firmware/controllers/actuators/alternator_controller.cpp
View File

@ -64,24 +64,6 @@ void AlternatorController::onFastCallback() {
auto vBatt = Sensor::get(SensorType::BatteryVoltage); auto vBatt = Sensor::get(SensorType::BatteryVoltage);
float targetVoltage = engineConfiguration->targetVBatt; float targetVoltage = engineConfiguration->targetVBatt;
// todo: I am not aware of a SINGLE person to use this onOffAlternatorLogic
if (engineConfiguration->onOffAlternatorLogic) {
if (!vBatt) {
// Somehow battery voltage isn't valid, disable alternator control
enginePins.alternatorPin.setValue(false);
}
float h = 0.1;
bool newState = (vBatt.Value < targetVoltage - h) || (currentPlainOnOffState && vBatt.Value < targetVoltage);
enginePins.alternatorPin.setValue(newState);
currentPlainOnOffState = newState;
#if EFI_TUNER_STUDIO
engine->outputChannels.alternatorOnOff = newState;
#endif /* EFI_TUNER_STUDIO */
return;
}
if (!vBatt) { if (!vBatt) {
// Somehow battery voltage isn't valid, disable alternator control // Somehow battery voltage isn't valid, disable alternator control
alternatorPid.reset(); alternatorPid.reset();

2
firmware/integration/rusefi_config.txt
View File

@ -759,7 +759,7 @@ bit is_enabled_spi_2
bit useLcdScreen bit useLcdScreen
bit verboseTLE8888 bit verboseTLE8888
bit enableVerboseCanTx;+CAN broadcast using custom rusEFI protocol\nenable can_broadcast/disable can_broadcast bit enableVerboseCanTx;+CAN broadcast using custom rusEFI protocol\nenable can_broadcast/disable can_broadcast
bit onOffAlternatorLogic;+This will cause the alternator to be operated in a basic on or off mode, this is the simplest alternator control. bit unusedAlteOnOff
bit isCJ125Enabled;enable cj125/disable cj125 bit isCJ125Enabled;enable cj125/disable cj125
bit vvtCamSensorUseRise,"Rising","Falling";+Use rise or fall signal front\nget vvtCamSensorUseRise bit vvtCamSensorUseRise,"Rising","Falling";+Use rise or fall signal front\nget vvtCamSensorUseRise
bit measureMapOnlyInOneCylinder;+Useful for individual intakes bit measureMapOnlyInOneCylinder;+Useful for individual intakes

15
firmware/tunerstudio/rusefi.input
View File

@ -3163,20 +3163,19 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@@@ts_command_e_TS_
field = "Battery Input Divider Coefficient", vbattDividerCoeff field = "Battery Input Divider Coefficient", vbattDividerCoeff
dialog = alternator, "Alternator Settings", yAxis dialog = alternator, "Alternator Settings", yAxis
field = "Enabled", isAlternatorControlEnabled field = "Enabled", isAlternatorControlEnabled
field = "simple on/off mode", onOffAlternatorLogic, {isAlternatorControlEnabled == 1}
field = "Target", targetVBatt, {isAlternatorControlEnabled == 1} field = "Target", targetVBatt, {isAlternatorControlEnabled == 1}
field = "Pin", alternatorControlPin, {isAlternatorControlEnabled == 1} field = "Pin", alternatorControlPin, {isAlternatorControlEnabled == 1}
field = "Pin Mode", alternatorControlPinMode, {isAlternatorControlEnabled == 1} field = "Pin Mode", alternatorControlPinMode, {isAlternatorControlEnabled == 1}
field = "PWM frequency", alternatorPwmFrequency, {isAlternatorControlEnabled == 1 && onOffAlternatorLogic == 0} field = "PWM frequency", alternatorPwmFrequency, {isAlternatorControlEnabled == 1}
field = "Off Above TPS", alternatorOffAboveTps, {isAlternatorControlEnabled == 1} field = "Off Above TPS", alternatorOffAboveTps, {isAlternatorControlEnabled == 1}
field = "Detailed status in console", isVerboseAlternator, {isAlternatorControlEnabled == 1} field = "Detailed status in console", isVerboseAlternator, {isAlternatorControlEnabled == 1}
field = "#PID control" field = "#PID control"
field = "offset", alternatorControl_offset, {isAlternatorControlEnabled == 1 && onOffAlternatorLogic == 0} field = "offset", alternatorControl_offset, {isAlternatorControlEnabled == 1}
field = "P factor", alternatorControl_pFactor, {isAlternatorControlEnabled == 1 && onOffAlternatorLogic == 0} field = "P factor", alternatorControl_pFactor, {isAlternatorControlEnabled == 1}
field = "I factor", alternatorControl_iFactor, {isAlternatorControlEnabled == 1 && onOffAlternatorLogic == 0} field = "I factor", alternatorControl_iFactor, {isAlternatorControlEnabled == 1}
field = "D factor", alternatorControl_dFactor, {isAlternatorControlEnabled == 1 && onOffAlternatorLogic == 0} field = "D factor", alternatorControl_dFactor, {isAlternatorControlEnabled == 1}
field = "Min", alternatorControl_minValue, {isAlternatorControlEnabled == 1 && onOffAlternatorLogic == 0} field = "Min", alternatorControl_minValue, {isAlternatorControlEnabled == 1}
field = "Max", alternatorControl_maxValue, {isAlternatorControlEnabled == 1 && onOffAlternatorLogic == 0} field = "Max", alternatorControl_maxValue, {isAlternatorControlEnabled == 1}
field = "#% duty = Pterm + Iterm + Dterm + offset%" field = "#% duty = Pterm + Iterm + Dterm + offset%"
dialog = startStopDialog, "Start/Stop Button" dialog = startStopDialog, "Start/Stop Button"