From dc3b51c19a6714ba051e5852d95c4c05273b8e5d Mon Sep 17 00:00:00 2001
From: mi-hol <22799428+mi-hol@users.noreply.github.com>
Date: Fri, 20 Jan 2023 18:11:11 +0100
Subject: [PATCH] fix combined pin C3C4 (#4983)

* add "Status is: DRAFT"

* corrections applied

* update  D6

* update function descriptions

* fix E1

* fix quoting

* fix quoting

* remove duplication

* fix combined pin C3C4

* add ToDo: correct  + and -   required!

* fix combined E5E6

* fix color assignment
---
 .../connectors/Benelli_Walbro.yaml            | 22 ++++++++++---------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/firmware/config/boards/Benelli_Walbro/connectors/Benelli_Walbro.yaml b/firmware/config/boards/Benelli_Walbro/connectors/Benelli_Walbro.yaml
index c04db01711..3e5e545896 100644
--- a/firmware/config/boards/Benelli_Walbro/connectors/Benelli_Walbro.yaml
+++ b/firmware/config/boards/Benelli_Walbro/connectors/Benelli_Walbro.yaml
@@ -123,11 +123,17 @@ pins:
   #   type: vr
   #   color: gray
 
-  - pin: C3C4
-    function: 'Crank Sensor - Phonic Wheel (VR) NOTE!! is + and - side assignment required??'
+  - pin: C3
+    function: 'Crank Sensor - Phonic Wheel (VR) NOTE!! ToDo: correct  + and - side assignment required!!'
     class: event_inputs
     type: vr
-    color: white/black
+    color: white or black
+
+  - pin: C4
+    function: 'Crank Sensor - Phonic Wheel (VR) NOTE!! ToDo: correct  + and - side assignment required!!'
+    class: event_inputs
+    type: vr
+    color: white or black
 
   - pin: C5
     function: 'Intake Air Temp (IAT) sensor'
@@ -139,7 +145,7 @@ pins:
     function: Engine Temp Sensor Input
     class: analog_inputs
     type: at
-    color: bi/violet
+    color: white/violet
 
   - pin: C7
     # not used
@@ -173,7 +179,7 @@ pins:
     function: Neutral Gear Sensor
     class: analog_inputs
     type: ??
-    color: bi/violet
+    color: orange/black
 
   - pin: D5
     # not used
@@ -219,10 +225,6 @@ pins:
     # not used
     function: not used
 
-  - pin: E5E6
-    # not used
-    function: not used
-
   - pin: E7
     function: engine check alarm light??
     class: outputs
@@ -277,7 +279,7 @@ pins:
 info:
 # todo:  trigger build after PR
   title: Benelli_Walbro 
-  name: 'Benelli_Walbro  !! NOTE: status is DRAFT !! - there a unknown and potential wrong pin assignments, these are flagged with "??" !!'
+  name: 'Benelli_Walbro  !! NOTE: status is DRAFT !! - there a unknown and potential wrong pin assignments, these are flagged with "??" and "ToDo:"!!'
   board_url: https://rusefi.com/s/Benelli_Walbro
   image:
     file: Benelli_Walbro.jpg