andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

one-based indexing enums is not cool 

Fixes possible out of array bounds introduced in 5af710ff73
This commit is contained in:
Andrey Gusakov 2024-03-02 23:38:46 +03:00 committed by rusefillc
parent 462a1c8c0d
commit de96d8ba06
5 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
firmware/hw_layer/hardware.cpp
View File

@ -75,7 +75,8 @@
#endif #endif
#if HAL_USE_SPI #if HAL_USE_SPI
extern bool isSpiInitialized[SPI_TOTAL_COUNT]; /* zero index is SPI_NONE */
extern bool isSpiInitialized[SPI_TOTAL_COUNT + 1];
/** /**
* Only one consumer can use SPI bus at a given time * Only one consumer can use SPI bus at a given time

3
firmware/hw_layer/ports/at32/at32_spi.cpp
View File

@ -9,7 +9,8 @@
#include "pch.h" #include "pch.h"
#if HAL_USE_SPI #if HAL_USE_SPI
bool isSpiInitialized[SPI_TOTAL_COUNT] = { false, false, false, false, false, false }; /* zero index is SPI_NONE */
bool isSpiInitialized[SPI_TOTAL_COUNT + 1] = { true, false, false, false, false, false, false };
struct af_pairs { struct af_pairs {
brain_pin_e pin; brain_pin_e pin;

3
firmware/hw_layer/ports/cypress/mpu_util.cpp
View File

@ -65,7 +65,8 @@ void HardFaultVector(void) {
} }
#if HAL_USE_SPI || defined(__DOXYGEN__) #if HAL_USE_SPI || defined(__DOXYGEN__)
bool isSpiInitialized[SPI_TOTAL_COUNT] = { false, false, false, false, false, false }; /* zero index is SPI_NONE */
bool isSpiInitialized[SPI_TOTAL_COUNT + 1] = { true, false, false, false, false, false, false };
static int getSpiAf(SPIDriver *driver) { static int getSpiAf(SPIDriver *driver) {
#if STM32_SPI_USE_SPI1 #if STM32_SPI_USE_SPI1

3
firmware/hw_layer/ports/kinetis/mpu_util.cpp
View File

@ -58,7 +58,8 @@ void HardFaultVector(void) {
} }
#if HAL_USE_SPI || defined(__DOXYGEN__) #if HAL_USE_SPI || defined(__DOXYGEN__)
bool isSpiInitialized[SPI_TOTAL_COUNT] = { false, false, false, false, false, false }; /* zero index is SPI_NONE */
bool isSpiInitialized[SPI_TOTAL_COUNT + 1] = { true, false, false, false, false, false, false };
static int getSpiAf(SPIDriver *driver) { static int getSpiAf(SPIDriver *driver) {
#if STM32_SPI_USE_SPI1 #if STM32_SPI_USE_SPI1

3
firmware/hw_layer/ports/stm32/stm32_spi.cpp
View File

@ -9,7 +9,8 @@
#include "pch.h" #include "pch.h"
#if HAL_USE_SPI #if HAL_USE_SPI
bool isSpiInitialized[SPI_TOTAL_COUNT] = { false, false, false, false, false, false }; /* zero index is SPI_NONE */
bool isSpiInitialized[SPI_TOTAL_COUNT + 1] = { true, false, false, false, false, false, false };
static int getSpiAf(SPIDriver *driver) { static int getSpiAf(SPIDriver *driver) {
#if STM32_SPI_USE_SPI1 #if STM32_SPI_USE_SPI1