variable shadowing should be avoided #5676 (#5679)

helping kinetis

firmware/controllers/core/error_handling.cpp

@@ -10,6 +10,7 @@
 
 #include "backup_ram.h"
 #include "error_handling_led.h"
+#include "log_hard_fault.h"
 
 static critical_msg_t warningBuffer;
 static critical_msg_t criticalErrorMessageBuffer;

firmware/controllers/core/error_handling.h

@@ -62,11 +62,9 @@ extern "C"
 #endif /* __cplusplus */
 
 #if EFI_PROD_CODE
-#include <hal.h>
 
 // If there was an error on the last boot, print out information about it now and reset state.
 void checkLastBootError();
-void logHardFault(uint32_t type, uintptr_t faultAddress, port_extctx* ctx, uint32_t csfr);
 #endif // EFI_PROD_CODE
 
 #ifdef __cplusplus

firmware/controllers/core/log_hard_fault.h

@@ -0,0 +1,17 @@
+#pragma once
+
+
+#ifdef __cplusplus
+extern "C"
+{
+#endif /* __cplusplus */
+
+#if EFI_PROD_CODE
+#include <hal.h>
+
+void logHardFault(uint32_t type, uintptr_t faultAddress, port_extctx* ctx, uint32_t csfr);
+#endif // EFI_PROD_CODE
+
+#ifdef __cplusplus
+}
+#endif /* __cplusplus */