From e721acc60cf83d07811352e19e8198dff8603a60 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Thu, 8 Oct 2020 20:06:07 -0400 Subject: [PATCH] SD card logs not valid for REO #1864 --- firmware/console/binary_log/binary_logging.cpp | 6 ++++-- firmware/console/status_loop.cpp | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/firmware/console/binary_log/binary_logging.cpp b/firmware/console/binary_log/binary_logging.cpp index 93392e10f5..ec55e1b674 100644 --- a/firmware/console/binary_log/binary_logging.cpp +++ b/firmware/console/binary_log/binary_logging.cpp @@ -16,10 +16,12 @@ // floating number of seconds with millisecond precision static scaled_channel packedTime; +// todo: we are at the edge of sdLogBuffer size and at the moment we have no code to make sure buffer does not overflow +// todo: make this logic smarter static const LogField fields[] = { {tsOutputChannels.rpm, GAUGE_NAME_RPM, "rpm", 0}, - {packedTime, GAUGE_NAME_TIME, "sec", 0}, - {tsOutputChannels.totalTriggerErrorCounter, GAUGE_NAME_TRG_ERR, "err", 0}, +// {packedTime, GAUGE_NAME_TIME, "sec", 0}, +// {tsOutputChannels.totalTriggerErrorCounter, GAUGE_NAME_TRG_ERR, "err", 0}, {tsOutputChannels.vehicleSpeedKph, GAUGE_NAME_VVS, "kph", 0}, {tsOutputChannels.internalMcuTemperature, GAUGE_NAME_CPU_TEMP, "C", 0}, {tsOutputChannels.coolantTemperature, GAUGE_NAME_CLT, "C", 1}, diff --git a/firmware/console/status_loop.cpp b/firmware/console/status_loop.cpp index b643fd9c62..7353e6ffd0 100644 --- a/firmware/console/status_loop.cpp +++ b/firmware/console/status_loop.cpp @@ -119,7 +119,7 @@ static void setWarningEnabled(int value) { #if EFI_FILE_LOGGING // this one needs to be in main ram so that SD card SPI DMA works fine -static char sdLogBuffer[2048] MAIN_RAM; +static char sdLogBuffer[2300] MAIN_RAM; static uint64_t binaryLogCount = 0; #endif /* EFI_FILE_LOGGING */