From edab0d1e882c9518d70689c3567c741ac8be68ba Mon Sep 17 00:00:00 2001 From: rusefillc Date: Sun, 18 Jun 2023 23:02:51 -0400 Subject: [PATCH] Better defaults based on some real tunes #5344 --- .../boards/hellen/hellen121nissan/board_configuration.cpp | 1 - firmware/config/engines/gm_ls_4.cpp | 2 -- firmware/config/engines/vw_b6.cpp | 1 - firmware/controllers/actuators/electronic_throttle.cpp | 2 +- 4 files changed, 1 insertion(+), 5 deletions(-) diff --git a/firmware/config/boards/hellen/hellen121nissan/board_configuration.cpp b/firmware/config/boards/hellen/hellen121nissan/board_configuration.cpp index 836a9b01cc..d4374ff30f 100644 --- a/firmware/config/boards/hellen/hellen121nissan/board_configuration.cpp +++ b/firmware/config/boards/hellen/hellen121nissan/board_configuration.cpp @@ -126,7 +126,6 @@ void setBoardDefaultConfiguration() { engineConfiguration->fanOnTemperature = 85; engineConfiguration->fanOffTemperature = 81; - engineConfiguration->etbIdleThrottleRange = 10; engineConfiguration->cutFuelOnHardLimit = false; engineConfiguration->idlePidRpmUpperLimit = 300; engineConfiguration->mapErrorDetectionTooLow = 10; diff --git a/firmware/config/engines/gm_ls_4.cpp b/firmware/config/engines/gm_ls_4.cpp index 54173dc542..56e19ad03c 100644 --- a/firmware/config/engines/gm_ls_4.cpp +++ b/firmware/config/engines/gm_ls_4.cpp @@ -24,8 +24,6 @@ void setGmLs4() { engineConfiguration->firingOrder = FO_1_8_7_2_6_5_4_3; engineConfiguration->displacement = 6.2; - engineConfiguration->etbIdleThrottleRange = 15; - engineConfiguration->tChargeAirIncrLimit = 5; engineConfiguration->tChargeAirDecrLimit = 15; diff --git a/firmware/config/engines/vw_b6.cpp b/firmware/config/engines/vw_b6.cpp index b274d92992..edbe44a8e1 100644 --- a/firmware/config/engines/vw_b6.cpp +++ b/firmware/config/engines/vw_b6.cpp @@ -22,7 +22,6 @@ static void commonPassatB6() { engineConfiguration->globalTriggerAngleOffset = 90; - engineConfiguration->etbIdleThrottleRange = 10; engineConfiguration->idlePidRpmDeadZone = 500; engineConfiguration->idleMode = IM_AUTO; diff --git a/firmware/controllers/actuators/electronic_throttle.cpp b/firmware/controllers/actuators/electronic_throttle.cpp index c180316bbf..e9ca36b7d9 100644 --- a/firmware/controllers/actuators/electronic_throttle.cpp +++ b/firmware/controllers/actuators/electronic_throttle.cpp @@ -955,7 +955,7 @@ void setBoschVNH2SP30Curve() { } void setDefaultEtbParameters() { - engineConfiguration->etbIdleThrottleRange = 5; + engineConfiguration->etbIdleThrottleRange = 15; engineConfiguration->etbExpAverageLength = 50; engineConfiguration->etbRocExpAverageLength = 50;