From f329f29bc5942bf976ee9c32ccfd465323ecd8f5 Mon Sep 17 00:00:00 2001 From: rusefillc Date: Fri, 24 Nov 2023 14:41:17 -0500 Subject: [PATCH] much more visible failure in case of failed chip init --- firmware/hw_layer/drivers/gpio/core.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/firmware/hw_layer/drivers/gpio/core.cpp b/firmware/hw_layer/drivers/gpio/core.cpp index 20a8a97394..4faeebec05 100644 --- a/firmware/hw_layer/drivers/gpio/core.cpp +++ b/firmware/hw_layer/drivers/gpio/core.cpp @@ -229,9 +229,7 @@ int gpiochips_init(void) { continue; if (chip->chip->init() < 0) { - /* remove chip if it fails to init */ - /* TODO: we will have a gap, is it ok? */ - chip->base = Gpio::Unassigned; + criticalError("Failed to init chip %d", i); } else { pins_added += chip->size; }