Explicit fw (#3968)

* explicit FW ID

* explicit FW ID

Co-authored-by: rusefillc <sdfsdfqsf2334234234>

firmware/config/boards/subaru_eg33/board.mk

@@ -18,6 +18,7 @@ DDEFS +=  -DLED_CRITICAL_ERROR_BRAIN_PIN=GPIOG_7
 
 # We are running on Subaru EG33 hardware!
 DDEFS += -DHW_SUBARU_EG33=1
+DDEFS += -DFIRMWARE_ID=\"EG33\"
 
 # Override DEFAULT_ENGINE_TYPE
 DDEFS += -DDEFAULT_ENGINE_TYPE=SUBARUEG33_DEFAULTS

firmware/controllers/core/common_headers.h

@@ -31,7 +31,3 @@
 #include "datalogging.h"
 #include "cli_registry.h"
 #endif /* __cplusplus */
-
-#ifndef FIRMWARE_ID
-#define FIRMWARE_ID "source"
-#endif

simulator/Makefile

@@ -241,6 +241,8 @@ CPPWARN = -Wall -Wextra -Wundef
 
 # List all user C define here, like -D_DEBUG=1
 UDEFS = -DSIMULATOR
+DDEFS += -DFIRMWARE_ID=\"simulator\"
+
 
 # Define ASM defines here
 UADEFS =