docs

firmware/controllers/trigger/decoders/sync_edge.h

@@ -3,6 +3,8 @@
 enum class SyncEdge : uint8_t {
 	Rise,		// Sync on rising edges, use rise+fall for phase info
 	Fall,		// Sync on falling edges, use rise+fall for phase info
+	// VR or lazy Hall
 	RiseOnly,	// Completely ignore all falling edges (this used to be useOnlyRisingEdgeForTrigger=true etc)
+	// nicer Hall
 	Both		// Sync on both edges, use both for phase
 };

firmware/controllers/trigger/decoders/trigger_structure.cpp

@@ -229,10 +229,18 @@ void TriggerWaveform::addEvent360(angle_t angle, TriggerWheel const channelIndex
 	addEvent(CRANK_MODE_MULTIPLIER * angle / FOUR_STROKE_CYCLE_DURATION, channelIndex, state);
 }
 
+/**
+ * This version of the method is best when same wheel could be mounted either on crank or cam
+ *
+ * @param angle 0 to 360 or 0 to 720 depending on configuration
+ */
 void TriggerWaveform::addEventAngle(angle_t angle, TriggerWheel const channelIndex, TriggerValue const state) {
 	addEvent(angle / getCycleDuration(), channelIndex, state);
 }
 
+/**
+ * @param angle [0,1)
+ */
 void TriggerWaveform::addEvent(angle_t angle, TriggerWheel const channelIndex, TriggerValue const state) {
 	efiAssertVoid(CUSTOM_OMODE_UNDEF, operationMode != OM_NONE, "operationMode not set");