From fe530058883121166a0ae08c29ca3971dfd9375a Mon Sep 17 00:00:00 2001 From: rusefi Date: Wed, 10 Apr 2024 00:25:05 -0400 Subject: [PATCH] only: better variable name and some docs --- firmware/controllers/engine_cycle/spark_logic.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/firmware/controllers/engine_cycle/spark_logic.cpp b/firmware/controllers/engine_cycle/spark_logic.cpp index f00da725d9..ebb3d8de3e 100644 --- a/firmware/controllers/engine_cycle/spark_logic.cpp +++ b/firmware/controllers/engine_cycle/spark_logic.cpp @@ -383,17 +383,19 @@ static void scheduleSparkEvent(bool limitedSpark, IgnitionEvent *event, efiAssertVoid(ObdCode::CUSTOM_ERR_6591, !cisnan(sparkAngle), "findAngle#4"); assertAngleRange(sparkAngle, "findAngle#a5", ObdCode::CUSTOM_ERR_6549); - bool scheduled = engine->module()->scheduleOrQueue( + bool isTimeScheduled = engine->module()->scheduleOrQueue( "spark", &event->sparkEvent, edgeTimestamp, sparkAngle, { fireSparkAndPrepareNextSchedule, event }, currentPhase, nextPhase); - if (scheduled) { + if (isTimeScheduled) { + // event was scheduled by time, we expect it to happen reliably #if SPARK_EXTREME_LOGGING efiPrintf("scheduling sparkDown %d %s now=%d later id=%d", getRevolutionCounter(), event->getOutputForLoggins()->getName(), (int)getTimeNowUs(), event->sparkCounter); #endif /* FUEL_MATH_EXTREME_LOGGING */ } else { + // event was queued in relation to some expected tooth event in the future which might just never come so we shall protect from over-dwell #if SPARK_EXTREME_LOGGING efiPrintf("to queue sparkDown %d %s now=%d for id=%d angle=%.1f", getRevolutionCounter(), event->getOutputForLoggins()->getName(), (int)getTimeNowUs(), event->sparkCounter, sparkAngle); #endif /* SPARK_EXTREME_LOGGING */