Commit Graph

573 Commits

Author SHA1 Message Date
Matthew Kennedy ee381b2f34 speedo output 2023-10-15 22:07:31 -04:00
rusefillc f7f8135e04 only:bench test fuel pump pin #5603 2023-10-10 21:29:52 -04:00
rusefillc e19204dd2e
Boost (#5586)
* boost is engine module

* only:idle leaves outputs

---------

Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
2023-09-26 13:39:43 -04:00
rusefillc be35a5eb23
fan control is engine module (#5585)
* fan is engine module

* mockable AC

* mockable AC

* mock AC controller in fan test

* constexpr fan livedata

* isPtr

Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
2023-09-26 07:12:11 -04:00
rusefi 2f907af198 Fan not be able to be set because in use at VR PWM fix #5565
only:reducing confusion
2023-09-16 11:03:14 -04:00
Matthew Kennedy bc637c4e6b rename 2jz -> toyota 3 tooth 2023-09-14 17:42:27 -04:00
Matthew Kennedy ee513cf452 boost control runs in fast callback 2023-09-10 23:31:45 -04:00
Andrey a2a5fda3ce spelling is important 2023-09-09 19:51:09 -04:00
Andrey ba66fdcf82 reducing code duplication around assert 2023-09-05 21:28:39 -04:00
Andrey 4fbccca850 4G69 Cam pattern #5541 2023-08-25 01:10:08 -04:00
rusefillc fc5c9542c5
helping cypress (#5537)
* helping cypress

* helping cypress
2023-08-24 00:35:13 -04:00
rusefillc a041eb55f3 broadcast button toggle counter #5514
only:fancy boolen with counter
2023-08-22 14:49:28 -04:00
rusefillc 3c8cd08c61 broadcast button toggle counter #5514
only:fancy boolen with counter
2023-08-22 14:37:17 -04:00
rusefi e8c45a2e7d refactoring: reducing code duplication. Also, do we even care for critical error codes?! 2023-08-20 22:23:44 -04:00
Andrey 5f686c302d "Single Tooth" renamed to "Half Moon", more proper "Single Tooth" crank trigger as a new trigger fix #5488 2023-08-05 23:49:32 -04:00
rusefillc 77ef4db8ab
Simplified VVT single tooth cam modes. (#5483)
* Simplified VVT single tooth cam modes.

* Simplified VVT single tooth cam modes.

* Simplified VVT single tooth cam modes.

* Simplified VVT single tooth cam modes.

* Simplified VVT single tooth cam modes.

---------

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2023-08-03 20:24:22 -04:00
rusefillc c19326e89e Too many bench test buttons are broken #5327 2023-06-15 22:54:00 -04:00
rusefi 7b2985c1c3 Too many bench test buttons are broken #5327 2023-06-15 22:28:15 -04:00
rusefi 1908896598 Technical debt: ENUM_32_BITS #3874
poking the bear
2023-06-01 10:29:05 -04:00
Andrey 4390320b6c setSparkSkipRatio limitation #5231 2023-05-25 12:41:11 -04:00
rusefi 409bf4b2ce Ford Coyote VVT Decoder #5275
helping build?
2023-05-13 13:27:37 -04:00
rusefillc 50bb3aff97 it's going to be painful 2023-04-29 06:17:32 -04:00
Andrey 51d0f6e347 it's going to be painful 2023-04-29 00:44:00 -04:00
Matthew Kennedy 61e5b4b1ad change ObdCode to enum class builds firmware 2023-04-29 00:44:00 -04:00
rusefi 7c33515d0e refactoring 2023-03-16 15:53:01 -04:00
Andrey 34fddd44e0 K
only:hellen-honda-k
2023-03-12 12:01:51 -04:00
Matthew Kennedy 325417caa7
fix 4g63 vs 9x naming, add cam-only test (#5093) 2023-02-16 23:22:34 -05:00
Matthew Kennedy 9630edfbf8
mitsu 4g63 (#5001)
* mitsu 4g63

* file header
2023-01-24 06:53:40 +05:30
rusefillc 92a4895b13 refactoring: inside the boost controller instead of depending on the engine god object 2023-01-22 07:40:42 -05:00
rusefillc f94aa7a7cd https://rusefi.com/forum/viewtopic.php?f=2&t=2484 luaIgnCut 2023-01-02 17:46:56 -05:00
Andrey 748f97afeb kinetis asking for guard, also I've must have messed up something 2022-12-17 18:04:54 -05:00
rusefillc 2b4d58005b guards 2022-12-17 14:43:51 -05:00
TurboMarian 276713d24f LUA FuelAdd update
(cherry picked from commit a54cdbb0771b1a48aa8e24bffbaf554e10d55f3a)
2022-12-16 20:22:48 -05:00
rusefillc 57ad9b7311 random getOrZero clean-up 2022-12-14 19:48:07 -05:00
rusefi ec77afeaa0 reducing ugly 2022-11-06 20:47:57 -05:00
Andrey 77a3f5d795 trigger refactoring: instance RPM #4740 2022-11-06 11:56:18 -05:00
Andrey 83e736b06a trigger refactoring: instance RPM #4740 2022-11-06 11:47:23 -05:00
rusefillc e3fd84ed08 minor trigger refactoring 2022-11-06 00:32:38 -04:00
Matthew Kennedy 940e0dc369
require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
rusefi 529fb35c66 need Proteus QC 2022-10-01 22:00:25 -04:00
Andrey baaec6a603 refactoring: encapsulation 2022-09-28 22:42:08 -04:00
Andrey 2ec9cca5e2 Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Andrey 61cfff1e9e K progress - just a rename 2022-09-24 23:25:36 -04:00
Matthew Kennedy dfe1b47b4d
remove ignitionPin (#4608)
* remove ignitionPin

* now that's gone

* BMW test
2022-09-23 17:30:10 -04:00
rusefillc 61134b452a tear down Engine god object #4511
oh I hope this ends well
2022-09-15 23:41:06 -04:00
rusefillc ec0e567989 tear down Engine god object #4511 2022-09-15 21:46:01 -04:00
Andrey 0c87bb7260 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:45:31 -04:00
Andrey 0e91914266 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey 663c39afdc deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:24:41 -04:00
Andrey 2c0ce0ec7d deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey 12d857b99c deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:06:52 -04:00
Andrey 6cdb0dc0af deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey 82cda62bac inline method to reduce confusion 2022-09-14 01:34:52 -04:00
Andrey G 69d9716fa6
tle8888 dead code (#4568) 2022-09-12 18:54:29 -04:00
rusefillc 5c8d44eec7 at the moment efiWatchdog always fails on enable, would this fix? 2022-09-11 21:31:42 -04:00
rusefi 88011024d9 at the moment efiWatchdog always fails on enable, would this fix? 2022-09-11 21:15:25 -04:00
Andrey G 55c1f53c75
dead code, reduce typedefs (#4566)
* Do lightweight checks first

* Dead getTimeIgnitionSeconds()

Dead since 81fffe87b7

* Get rid of efitime_t.

Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.

* Fix unit tests

* Fix misc: stm32f1_test_project
2022-09-11 16:08:11 -04:00
Andrey G 91d4844e38
time routines refactor (#4563)
* Extract time helpers from engine_controller_misc to efitime.cpp

* Rename currentTimeMillis() to getTimeNowMs()

We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.

find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;

* Rename getTimeNowSeconds() to getTimeNowS()

To align with Nt, Us, Ms versions.

* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
Andrey G 19226cb656
efiWatchdog: avoid converting time to float (#4562)
https://stackoverflow.com/questions/68690961/why-does-converting-int-to-float-lose-precision-in-c-programming-language
2022-09-11 05:46:55 -04:00
rusefillc 2a05a31550 refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc 541cd5caee Proteus with SD card outside of vehicle looses a second #4557
message correction
2022-09-10 11:43:25 -04:00
rusefillc 3f6d05dce0 Proteus with SD card outside of vehicle looses a second #4557 2022-09-09 20:17:02 -04:00
rusefillc 8d770daca8 "Blip" with trigger error on several boards #4552
exploratory watchdog
2022-09-09 19:21:29 -04:00
rusefillc a3d86c61f2 "Blip" with trigger error on several boards #4552
exploratory watchdog
2022-09-09 18:27:16 -04:00
rusefillc 45eaa0546c refactoring: better method name 2022-09-09 18:02:38 -04:00
Andrey 52869d63bb tear down Engine god object #4511
just trying different things
2022-09-07 20:25:49 -04:00
Andrey 6e8d248408 brutal encapsulation 2022-09-07 19:37:11 -04:00
Andrey ab4b451195 os_access.h dead? 2022-09-07 15:56:45 -04:00
Andrey 4934d76d88 tear down Engine god object #4511
just trying different things
2022-09-05 04:24:17 -04:00
Andrey f1f447df45 tear down Engine god object #4511
just trying different things
2022-09-05 03:38:44 -04:00
Andrey 99d8801dc6 tear down Engine god object #4511
just trying different things
2022-09-05 02:59:38 -04:00
Andrey 268a5c7964 tear down Engine god object #4511
just trying different things
2022-09-05 02:44:06 -04:00
Andrey 6d72805a56 tear down Engine god object #4511
just trying different things
2022-09-05 02:28:46 -04:00
Andrey c1b218b772 refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
Matthew Kennedy 9407150544
more granular trigger error messages (#4526)
* granular trigger error messages

* adjust test expectations

* explicitly test behavior
2022-09-04 09:15:24 -04:00
Andrey 6b4e6c8169 tear down Engine god object #4511
just trying different things
2022-09-03 11:07:26 -04:00
Andrey da66fa055c refactoring: enum name clean-up 2022-09-01 00:23:33 -04:00
Matthew Kennedy ca4936d3fe
rename and fix skyactiv cam mode (#4505) 2022-08-31 22:12:45 -04:00
rusefillc deba48e13a TT_VVT_MAZDA_MYSTERY 2022-08-28 22:57:44 -04:00
rusefillc 172f054d25
separate atomic change (#4494)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-27 22:09:54 -04:00
rusefillc 67055c69bf progress or maybe even a fix of logging? 2022-08-25 22:24:35 -04:00
rusefillc 09ec99f192 Idle air add via Lua fix #4465
AddressSanitizer being useful?
2022-08-21 00:58:59 -04:00
rusefillc 6d634e3c6a Idle air add via Lua fix #4465 2022-08-21 00:32:34 -04:00
Matthew Kennedy 165e5bb869
misc fixes (#4411)
* fix warnings

* break to debugger in case of panic

* move the check

* s
2022-08-02 12:19:50 -04:00
rusefillc 9b83ee7d6e cherry pick https://github.com/rusefi/rusefi/pull/4365 2022-07-21 15:26:41 -04:00
rusefillc 975329fcc7 Detail on how to set up iDrive or equivalent CAN button control #226
boost lua
2022-07-14 14:04:21 -04:00
rusefillc 39df02fe35 Detail on how to set up iDrive or equivalent CAN button control #226
boost lua
2022-07-14 13:03:08 -04:00
rusefillc cad14d6541 #4308 progress 2022-07-14 12:36:55 -04:00
rusefillc 67ec949eb6 Lua A/C Input #4333 2022-07-08 00:51:53 -04:00
rusefillc 483395fa2e
https://github.com/rusefi/rusefi_documentation/issues/226 (#4306)
* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

* https://github.com/rusefi/rusefi_documentation/issues/226

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-06-29 23:34:00 -04:00
rusefillc f7ecebaa64 logging of live data structs was: data points #3614 2022-06-29 02:37:24 -04:00
Matthew Kennedy 9d62aeb81f
force o2 heating (#4275) 2022-06-23 14:32:34 -04:00
rusefi a552d58d42 verbose trigger sync should reuse engineSnifferRpmThreshold #4259
reducing complexity
2022-06-18 14:17:36 -04:00
Matthew Kennedy 932f5e1f30
cam/crank sync improvements (#4152)
* clarify getOperationMode

* wait for phase synchronize to transition to sequential mode

* one test

* encapsulate vvtSyncCounter

* test

* Add option to stop VVT sync above some RPM

* getOrZero

* Revert "synchronized Phase handling improvements fix #4099"

This reverts commit 32d46d1f09.

* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"

This reverts commit d5e131b1d0.

* remove synchronizedPhase

* only crank needs this

* changelog

* needsDisambiguation()

* test

* s

* bad merge

* put the timer back

* s

* s

* changelog

* test for new behavior

* correct parameter order

* spelling

* s

* s

* s

* tests merge happy

* bad merge

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
Matthew Kennedy c0d8cbfef4
Trigger cleanup init (#4222)
* extra parameter

* name decoders in constructor

* s
2022-06-01 00:55:34 -04:00
Matthew Kennedy f945e6efc9
trigger configuration refactoring for clarity (#4212)
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix
2022-05-30 19:36:47 -04:00
Matthew Kennedy 170d574a5d
move logic in to trigger decoder (#4162)
* move logic in to trigger decoder

* status loop

* minor cleanup

* s
2022-05-10 23:55:28 +03:00
Matthew Kennedy d4509cab8a
TriggerState -> TriggerDecoder (#4157) 2022-05-10 11:41:39 +03:00
Matthew Kennedy 76ccb19453
clarify doesTriggerImplyOperationMode (#4153) 2022-05-09 15:28:30 -04:00
rusefillc 2132cec3fc Remove value copy from controller into outputChannels #4095 2022-05-09 06:12:17 -04:00