Commit Graph

1738 Commits

Author SHA1 Message Date
Matthew Kennedy f945e6efc9
trigger configuration refactoring for clarity (#4212)
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix
2022-05-30 19:36:47 -04:00
Matthew Kennedy d5a4804993
remove dead useOnlyFirstChannel (#4211)
* This field was ignored.

* move pad out

* gone
2022-05-30 07:03:40 -04:00
Matthew Kennedy 66fffee321
More trigger encapsulation (#4207)
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
Matthew Kennedy e8be471b46
bail from trigger_central (#4210) 2022-05-29 10:42:08 -04:00
Matthew Kennedy 720c463ffb
trigger decoder returns a result (#4206) 2022-05-28 09:01:45 -04:00
Matthew Kennedy 90cc62a667
honda trigger sync ratio (#4194) 2022-05-24 17:12:36 -04:00
rusefillc e8ceaeabaf Pavel says 120 2022-05-24 14:40:54 -04:00
Matthew Kennedy 6f45d0fd46
Fix trigger error indicator (#4185)
* test and fix

* more shards!
2022-05-19 09:43:42 -04:00
Matthew Kennedy fe77f5127e
12 tooth crank mode (#4179)
* 12 tooth crank

* comment

* s

* rusefi config
2022-05-17 21:38:24 -04:00
Matthew Kennedy ae91b2aea8
don't rely on triggerStateListener to detect trigger errors (#4164)
* Write proper TriggerDecoder tests

* Improve logic around sync loss

* these tests I understand

* these I sort of understand....

* the one error in the noiseless decoder is gone!
2022-05-13 18:48:26 -04:00
Matthew Kennedy 907adc6583
remove 360 trigger (#4165)
* remove 360

* s

* simplify that mess
2022-05-11 06:15:06 -04:00
Matthew Kennedy 170d574a5d
move logic in to trigger decoder (#4162)
* move logic in to trigger decoder

* status loop

* minor cleanup

* s
2022-05-10 23:55:28 +03:00
Matthew Kennedy d4509cab8a
TriggerState -> TriggerDecoder (#4157) 2022-05-10 11:41:39 +03:00
Matthew Kennedy 7e0f2d8337
switch back to flag (#4155) 2022-05-10 07:52:29 +03:00
Matthew Kennedy 5eb5b7cfbb
phase resolution rpm limit (#4156) 2022-05-10 07:22:50 +03:00
Matthew Kennedy 7f5672aaec
encapsulate stuff properly (#4154) 2022-05-09 15:46:36 -04:00
rusefillc 32d46d1f09 synchronized Phase handling improvements fix #4099 2022-05-09 04:36:03 -04:00
rusefillc d5e131b1d0 m_hasSynchronizedSymmetrical handling improvements #4099
API progress
2022-05-09 04:04:38 -04:00
rusefillc 88a6b34577 helping build 2022-05-08 09:14:50 -04:00
rusefillc e3f6541e99 Merge branch 'master' of https://github.com/rusefi/rusefi 2022-05-08 09:11:16 -04:00
GitHub build-firmware Action c9560fb2dd Auto-generated configs and docs 2022-05-08 13:06:44 +00:00
rusefillc bd8459875d refactoring: bringing method names up to date 2022-05-08 09:04:27 -04:00
rusefillc bd9639b91d Remove value copy from controller into outputChannels #4095 2022-05-08 08:50:27 -04:00
GitHub build-firmware Action 04da97c1e3 Auto-generated configs and docs 2022-05-08 12:05:34 +00:00
rusefillc 84f75092ec Remove value copy from controller into outputChannels #4095 2022-05-08 07:58:19 -04:00
Matthew Kennedy b650bbe46c
Trigger gm 3 vs 5 (#4140)
* add parameter

* two modes

* add new mode to list

* format

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-05-06 08:25:44 -04:00
Matthew Kennedy 045cbcbff1
fix 36-2 trigger params (#4138)
* fix gap params

* changelog was wrong too

* typo

* binary log knock count and retard

* Revert "binary log knock count and retard"

This reverts commit 48b29d24d72331065a9f648ef5bfe845d03575d6.
2022-05-05 07:41:26 +03:00
rusefillc efccb2106d Corolla 1ZZ 2003 trigger improvements fix #4132 2022-05-04 02:45:44 -04:00
Matthew Kennedy e4a0979dc2
Brain pin is enum class (#4108)
* change most usages to Gpio::

* board configs

* engine configs etc

* isBrainPinValid, smart gpio

* generator

* generator

* generator

* connector yamls

* kinetis enums

* cypress txt

* kinetis config

* frankenso

* config generator

* actually do it for the others

* disable skips for pr ci

* fix tle8888

* misc

* weird cast from int

* needs this operator too

* this can be an unsigned subtract

* happy tests

* s

* kinetis isConfigurationChanged weirdness

* missed J/K

* cypress efifeatures

* build script mistake (!)

* mistake in smart gpio

* debounce

* eg33

* kinetis, so needy

* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
Matthew Kennedy bc6a87cadc
allow enum_class in rusefi_hw_enums.h (#4104)
* make things c++ friendly

* install various canaries in coal mines

* using is much clearer than typedef

* fixing builds

* lps25

* trigger includes were a mess

* c -> c++ cleanup

* os util

* why did so many include os_util.h?

* fwd declare

* cypress/kinetis

* s

* eg33 happy

* happy sim

* cypress usb

* pch

* cypress

* doesn't need to include all that

* h7
2022-04-25 20:38:16 -04:00
GitHub build-firmware Action c8e19e807a Auto-generated configs and docs 2022-04-25 04:01:07 +00:00
GitHub build-firmware Action 8406432b29 Auto-generated configs and docs 2022-04-25 03:46:16 +00:00
rusefillc 4b8b7b1d70 docs 2022-04-24 16:17:42 -04:00
rusefillc 838e8d8ddb Remove value copy from controller into outputChannels #4095 2022-04-23 19:53:05 -04:00
rusefillc 71275e841b
m_hasSynchronizedSymmetrical handling improvements #4099 (#4101) 2022-04-23 19:45:29 -04:00
GitHub build-firmware Action 986e0573b2 Auto-generated configs and docs 2022-04-23 22:02:47 +00:00
rusefi 511954efab Remove value copy from controller into outputChannels #4095 2022-04-23 17:50:20 -04:00
GitHub build-firmware Action 82e3aa14eb Auto-generated configs and docs 2022-04-19 19:11:17 +00:00
rusefillc 13ccfefb7e https://github.com/rusefi/web_backend/issues/166 2022-04-19 14:49:57 -04:00
rusefillc 1ceabed6a5 humans need humane warning messages 2022-04-18 11:35:19 -04:00
GitHub build-firmware Action a2cff4ee12 Auto-generated configs and docs 2022-04-17 20:30:07 +00:00
rusefillc be772a6a1a random progress & method rename 2022-04-16 17:40:05 -04:00
rusefillc b9769f59cc i will confess: i need to fit a debug build into discovery 2022-04-16 17:24:31 -04:00
rusefillc 06e899e1bb very random progress 2022-04-16 17:07:57 -04:00
rusefillc 70e4d118ef very random progress 2022-04-16 17:04:35 -04:00
rusefillc 007396003e logging of live data structs was: data points #3614
unification with outputs
2022-04-14 21:01:26 -04:00
rusefillc 435ecc413c logging of live data structs was: data points #3614
unification with outputs
2022-04-14 15:46:01 -04:00
rusefillc e631988b22 Proper cam speed labels in triggers #4021 2022-04-03 12:22:47 -04:00
Andrey 204ac3961b Trigger setup in TS is highly confusing: hide operation mode from users? #4031
WOW it works?!
2022-04-03 02:30:43 -04:00
Andrey 9d335c1261 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 01:38:52 -04:00
Andrey c2a97343f2 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 01:11:53 -04:00
rusefillc 96cc09d166 huh? 2022-04-02 21:01:29 -04:00
rusefillc 6b5747d4c8 refactoring: method rename 2022-04-02 21:01:29 -04:00
rusefillc 086739d20a Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2022-04-02 19:08:22 -04:00
rusefillc 59f23e294b Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2022-04-02 18:32:40 -04:00
rusefillc ea94fc05ae Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2022-04-01 21:11:32 -04:00
Andrey 89054c3a31 new VVT trigger shape? 4-1 Toyota #1847 2022-03-23 19:25:13 -04:00
Matthew Kennedy 7d657106d7
warning cleanup (#4020) 2022-03-22 16:53:24 -04:00
Andrey b3fdd790b5 new VVT trigger shape? #1847 2022-03-22 06:34:22 -04:00
rusefillc b1de262520 toothed previous time #4019 2022-03-21 20:41:09 -04:00
Matthew Kennedy c7590305c4
tweak sync parameters for mitsubishi (#4017) 2022-03-21 19:23:48 -04:00
Andrey f16088f20d Mitsubishi 4B11 support #4013 2022-03-20 11:24:08 -04:00
Andrey 084a582775 Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 22:24:50 -04:00
Andrey 625af513fb Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 22:11:51 -04:00
Andrey 402f36aad6 Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 22:06:19 -04:00
Andrey 921aed3afe Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 21:34:25 -04:00
Andrey 21ab6a1a7b Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2022-03-19 20:34:51 -04:00
Andrey d72c60452a Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 17:57:35 -04:00
rusefillc 6fa0ce2a3a Mitsubishi 6G75 Support #4014 2022-03-19 16:34:40 -04:00
rusefillc 9bc4094e48 Mitsubishi 6G75 Support #4014 2022-03-19 16:28:06 -04:00
rusefillc b0772612cd Mitsubishi 3A92 Support - 3 cylinder #4011 2022-03-19 15:54:43 -04:00
rusefillc 9571f1fe67 Mitsubishi 4B11 support #4013 2022-03-19 15:52:42 -04:00
rusefillc aa7624950a Mitsubishi 3A92 Support (Issue #4011) 2022-03-19 12:01:57 -04:00
rusefillc 1d64929f33 Remove Miata MX5 NB1 trigger fix #3488 2022-01-31 18:20:43 -05:00
rusefillc 30c48389c7 sporadic HighRevTest testV12 #3806
let's attempt to guess his intentions
2022-01-25 17:24:38 -05:00
rusefillc aef0995871 sporadic HighRevTest testV12 #3806
is this bug here?
2022-01-25 10:28:35 -05:00
Matthew Kennedy 4e639480ff
fix (#3833) 2022-01-24 18:15:18 -05:00
Andrey 26c2d76f6c migrating to SensorType::Rpm API 2022-01-20 23:36:09 -05:00
Andrey cda2b711cf migrating to SensorType::Rpm API 2022-01-20 23:32:59 -05:00
rusefillc e464dd4a52 Bosch Quick Start on B6 Passat is confused about phase #3812 2022-01-19 20:55:50 -05:00
rusefillc 3898f0ce7d Bosch Quick Start on B6 Passat is confused about phase #3812 2022-01-19 16:42:05 -05:00
rusefillc 890d7769a0 Bosch Quick Start on B6 Passat is confused about phase #3812 2022-01-19 16:42:05 -05:00
rusefillc 21c2a2f7a9 Bosch Quick Start on B6 Passat is confused about phase #3812
running engine proved VVT_BOSCH_QUICK_START to match VVT_SECOND_HALF thus hard-coding phase choice
2022-01-19 01:30:16 -05:00
rusefillc 046f26508a Bosch Quick Start on B6 Passat is confused about phase #3812
OMG :( we were totally not using VVT info of VVT_BOSCH_QUICK_START and VVT_NISSAN_MR and etc etc
2022-01-19 00:48:39 -05:00
rusefillc 577b9ccb06 refactoring: reusing existing flag instead of switch which refers to same thing 2022-01-19 00:48:39 -05:00
Andrey 9f5188bf30 Better handling of RPM during stop of cranking #3803 2022-01-17 21:27:10 -05:00
Andrey a1374062f0 Better handling of RPM during stop of cranking #3803
reuse existing magic constant
2022-01-17 21:18:43 -05:00
rusefillc bc66096574 Better handling of RPM during stop of cranking #3803
refactoring: reusing existing method
2022-01-17 21:00:49 -05:00
rusefillc d9175696a2 mk files refactoring 2022-01-06 21:40:48 -05:00
GitHub build-firmware Action 2208947bb3 Auto-generated configs and docs 2022-01-05 06:49:51 +00:00
GitHub build-firmware Action 38b17f5859 Auto-generated configs and docs 2022-01-05 05:09:04 +00:00
Matthew Kennedy 0932fcf94c
Improve NA/NB miata sync parameters (#3730)
* NA sync parameters

* NB vvt pattern too

* zach's car says tighten the gap

* look at that, we sync one cycle sooner!
2022-01-01 21:39:04 -05:00
Matthew Kennedy d5c4b79b1a
Nb2 crank sync special case (#3727)
* extract isSyncPoint

* test because why not

* check vvt resync nb2

* custom nb decoder

* test only resyncs once!

* good job valgrind, you found a bug!
2021-12-31 15:47:25 -05:00
Matthew Kennedy b3de217c1b
adjustment to #3722 (#3723)
* s

* behold, another bug a test caught

* test

* test generates usable trigger pattern so it works correctly

* comment

* don't need that
2021-12-31 01:21:21 -05:00
Matthew Kennedy 4981eb43d0
extract isSyncPoint function (#3726)
* extract isSyncPoint

* test because why not

* check vvt resync nb2

* clean up noise from test case

* clarify and comment
2021-12-30 11:39:04 -05:00
rusefillc 860f2f96f9 docs 2021-12-29 16:18:21 -05:00
Matthew Kennedy c3b712aa3b
remove vvtSyncTimeNt (#3722)
* s

* poke

* poke again for science

* kick for science

* kick

* kick

* comment kick

* s

* don't try to compare the array decay pointer to 0 (!)

* collateral damage

* adjust miata sync

* reset trigger states correctly on engine stop

* s

* check synchronized bit

* now we don't need it at all?!

* and *NOT* synced

* start VVT sync earlier
2021-12-28 00:00:26 -05:00
Matthew Kennedy 95ad75318d
improved noFiringUntilVvtSync logic (#3696)
* s

* poke

* poke again for science

* kick for science

* kick

* kick

* comment kick

* s

* don't try to compare the array decay pointer to 0 (!)

* collateral damage

* adjust miata sync

* reset trigger states correctly on engine stop

* s

* nissan MR too
2021-12-27 12:09:38 -05:00
rusefillc 4292c2fb1d MAP phase sensing fix #3544
removing dead implementation
2021-12-16 21:28:27 -05:00
rusefillc 06ccf524dd MAP phase sensing #3544
removing dead implementation
2021-12-16 21:13:55 -05:00