Commit Graph

129 Commits

Author SHA1 Message Date
Andrey 242d07f50b only: new trigger method 2024-08-06 17:10:18 -04:00
rusefi cc093aad5b cisnan progress 2024-07-23 12:51:07 -04:00
Matthew Kennedy ae1a6e9d8d cisnan -> std::isnan 2024-07-22 19:53:59 -04:00
Matthew Kennedy 566620cf6d avoid float -> double 2024-05-11 18:32:54 -04:00
Matthew Kennedy 4696848ad4 we often mean inline when we say static 2024-03-29 11:56:52 -04:00
Andrey 04721870c8 custom FW repos code generation process #5817
preparation
2023-12-19 16:47:58 -05:00
Andrey c403a86f9b only:helping non-EFI_ENABLE_ASSERTS compilation 2023-11-02 09:55:22 -04:00
Matthew Kennedy 6b8aaa8e30 default params for happy test 2023-10-24 15:35:55 -04:00
Matthew Kennedy 2b392307e4 make wrapAngle a function not macro 2023-10-19 22:59:43 -04:00
rusefi a7b9603b9c docs 2023-10-19 22:54:24 -04:00
Matthew Kennedy 28fd3c59ac remove wrapAngle2, wrapAngle does fine 2023-10-19 22:53:09 -04:00
Andrey 0a459fa9f5 36/2/2/2 is confusing #5566
only: code comments
2023-09-15 23:40:31 -04:00
Andrey b5fd6ea044 spelling is important 2023-09-09 19:53:18 -04:00
Matthew Kennedy f12cab93aa looks like initialState was dead #55
(cherry picked from commit daaf50c2e45de84b9a47716ff253d744caeb34b8)
2023-05-31 16:11:05 -04:00
Andrey d13610e1f1 trigger refactoring: we are long overdue for better api, also reducing CRANK_MODE_MULTIPLIER crazy 2023-05-13 14:26:31 -04:00
Matthew Kennedy 61e5b4b1ad change ObdCode to enum class builds firmware 2023-04-29 00:44:00 -04:00
Andrey e08cdf0fb6 trigger refactoring
only:mre_f4
2023-03-03 00:21:40 -05:00
rusefi c4d7192f84 Revert "making enum less public API"
This reverts commit d4f02bbece.
2023-02-15 09:08:52 -05:00
rusefillc d4f02bbece making enum less public API 2023-02-15 08:43:15 -05:00
Andrey 99edf9484a docs 2022-11-16 15:23:42 -05:00
Andrey 6ca9b6eda7 refactoring: default parameter, global replace 2022-11-16 14:28:43 -05:00
rusefi ec77afeaa0 reducing ugly 2022-11-06 20:47:57 -05:00
rusefillc 87d6aa2ed9 minor trigger refactoring 2022-11-06 01:11:33 -04:00
rusefillc 43e3fce9b1 minor trigger refactoring 2022-11-05 22:42:33 -04:00
rusefillc fd86dc2b0f minor trigger refactoring 2022-11-05 22:30:08 -04:00
Andrey c6e34be447 A gem of dead code 2022-11-05 21:53:38 -04:00
Matthew Kennedy f760ae11c1
simplify initializeSkippedToothTrigger (#4674) 2022-10-17 16:05:27 -04:00
Matthew Kennedy cb86c014cf
fix instant rpm clearing bug (#4629)
* improve instant rpm

* changelog
2022-09-29 07:15:59 -04:00
Andrey 36113d6f66 nicer fatal message if that ever happens 2022-09-28 19:47:14 -04:00
Matthew Kennedy ca623eb6ee
plumbing parts of 4621 (#4622)
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy 7139ddcda2
explicitly pass which edges we sync trigger on (#4607)
* require sync edge type

* s

* fix neon

* info printing

* put enums back

* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc 9e7f36a5ca tear down Engine god object #4511 2022-09-15 21:28:27 -04:00
rusefillc 7cc41dfa75 human brain does need sleep 2022-09-11 12:40:24 -04:00
rusefillc 2eca6ec3c7 refactoring: type safety 2022-09-11 05:41:01 -04:00
rusefillc 2a05a31550 refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc 851e8e48d3 refactoring: type safety 2022-09-11 02:57:35 -04:00
Andrey c1b218b772 refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
rusefillc b0edd12752 docs 2022-08-22 18:44:44 -04:00
Matthew Kennedy 932f5e1f30
cam/crank sync improvements (#4152)
* clarify getOperationMode

* wait for phase synchronize to transition to sequential mode

* one test

* encapsulate vvtSyncCounter

* test

* Add option to stop VVT sync above some RPM

* getOrZero

* Revert "synchronized Phase handling improvements fix #4099"

This reverts commit 32d46d1f09.

* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"

This reverts commit d5e131b1d0.

* remove synchronizedPhase

* only crank needs this

* changelog

* needsDisambiguation()

* test

* s

* bad merge

* put the timer back

* s

* s

* changelog

* test for new behavior

* correct parameter order

* spelling

* s

* s

* s

* tests merge happy

* bad merge

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
Matthew Kennedy 4ada633206
Remove third trigger channel (#4226)
* remove third trigger

* clean up the honda mess

* there was nothing novel about this engine config

* include

* missed a few

* s

* x

* changelog

* don't set the third trigger input

* don't redefine the same thing 3 times

* only two inputs!

* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy c0d8cbfef4
Trigger cleanup init (#4222)
* extra parameter

* name decoders in constructor

* s
2022-06-01 00:55:34 -04:00
Matthew Kennedy 70c2689f1e
remove trigger duty cycle calculation (#4213)
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix

* remove duty cycle thing
2022-05-30 22:39:57 -04:00
Matthew Kennedy f945e6efc9
trigger configuration refactoring for clarity (#4212)
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix
2022-05-30 19:36:47 -04:00
Matthew Kennedy 66fffee321
More trigger encapsulation (#4207)
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine
2022-05-29 13:49:00 -04:00
Matthew Kennedy d4509cab8a
TriggerState -> TriggerDecoder (#4157) 2022-05-10 11:41:39 +03:00
rusefillc e631988b22 Proper cam speed labels in triggers #4021 2022-04-03 12:22:47 -04:00
Andrey 9d335c1261 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 01:38:52 -04:00
rusefillc 086739d20a Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2022-04-02 19:08:22 -04:00
rusefillc 59f23e294b Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2022-04-02 18:32:40 -04:00
rusefillc ea94fc05ae Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077 2022-04-01 21:11:32 -04:00