rusefillc
6665c4fb34
docs
2021-12-26 13:41:10 -05:00
rusefillc
9f8ccececd
docs & refactoring
2021-12-26 12:35:41 -05:00
Andrey
940b04ab24
Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming
2021-12-07 20:18:47 -05:00
rusefillc
e75590fd45
why so many channels are hidden in debug ? #3614
2021-11-29 14:11:19 -05:00
Scott Smith
98040ad9af
Make the module API more concise. ( #3571 )
...
engineModules.get<FOO>(). becomes modules<FOO>()->
I believe the new API is more conducive to supporting arrays, by doing std::array<T, N> or
std::array<Mockable<T>, N>, with the support of a helper class.
2021-11-17 21:50:00 -05:00
Scott Smith
988aacdd91
Create a base class EngineModule for that contains various useful callbacks. ( #3548 )
...
* Create a base class EngineModule for that contains various useful callbacks.
This cleans up the API by not requiring the notifiers to know about who wants callbacks. The only
place you need to update to add a module is in one place.
* Add mockability.
* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
Scott Smith
823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith
cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* ( #3560 )
...
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*
for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
git grep -l "$i" | xargs sed -i "s/$i//g"
done
git grep -l "inject" | xargs sed -i "/inject[(][)]/d"
for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done
git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h
* Review fixups.
2021-11-16 16:52:11 -05:00
Matthew Kennedy
8cdac4cac0
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
Matthew Kennedy
145316c497
less macro, more c++ ( #3549 )
...
* less macro
* s
2021-11-15 12:44:40 +01:00
Matthew Kennedy
24224729a3
support autoscale on table axes ( #3452 )
...
* scale map Y axis
* allow different row/col types
* scaled channel detector
* interpolation
* looks like this actually works
* tests, no manual scaling
* comment
2021-11-03 19:53:26 -04:00
rusefillc
296f83ea4d
refactoring
2021-10-16 23:18:09 -04:00
rusefillc
ba640a16f5
refactoring
2021-10-16 22:08:47 -04:00
rusefillc
6576acc39a
Remove engine load acceleration enrichment fix #3357
2021-10-16 21:49:38 -04:00
rusefillc
61e2b3d5db
Remove engine load acceleration enrichment fix #3357
2021-10-16 21:24:05 -04:00
Andreika
d917cc8cc2
[DRAFT] Fix cranking->idling taper phase for useSeparate*ForIdle tables ( #3168 )
...
* Rename Phase::CrankToRunTaper -> CrankToIdleTaper
* Change isIdling() to isIdlingOrTaper()
* test_idle_controller.cpp
* useSeparateIdleTablesForCrankingTaper setting
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2021-10-06 12:05:20 -04:00
Matthew Kennedy
9797d25b7c
getOrZero ( #3319 )
2021-10-05 19:59:07 -04:00
Matthew Kennedy
25414ebdad
yet more pch ( #3068 )
...
* big pch energy
* put back ramdisk stub
* tests are happy
* h743 nucleo
* kinetis
* I love deleting code!
* make stepper happy
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
Matthew Kennedy
b52d50bbf2
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
Matthew Kennedy
2ce7777865
don't require EXTERN_ENGINE in every file ( #2969 )
...
* move enginePins
* no more extern engine
* uses
* more
* extern config too
* put this where it belongs
* include correct header
* merge
2021-07-16 18:13:33 -04:00
Matthew Kennedy
e830a99275
lua hooks for custom airmass model ( #2697 )
...
* lua airmass
* not const any more
* bad merge
* don't change the position of others
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-16 00:49:14 -04:00
Matthew Kennedy
c171d5f1d3
not const getAirmass ( #2883 )
...
* not const
* test
2021-07-01 00:05:42 -04:00
Matthew Kennedy
1d10fbc7a8
const airmass ( #2694 )
2021-05-14 07:17:22 -04:00
Matthew Kennedy
4474f9f1c2
Maf in sensor model ( #2672 )
...
* init
* consumers
* hasMafSensor
* consumers
* remove
* remove
* s
* guard
* tiny bit of ram
* ram
2021-05-09 20:59:06 -04:00
Matthew Kennedy
4a1d3de9a6
remove unused msg parameter ( #2360 )
...
* dead parameter
* last few
2021-02-16 09:32:16 -05:00
Matthew Kennedy
0e70d08a22
Add fallback map table ( #2248 )
...
* table
* sd math
* config
* debug channel name
* ptr vs not ptr
* actually use return value
* memory
* less magic
2021-01-31 17:19:06 -05:00
Matthew Kennedy
e0b2802a43
Map fallback logic, TS cleanup ( #2247 )
...
* add new field
* UI
* set default
* consume new parameter
* some cleanup while we're at it
2021-01-27 20:31:29 -05:00
Matthew Kennedy
868f0d47ac
Enable idle timing/ve tables based on idle phase logic ( #2213 )
...
* add helper
* advance
* ve
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-11 00:54:37 -05:00
Matthew Kennedy
92ea09b0a6
switch more map to read from sensor model ( #2162 )
...
* hook up map
* check for init
* switch some consumers
* that's the rest of them
* test
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-02 19:13:10 -05:00
Matthew Kennedy
acdf6fdc85
Put map in the sensor model ( #2161 )
...
* hook up map
* check for init
* switch some consumers
* don't do limp for now
* oops
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-30 08:43:49 -05:00
rusefillc
e5ef8de2ae
unit tests in clang #2012
2020-12-04 23:59:21 -05:00
rusefillc
c70c546d46
better error handling
2020-11-17 22:45:43 -05:00
Matthew Kennedy
ef0b2f7be0
Selectable VE axis override ( #1769 )
...
* add config fields
* config options
* new output channels
* dump out state to ts
* s
* implement override
* enums
* this test is no longer used
* test new behavior
* old
* comments
2020-09-07 10:15:42 -04:00
Matthew Kennedy
6e7d72170f
Move ve logic ( #1762 )
...
* move ve
* fix build
* fix rendering
* duh
* cleaning
* correct scaling
* put some back
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-09-06 19:06:32 -04:00
Matthew Kennedy
ecbec68a52
explicit
2020-07-29 02:23:03 -07:00
Matthew Kennedy
c2bd9087e2
fwd decl
2020-07-28 11:44:09 -07:00
Matthew Kennedy
927f365647
missed a spot
2020-07-25 02:05:33 -07:00
Matthew Kennedy
8f27fc8b53
alphan
2020-07-25 01:14:35 -07:00
Matthew Kennedy
b26bd6d891
move speed density
2020-07-24 19:30:12 -07:00
Matthew Kennedy
957f63ccf3
format
2020-07-24 11:44:54 -07:00
Matthew Kennedy
7e88011de5
move impl
2020-07-23 01:23:57 -07:00
Matthew Kennedy
8bc18db80f
base class
2020-07-23 01:12:38 -07:00
Matthew Kennedy
b544c140a3
comment headers, notes
2020-07-22 18:24:20 -07:00
Matthew Kennedy
5e7ddc9f24
start refactor
2020-07-22 13:11:07 -07:00
Matthew Kennedy
76745412c6
Factor out airmass logic ( #1483 )
...
* refactor
* extract more airmass
* rename, fix tests
2020-06-06 07:25:19 -04:00