Commit Graph

319 Commits

Author SHA1 Message Date
rusefillc 26ae6f7490 [SECURITY] Cheap password protection against tune modification fix #4243 2022-07-30 12:23:53 -04:00
rusefillc 9e4187d8cf typos 2022-07-20 18:45:35 -04:00
Andrey G 7caef0ba92
TunerStudio reconnect speedup (#4358)
* TunerStudio: do not emit tons of errors if we are not in sync

Track state of sync with ither side. Emit only ONE error when sync
is lost.
Also no need to wait 1sec for second byte in binary mode. 10mS is
enought.

* TunerStudio: remove duplicated debug print

* TunerStudio: comment about in_sync

* TunerStudio: clear comments
2022-07-20 17:54:10 -04:00
rusefillc 70d0351f9c picking atomic piece of #4358 2022-07-20 17:06:34 -04:00
rusefillc adc11fcc1f refactoring: reducing warnings 2022-07-20 17:03:15 -04:00
Matthew Kennedy a0d8ae3f4f
use libfirmware for a few things (#4351)
* use libfirmware

* unit tests

* crc

* missed one

* bootloader
2022-07-16 02:22:51 -04:00
Matthew Kennedy aecacc6aa1
Rewrite tooth logger buffer management (#4317)
* s

* make it work

* put back enough maybe

* fix console composite log

* unit tests can just use a vector, why not

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-07-04 16:57:17 -04:00
rusefillc 5a2b430183 visiting "live data" tab causes fatal error on ECU fix #4271 2022-06-25 19:48:48 -04:00
rusefillc d98f35576d docs 2022-04-25 00:36:12 -04:00
Andrey 4db874a607 shameless reminder about time-sensitive Proteus fabrication issue which worries me 2022-04-17 16:00:31 -04:00
rusefillc 56f214d679 logging of live data structs was: data points #3614
exciting
2022-04-17 13:28:43 -04:00
rusefillc 07f210a82b random progress & method rename 2022-04-16 17:35:59 -04:00
Matthew Kennedy 6aef4f10d0
fragment refactoring (#4072)
* fragment refactoring

* jar

* jar?
2022-04-16 09:24:45 -04:00
rusefillc 5086d93a23 logging of live data structs was: data points #3614
getting closer...
2022-04-14 22:40:35 -04:00
rusefillc 084685c747 logging of live data structs was: data points #3614
ETB
2022-04-14 15:25:01 -04:00
rusefi 141804f490 steps towards better commands encapsulation 2022-04-14 01:44:35 -04:00
rusefi d7da81b5c2 steps towards better commands encapsulation 2022-04-14 01:06:44 -04:00
rusefi fcf9a42bea encapsulation 2022-04-14 00:35:33 -04:00
rusefillc 57df620087 logging of live data structs was: data points #3614 2022-04-13 22:27:44 -04:00
Andrey 8752f55a5f logging of live data structs was: data points #3614
progress
2022-04-13 21:52:05 -04:00
rusefillc d78b09f651 logging of live data structs was: data points #3614
hmm
2022-04-13 21:37:49 -04:00
rusefillc 37d4adeb33 logging of live data structs was: data points #3614
progress & more consistent convention
2022-04-13 21:20:37 -04:00
rusefillc 4834683dc6 logging of live data structs was: data points #3614
progress & more consistent convention
2022-04-13 20:46:55 -04:00
rusefillc 413e636d4c typo/grammar 2022-04-13 17:55:31 -04:00
rusefillc cdc7c2497b JNI for test coverage #3965 2022-03-15 10:47:02 -04:00
rusefillc ed16f3180f JNI for test coverage #3965 and code style 2022-03-15 10:32:32 -04:00
rusefillc 0f5cb33426 Firmware support or user instructions for jdy-33 #3944 2022-03-10 13:35:37 -05:00
rusefillc 22eb5a8073 Firmware support or user instructions for jdy-33 #3944 2022-03-10 12:49:04 -05:00
Matthew Kennedy 35c4c0bfba
move allowLongResponse option to ECU side (#3917)
* executeCommand knows about opcodes

* kick

* remove allowLongResponse

* add api in firmware instead

* test size

* bad merge

* firmware missed a spot

* fix logic

* haha we have to disable it
2022-02-11 16:03:20 -05:00
Matthew Kennedy f1897ba7aa
less dependence on that logger (#3884)
* less dependence on that logger

* comma

* refactor a bit, make it clear what this thing actually *does*

* static

* shrink the buffer a bit and make names useful

* dead util that's just subtraction lol
2022-02-09 06:53:16 -05:00
rusefillc fb5456dbaa GDI Epic #1448 2022-01-18 16:16:17 -05:00
rusefillc c29a0b54a7 GDI Epic #1448 2022-01-18 12:31:12 -05:00
rusefillc 0f38a22a46 't' in terminal does not print seconds properly fix #3780 2022-01-12 16:03:40 -05:00
rusefillc f1a8cd66e8 't' to print current date 2022-01-11 22:47:46 -05:00
rusefillc 6ee0a55eaf RE usability: live data for idle controller 2022-01-10 19:48:58 -05:00
rusefi 1a8b6d24fc disablePrimaryUart for MRE for GDI 2022-01-08 19:38:02 -05:00
rusefillc 25ca48c408 Live Data progress 2022-01-06 17:58:59 -05:00
rusefillc 8da3d17772 docs 2021-12-08 11:55:34 -05:00
Andrey 940b04ab24 Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming 2021-12-07 20:18:47 -05:00
rusefillc 70e738cf5f rusEFI console ISO-TP via PCAN #3667
better logging
2021-12-07 15:15:06 -05:00
rusefillc d23b029b5c tune via CAN #3361
a couple of flush() were missing, also improving readability
2021-12-06 22:19:30 -05:00
Matthew Kennedy a37c9bca9e
Remove the EFI_NO_CONFIG_WORKING_COPY option (#3630)
* no working copy

* oops
2021-11-29 16:44:45 -05:00
Matthew Kennedy 0badb6b2ff
AC is EngineModule (#3604)
* AC is engine module

* missed a spot with main relay while we're at it

* TS
2021-11-25 07:59:31 -05:00
rusefillc 3077f795c4 live data for wastegate #3588 2021-11-24 12:59:57 -05:00
Matthew Kennedy 81fffe87b7
main relay doesn't use fsio (#3580)
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag

* main relay

* plumbing

* dead fsio stuff

* test it

* by 100%, we mean 99.98%
2021-11-24 07:47:51 -05:00
Matthew Kennedy d40ca0f581
fuel pump doesn't use fsio (#3576)
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag
2021-11-19 22:23:12 -05:00
Scott Smith 823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565)
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Matthew Kennedy 8cdac4cac0
remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Matthew Kennedy cb032fb1ea
(void) -> () (#3550)
* static functions with (void)

* more

* Revert "more"

This reverts commit 246e53441f935451437df186ac92d7df26b62fb6.

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-15 13:02:34 +01:00
Matthew Kennedy 3f2a9c3fe8
test TS writes (#3515)
* test TS writes

* s

* this must be a gcc extension
2021-11-10 07:29:40 -05:00
Andrey d0b2ce5654 Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353 2021-10-30 22:21:36 -04:00
rusefillc 570e2b2a87 respond to 'Q follow-up #3383 2021-10-20 20:51:10 -04:00
Matthew Kennedy 44f8698d3e
respond to 'Q' (#3382) 2021-10-20 15:40:37 -04:00
rusefillc 970d8f7f84 Whatever we call it, whatever we implement it - we need live data / remote view into rusEFI actual state #3353
progress
2021-10-14 18:50:03 -04:00
rusefillc 85618f61d5 fixing build 2021-10-14 16:49:15 -04:00
rusefillc 0254a141df Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353
progress
2021-10-14 15:17:30 -04:00
rusefillc db73c52b96 TS channel names for nicer console messages 2021-09-18 18:03:31 -04:00
rusefillc b597d80798 TS channel names for nicer console messages 2021-09-18 16:58:35 -04:00
rusefillc 847fb75a23 TS channel names for nicer console messages 2021-09-18 15:33:14 -04:00
rusefillc 48a009fc33 Revert "Revert "memory savings (#3195)""
This reverts commit 0b3ef5f5
2021-08-27 06:18:05 -04:00
rusefillc 0b3ef5f553 Revert "memory savings (#3195)"
This reverts commit 52a24ee7
2021-08-27 02:32:31 -04:00
Matthew Kennedy 52a24ee773
memory savings (#3195)
* d

* dead code

* all your ram are belong to me

* turn off gpiochips we don't need

* save

* save by using the same file handle

* smaller stack ok

* these can be on the stack

* this is closer

* what about ccm?

* probing available

* now probe ccm

* ccm

* put stuff in ccm

* fsio

* memory usage

* memory
2021-08-26 23:05:31 +03:00
Matthew Kennedy d24f1462e2
even more pch (#3112)
* s

* more

* s

* f7
2021-08-04 19:30:52 -04:00
Matthew Kennedy 25414ebdad
yet more pch (#3068)
* big pch energy

* put back ramdisk stub

* tests are happy

* h743 nucleo

* kinetis

* I love deleting code!

* make stepper happy

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
Matthew Kennedy 0f0b84a6db
remove TS file read (#3004)
* remove

* more defines

* test

* lots of java

* s
2021-07-21 14:24:53 -04:00
Matthew Kennedy 2ce7777865
don't require EXTERN_ENGINE in every file (#2969)
* move enginePins

* no more extern engine

* uses

* more

* extern config too

* put this where it belongs

* include correct header

* merge
2021-07-16 18:13:33 -04:00
rusefi 0808372d34 longer error message in 't' response 2021-07-14 12:42:35 -04:00
rusefi 4c0184e509 't' comammand to return fatal error text 2021-07-13 22:53:11 -04:00
Andrey G 0afd3c83df
Fix swap macro (#2904)
* convert swap macroses to inline functions

* clean-up workarounds
2021-07-04 18:03:17 -04:00
Andrey G 08747d036e
TS communication minor fixes (#2847)
* console: noone use this

* console: do not stop blinking if TS command executes too long

Set and clear flag from the same place

Co-authored-by: rusefillc <48498823+rusefillc@users.noreply.github.com>
2021-06-23 04:36:55 -04:00
Andrey 8d0046b0de removing dead code 2021-06-23 04:26:32 -04:00
Andrey 498358247e performance optimization by dron0gus 2021-06-21 09:27:09 -04:00
Andrey 4182eccbf3 random trick 2021-06-12 13:48:37 -04:00
Matthew Kennedy e3fcbdc7c0
ts logger (#2566)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-18 19:13:48 -04:00
Matthew Kennedy f0cf4f38ff
fix multi-serial-port insanity (#2476)
* carve out UART specific

* implement channel

* config cleanup

* use new config

* bootloader

* dead code

* s

* h7 inherits f7

* oops

* ok now it's right

* tests

* cleanup

* call setup

* put that in its own file

* cleanup

* format

* guard

* not needed

* improve guarding

* portable

* allow override of uart mode

* fixes for bootloader

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-28 09:06:36 -04:00
Matthew Kennedy 4e3e95db2d
replace print/printMsg with scheduleMsg (#2497)
* start cleaning

* disabled feature means don't print that it's disabled

* cli

* usages

* printMsg -> scheduleMsg

* this is alllll dead now

* no crlf please

* all hope is lost if you manage to hit this line

* tests

* tests

* ok we did actually need that part

* sim

* d

* kinetis

* it did ifdef, not if

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-26 17:23:26 -04:00
Matthew Kennedy 6491c83f73
read configuration from flash exactly once (#2481)
* early hw init

* s

* read configuration exactly once

* cleanup

* housekeeping

* test friendly

* ugh bad merge

* that is a noop

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-25 18:16:26 -04:00
Matthew Kennedy d7698f6703
Dedicated code path for USB console/TS (#2465)
* new apis

* dedicated USB path

* move decl

* init

* don't init usb twice

* guard

* check that we're initialized before using TS

* comment

* guard

* guard USB

* brain doesn't go good

* make tests happy

* dead define

* cypress

* ifdef != if

* s

* include priority

* don't start a thread we know we don't need

* bad-ish merge

* const

* why did this code exist...?

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-18 14:07:22 -04:00
Matthew Kennedy a931928a61 type signature, guards 2021-03-15 17:11:11 -04:00
rusefillc cf4068f54a fix error/warning buffer overflow #2456 2021-03-14 09:52:27 -04:00
Matthew Kennedy b56a31143e
fix error/warning buffer overflow (#2456)
* fix error printing overflow

* make the worst offender shorter

* error as warning

* these don't need that flag set
2021-03-14 09:31:11 -04:00
Matthew Kennedy 990c3649ae
logging cleanup before refactor (#2438)
* minor cleanup

* more cleaning

* signature

* spelling

* doy
2021-03-09 08:43:29 -05:00
Matthew Kennedy b1873b3d8b
set all thread priorities in the same place (#2412)
* unify thread priority

* header

* mmc
2021-02-28 07:30:45 -05:00
Matthew Kennedy 9226f483a8
yet more TS sanity (#2382)
* ts cleanup part 1

* move more stuff in to the class

* extract base class

* switch to TsChannelBase where we can

* dfu

* more to TsChannelBase

* bad merge

* another bad merge

* bootloader

* bluetooth

* format

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-20 02:11:39 -05:00
Matthew Kennedy a50d1d5ee3
start making tunerstudio more sane: part 2 (#2381)
* ts cleanup part 1

* move more stuff in to the class

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-19 20:48:21 -05:00
Matthew Kennedy bc85adc74e
start making tunerstudio more sane: part 1 (#2378)
* ts cleanup part 1

* unused unused

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-19 07:40:59 -05:00
Matthew Kennedy 187c4d00f7
USB mass storage tweaking (#2352)
* disable TS in case of USB MSD

* housekeeping while we're here

* enable on MRE

* changelog
2021-02-14 15:03:07 -05:00
Matthew Kennedy 99b9391ae8
start peeling out ts commands (#2045)
* start peeling out commands

* guard

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-09 02:23:02 -05:00
Matthew Kennedy cc59a42e3f
start making TS protocol testable (#2043)
* start pulling out a class

* pull function out of loop

* there we go

* ok there we go for real

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-08 03:05:43 -05:00
rusefi 2a1b585bfe Revert "Revert "Split ETB in to interface + implementation headers (#2040)""
This reverts commit 4f4bb957
2020-12-07 01:27:27 -05:00
rusefi 4f4bb95770 Revert "Split ETB in to interface + implementation headers (#2040)"
This reverts commit d9a82c09
2020-12-07 01:11:19 -05:00
Matthew Kennedy d9a82c09af
Split ETB in to interface + implementation headers (#2040)
* split etb interface

* mocks

* fix master while we're at it

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-07 00:29:09 -05:00
rusefillc 3917324f21 sporadic crc error #1943
un-removing, one step forward
2020-11-17 15:24:00 -05:00
rusefi 7cba09b3fa occasional tunerstudio CRC errors #1943
second step back
2020-11-15 22:41:04 -05:00
Matthew Kennedy 5b0a178605
Fix crc again, for real this time (#1948)
* re enable

* changelog

* fix

* fix test

* put some tests back
2020-11-15 16:59:02 -05:00
Matthew Kennedy 866d645b11
fix large response packets (#1947)
* fix console text mode

* oops I should actually write the crc
2020-11-15 07:14:50 -05:00
Matthew Kennedy 11e77b7780
fix CRC errors (#1944)
* fix crc mismatch

* cleanup

* use size_t, add null check

* bounds check for good measure

* rename to scratchBuffer

* comment
2020-11-14 19:21:29 -05:00
Matthew Kennedy f9357d209a
fatal error + inhibit read on TS preset (#1922)
* fatal error + inhibit read on preset

* inhibit more stuff when flag is set

* don't need that message

* extract function, improve msg

* changelog entry
2020-11-03 19:03:46 -05:00
rusefi 98fa9dd6de Merge remote-tracking branch 'origin/Hellen_fork_point' into master
# Conflicts:
#	firmware/console/binary/tunerstudio_io.cpp
#	firmware/console/console_io.cpp
2020-09-11 05:54:21 -04:00
rusefi 4463253a6d Hellen says merge #1772 TS 2020-09-11 05:50:48 -04:00