e748e65638
only: cherry picking: it's going to be painful
2023-04-29 15:07:43 -04:00
61e5b4b1ad
change ObdCode to enum class builds firmware
2023-04-29 00:44:00 -04:00
da6d394482
it's going to be painful
2023-04-28 22:48:02 -04:00
c5abc06429
nobody should use NA6 VAF
...
(cherry picked from commit 0072e8f33cd9645ee67ab8fe9a3cc0d35001081a)
2023-04-28 21:52:48 -04:00
2857e9527d
remove specs_s struct, flatten config
...
(cherry picked from commit f090a97b0b7771dfe02e4b4bb9919d50a6a11ef5)
2023-04-28 20:59:11 -04:00
0098a3d4b9
Clean-up all the 4g drama #5213
2023-04-01 15:40:24 -04:00
6c1a8d501e
4g is symmetrical crank not just four stroke crank #5211
...
only:alphax-4chan
2023-03-30 23:31:47 -04:00
f53937ae87
K
...
only:hellen-honda-k
2023-03-29 22:57:31 -04:00
91e1eb825f
K
...
only:hellen-honda-k
2023-03-28 21:42:20 -04:00
c9c33e02e9
weird: happy running car shows unrealistic vvtSyncGapRatio #5152 ( #5163 )
2023-03-08 16:52:56 -05:00
e08cdf0fb6
trigger refactoring
...
only:mre_f4
2023-03-03 00:21:40 -05:00
e4fa54ac5c
Feb20: 3rd ticket for 4g9x mess #5111
...
adding more lightness
only: alphax-4chan
2023-02-21 16:10:21 -05:00
9c31c1f02a
just more test, does not help :(
2023-02-20 20:37:40 -05:00
5ec7341335
just a rename
2023-02-20 20:37:39 -05:00
57baf7517b
Feb20: 3rd ticket for 4g9x mess #5111
...
adding lightness
2023-02-20 18:22:51 -05:00
325417caa7
fix 4g63 vs 9x naming, add cam-only test ( #5093 )
2023-02-16 23:22:34 -05:00
827dc22757
rewrite neon trigger ( #5003 )
...
* rewrite neon trigger
* we were testing the same thing four times, maybe test it once
2023-01-24 18:33:15 +05:30
9630edfbf8
mitsu 4g63 ( #5001 )
...
* mitsu 4g63
* file header
2023-01-24 06:53:40 +05:30
6588e813ae
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-15 08:26:38 -05:00
9abdab795d
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-14 23:21:23 -05:00
0c1859b77e
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-14 15:33:17 -05:00
d5b00e1187
don't warn if we intentionally skipped this spark ( #4961 )
...
* don't warn if we intentionally skipped this spark
* header
* real nb2
2023-01-10 19:07:44 -05:00
eb56c2897a
detect and ignore doubled trigger edges ( #4656 )
...
* isToothExpectedNow
* s
* s
* kick ci
* only warn at high enough RPM to detect non-smooth trigger
* 4b11 test
2023-01-10 16:07:17 -05:00
289171a85a
symmetrical shapes are not rendered right #4956
2023-01-08 22:37:35 -05:00
2e882986f4
refactoring
2023-01-08 22:30:57 -05:00
68dcbd214e
sweet 4g93 data
2023-01-07 17:31:13 -05:00
0f1d46238f
Mitsubishi 4G93 Trigger issues #4918
2023-01-07 16:28:57 -05:00
e5d199272d
improve iat ignition table ( #4948 )
...
* iat ignition table
* changelog
2023-01-06 21:59:34 -05:00
987e59f7cc
Mitsubishi 4G93 Trigger issues #4918
...
a good case for NAN?
2023-01-03 21:17:32 -05:00
def809aa39
Mitsubishi 4G93 Trigger issues #4918
...
adding more info on the trigger images
2023-01-03 15:44:13 -05:00
c9d88d2605
a bit of dead code
2023-01-03 13:59:25 -05:00
d0f6fa8ea3
let's try again
2023-01-03 08:38:42 -05:00
603f188b55
a bit of dead code
2023-01-03 07:49:17 -05:00
5250b177c2
Allow scheduling_s to come from a pool ( #4841 )
...
* injection events use scheduling pool
* knock and prime
* bench test
* dropped this: *
* extract action before execute
* comment
* init allocated timers
* metrics
* dropped this: ,
* guard
* injection events use scheduling pool
* knock and prime
* bench test
* dropped this: *
* extract action before execute
* comment
* init allocated timers
* metrics
* dropped this: ,
* guard
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-12-10 17:55:51 -05:00
994ee2f22f
Combine angle based event ( #4884 )
...
* Remove AngleBasedEventOld/New, only AngleBasedEvent now
* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
151416b005
default fuel cleanup and injection phase change ( #4836 )
...
* default fuel cleanup and injection phase change
* happy tests
* changelog
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-29 23:41:49 -05:00
5c50ad2db4
infer useOnlyRisingEdge by trigger type ( #4621 )
...
* most of the plumbing
* easy tests
* trigger types that are rise only
* configs
* change mode of various triggers
* vvt
* 898 test is now impossible 🥳
* s
* instant rpm test
* actually remove useOnlyRisingEdgeForTrigger
* remove vvtCamSensorUseRise
* s
* print
* one happy test
* another test
* happy testSomethingWeird
* happy testCamInput
* maybe fix it a different way
* better
* quad cam
* nb2 happy
* bad merge
* vvt test
* trigger.test1995FordInline6TriggerDecoder
* hellen gm e67
* changelog
2022-11-08 21:48:39 -05:00
7bd9dbf89e
fix vvt logging logic ( #4747 )
...
* fix vvt logging logic
* put that back
* flip condition to avoid branch on uninitialized value
2022-11-07 10:52:17 -05:00
1f3ab0cf24
reducing ugly
2022-11-06 21:28:38 -05:00
a5136a0eae
trigger refactoring: instance RPM #4740
2022-11-06 11:05:57 -05:00
36d5b1fbb6
minor trigger refactoring
2022-11-06 00:59:29 -04:00
ccca90cb55
Nissan defaults
2022-11-02 12:05:51 -04:00
f760ae11c1
simplify initializeSkippedToothTrigger ( #4674 )
2022-10-17 16:05:27 -04:00
d13a851c97
triggerImage: todo: support symmetrical crank
2022-10-16 10:33:38 -04:00
5fb9f7c2df
triggerImage: todo: support symmetrical crank
2022-10-16 02:59:57 -04:00
d91211106c
triggerImage: todo: support symmetrical crank
2022-10-16 02:44:57 -04:00
aa881efe89
fix 36-2-1 trigger ( #4645 )
...
* fix
* test files
* test real 4b11
* test.mk
* better angle error math
* test GM too
* changelog
2022-10-09 21:22:05 -04:00
d6647025cc
2jz test ( #4638 )
2022-10-05 20:48:28 -04:00
940e0dc369
require ignition on for firing ( #4628 )
...
* require ignition on for firing
* too much havoc for a unit test
* patch up references
* last one
* fix changelog mangling
* fix the changelog template too
* bad merge
* fix the template again
* s
* fake battery voltage on hw ci
* ugh merge
* ugh merge
2022-10-04 20:36:03 -04:00
ec5d48fb5b
remove 898 ( #4634 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-10-04 20:12:57 -04:00
cb86c014cf
fix instant rpm clearing bug ( #4629 )
...
* improve instant rpm
* changelog
2022-09-29 07:15:59 -04:00
ca623eb6ee
plumbing parts of 4621 ( #4622 )
...
* plumbing parts of 4621
* show error list
* exit on error too!
* this test has some unhealthy undefined behavior
* no uninitialized values
* no that doesn't work
* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
b089825a4a
schedule ignition charge by angle instead of tooth ( #4513 )
...
* schedule ignition charge by angle
* same mistake as #4536
* s
* wrap sparkAngle too
* AngleBasedEventNew
* function moved
* implement scheduleOrQueue
* prints
2022-09-25 11:00:55 -04:00
ae6c44634b
better k gaps ( #4623 )
2022-09-25 09:14:29 -04:00
b45f84fe20
#4619 ( #4620 )
2022-09-25 07:40:28 -04:00
612d52645a
Honda K cam wheels #3405
2022-09-25 00:26:42 -04:00
9d27780974
Honda K cam wheels #3405
2022-09-24 23:49:41 -04:00
111220d38c
more inclusive configuration name
2022-09-24 23:49:41 -04:00
cff779dd78
K progress
2022-09-24 23:18:57 -04:00
a38d87b0e0
fancy default and reusing constant
2022-09-24 23:01:42 -04:00
93e64a61a6
fancy
2022-09-24 22:54:58 -04:00
33be12541b
K
2022-09-24 15:37:51 -04:00
0eef498b3e
refactoring: extract constant
2022-09-24 15:33:01 -04:00
c4699efe91
honda K enum rename
2022-09-23 20:13:14 -04:00
2f18168d47
K20
2022-09-23 20:13:14 -04:00
ed72758a5d
K20
2022-09-23 18:25:24 -04:00
6cdb0dc0af
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
82cda62bac
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
6b0941b8ed
inline method to reduce confusion
2022-09-14 01:24:19 -04:00
2a05a31550
refactoring: type safety
2022-09-11 03:46:50 -04:00
851e8e48d3
refactoring: type safety
2022-09-11 02:57:35 -04:00
72299bd1ba
only report vvt position if we have full sync ( #4547 )
...
* only report vvt position if we have full sync
* comments
* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
8e49542600
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 22:24:28 -04:00
4934d76d88
tear down Engine god object #4511
...
just trying different things
2022-09-05 04:24:17 -04:00
268a5c7964
tear down Engine god object #4511
...
just trying different things
2022-09-05 02:44:06 -04:00
c1b218b772
refactoring: let's use different names for different things
2022-09-05 01:16:24 -04:00
feb386a54b
refactoring: moving field
2022-09-05 01:15:45 -04:00
9407150544
more granular trigger error messages ( #4526 )
...
* granular trigger error messages
* adjust test expectations
* explicitly test behavior
2022-09-04 09:15:24 -04:00
7e340cceb3
refactoring: reducing outputChannels copy
2022-09-01 10:58:16 -04:00
da66fa055c
refactoring: enum name clean-up
2022-09-01 00:23:33 -04:00
fef406a5a6
english do you speak it
2022-08-31 22:56:38 -04:00
5007084981
VQ trigger gaps improvement fix #4469
...
nice, unit test is happier!
2022-08-23 23:32:14 -04:00
25778f0890
trigger gap logging: it's a mess :(
2022-08-21 12:38:29 -04:00
0f320448ff
refactoring: default argument value
2022-08-21 12:17:50 -04:00
eebc810295
enable alwaysInstantRpm in some tests ( #4461 )
...
* test some with alwaysInstantRpm set
* more
2022-08-19 15:03:20 -04:00
423f69a842
allow logging multiple warnings at once ( #4414 )
...
* allow logging multiple warnings at once
* comment
* .Code
* Revert ".Code"
This reverts commit 2b986bd50035aeec051d11aafd83fdbc1694351c.
* add a better comparison operator instead of conversion
* dot code
* Revert "dot code"
This reverts commit 35f6ae1007c41e3b30ea129a324f33ab4205036d.
* force gcc-10 maybe?
* Revert "force gcc-10 maybe?"
This reverts commit 4ddf8bcefddd354ccdc1da682c5fff1e68d44273.
* vq
* dot code
* dead
* dot code
* return may be null
* static_vector; maybe cyclic_buffer is broken or wrong tool for the job?
* move static vector
* put cyclic buffer back how it was since we don't use it now
2022-08-17 01:12:25 -04:00
76f5832db9
resolve VVT phase using every tooth, not just sync point ( #4434 )
...
* resolve VVT phase using every tooth, not just sync point
* fix tests
* comment
* changelog
2022-08-12 08:08:23 -04:00
b5c2b70e23
refactoring: better field name
2022-08-09 20:32:39 -04:00
7887b9d1e1
Extra gap ratios for custom trigger wheels fix #4375
2022-07-23 03:39:19 -04:00
b628c81d26
Make hard-coded gap ratios visible on trigger documentation images #4172
2022-07-12 00:11:25 -04:00
1b28e292e2
logging of live data structs was: data points #3614
...
huh?
2022-06-29 02:42:03 -04:00
c0f290b922
Injector scheduled by angle, not tooth index ( #4208 )
...
* trigger decoder returns a result
* TriggerFormDetails
* s
* don't reach out and touch the engine
* injection doesn't care about teeth
* fix up existing tests
* oh look, we can actually test this logic now without trying to depend on trigger shape!!!
* fix a real bug
* simplify
2022-06-24 17:43:23 -04:00
fcd3d991ee
trigger tweaks cleanup ( #4278 )
...
* simplify some math
* we say yes to the todo
* and put back that test
* test
2022-06-23 23:11:29 -04:00
932f5e1f30
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit 32d46d1f09d5e131b1d0
2022-06-09 17:21:22 -04:00
4ada633206
Remove third trigger channel ( #4226 )
...
* remove third trigger
* clean up the honda mess
* there was nothing novel about this engine config
* include
* missed a few
* s
* x
* changelog
* don't set the third trigger input
* don't redefine the same thing 3 times
* only two inputs!
* test
2022-06-01 21:24:20 -04:00
c0d8cbfef4
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00
b7743f101f
helping build
2022-05-31 10:45:32 -04:00
22d9bf056a
heling build
2022-05-31 08:48:24 -04:00
70c2689f1e
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
f945e6efc9
trigger configuration refactoring for clarity ( #4212 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
2022-05-30 19:36:47 -04:00
Andrey
Matthew Kennedy
Andreika
rusefillc