Commit Graph

632 Commits

Author SHA1 Message Date
rusefillc c091270d19
T2 5 (#5650)
* fix

* add cam/vvt support to trigger_emulator

---------

Co-authored-by: andreika-git <andrei.home@gmail.com>
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2023-10-26 16:06:50 -04:00
rusefillc 2507d4e467
tiny refactoring (#5646)
Co-authored-by: andreika-git <andrei.home@gmail.com>
2023-10-26 13:04:30 -04:00
Andrey 3b1fe9da7f only: VVT refactoring reducing magic index math 2023-10-07 12:34:32 -04:00
rusefillc 0921a303d0 cam input into logs
only:proteus_f4
2023-10-07 11:03:53 -04:00
Andrey be3a7a4ef6 per-tooth cam position accounting for offset 2023-10-06 14:38:27 -04:00
rusefi 7624c91bec we already have vvtCamCounter doing same exact thing 2023-09-27 23:22:18 -04:00
Matthew Kennedy bc637c4e6b rename 2jz -> toyota 3 tooth 2023-09-14 17:42:27 -04:00
rusefillc 1c154f6ee7 2JZ cam trigger configuration is much easier to adjust #5557
only:proteus_f4
2023-09-10 10:34:06 -04:00
rusefi 1d4f82deab 2JZ cam trigger is unfinished #5557 2023-09-10 00:22:38 -04:00
Andrey 8391bc4dee only: 2JZ cam trigger is unfinished #5557 2023-09-09 21:10:37 -04:00
Andrey b5fd6ea044 spelling is important 2023-09-09 19:53:18 -04:00
Andrey ba66fdcf82 reducing code duplication around assert 2023-09-05 21:28:39 -04:00
Andrey 4fbccca850 4G69 Cam pattern #5541 2023-08-25 01:10:08 -04:00
Andrey 49a270e3a3 4G69 Cam pattern #5541 2023-08-24 22:50:16 -04:00
rusefi e8c45a2e7d refactoring: reducing code duplication. Also, do we even care for critical error codes?! 2023-08-20 22:23:44 -04:00
rusefillc 17026dbb3d MAP Sync not working #5503
additional data points
2023-08-09 05:49:06 -04:00
Andrey f3a5586e36 Custom Trigger Tooth with 1+0 causes endless loop fix #5471 2023-08-05 12:59:11 -04:00
Andrey 0787b4f4a0 Custom Trigger Tooth with 1+0 causes endless loop #5471
only:test
2023-08-05 12:44:16 -04:00
rusefillc 77ef4db8ab
Simplified VVT single tooth cam modes. (#5483)
* Simplified VVT single tooth cam modes.

* Simplified VVT single tooth cam modes.

* Simplified VVT single tooth cam modes.

* Simplified VVT single tooth cam modes.

* Simplified VVT single tooth cam modes.

---------

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2023-08-03 20:24:22 -04:00
Matthew Kennedy 7f67ecd02d simplify adjustCrankPhase
(cherry picked from commit 7ae11160d9bfb31a664130e66586e849b8201c8a)
2023-06-28 21:49:51 -04:00
rusefillc bc2a2b9ab9 only:better method name 2023-06-25 02:08:53 -04:00
rusefi f77f356e6d reducing code duplication 2023-06-11 23:17:13 -04:00
Matthew Kennedy 81682d1a55 oop 2023-06-05 14:15:21 -04:00
rusefi 1908896598 Technical debt: ENUM_32_BITS #3874
poking the bear
2023-06-01 10:29:05 -04:00
Matthew Kennedy 12a29232cc tooth_logger.h -> pch
(cherry picked from commit ad3ea57276361b6da69eb920dd056a662f6f5c70)
2023-05-31 15:59:02 -04:00
rusefillc 80d88604ff fix https://github.com/rusefi/alphax-4chan/issues/135 2023-05-16 23:07:34 -04:00
rusefillc 86c1a9f8e0 fix https://github.com/rusefi/alphax-4chan/issues/135 2023-05-16 23:00:18 -04:00
rusefi 409bf4b2ce Ford Coyote VVT Decoder #5275
helping build?
2023-05-13 13:27:37 -04:00
Matthew Kennedy 71a032a61b rename triggerSimulatorFrequency -> triggerSimulatorRpm
(cherry picked from commit d1246174d283ae775444a0e183be9cace88219a9)
2023-04-30 00:44:53 -04:00
Matthew Kennedy 9ae8e18757 only: cherry picking: it's going to be painful 2023-04-29 15:14:58 -04:00
Andrey 51d0f6e347 it's going to be painful 2023-04-29 00:44:00 -04:00
Matthew Kennedy 61e5b4b1ad change ObdCode to enum class builds firmware 2023-04-29 00:44:00 -04:00
rusefillc fee6bd2ded vvtChannel2 #5207
only:proteus_f7
2023-04-22 08:32:30 -04:00
Andrey f53937ae87 K
only:hellen-honda-k
2023-03-29 22:57:31 -04:00
Andreika 134d34385e
vvttoothDurations0 NT2US #5193 (#5194)
* vvttoothDurations0 NT2US #5193

* vvttoothDurations0 NT2US #5193
2023-03-21 09:45:08 -04:00
rusefillc 32e8de134f weird: happy running car shows unrealistic vvtSyncGapRatio #5152 2023-03-04 14:58:31 -05:00
Andrey e08cdf0fb6 trigger refactoring
only:mre_f4
2023-03-03 00:21:40 -05:00
Andrey 30a96f0b03 refactoring: better variable name
only:mre_f4
2023-03-02 23:24:59 -05:00
Andrey be69eecf8e yes, this thing works nicely 2023-02-21 00:08:22 -05:00
Andrey 9d41bc7d56 typo 2023-02-20 23:40:31 -05:00
Matthew Kennedy 325417caa7
fix 4g63 vs 9x naming, add cam-only test (#5093) 2023-02-16 23:22:34 -05:00
Matthew Kennedy 9630edfbf8
mitsu 4g63 (#5001)
* mitsu 4g63

* file header
2023-01-24 06:53:40 +05:30
Matthew Kennedy eb56c2897a
detect and ignore doubled trigger edges (#4656)
* isToothExpectedNow

* s

* s

* kick ci

* only warn at high enough RPM to detect non-smooth trigger

* 4b11 test
2023-01-10 16:07:17 -05:00
Andrey d0f6fa8ea3 let's try again 2023-01-03 08:38:42 -05:00
Matthew Kennedy 5c50ad2db4
infer useOnlyRisingEdge by trigger type (#4621)
* most of the plumbing

* easy tests

* trigger types that are rise only

* configs

* change mode of various triggers

* vvt

* 898 test is now impossible 🥳

* s

* instant rpm test

* actually remove useOnlyRisingEdgeForTrigger

* remove vvtCamSensorUseRise

* s

* print

* one happy test

* another test

* happy testSomethingWeird

* happy testCamInput

* maybe fix it a different way

* better

* quad cam

* nb2 happy

* bad merge

* vvt test

* trigger.test1995FordInline6TriggerDecoder

* hellen gm e67

* changelog
2022-11-08 21:48:39 -05:00
Matthew Kennedy 7bd9dbf89e
fix vvt logging logic (#4747)
* fix vvt logging logic

* put that back

* flip condition to avoid branch on uninitialized value
2022-11-07 10:52:17 -05:00
rusefi ec77afeaa0 reducing ugly 2022-11-06 20:47:57 -05:00
Andrey 77a3f5d795 trigger refactoring: instance RPM #4740 2022-11-06 11:56:18 -05:00
Andrey 79afd2b6fa trigger refactoring: instance RPM #4740 2022-11-06 11:41:27 -05:00
Andrey a5136a0eae trigger refactoring: instance RPM #4740 2022-11-06 11:05:57 -05:00
rusefillc 53d3c4a529 minor trigger refactoring 2022-11-06 01:32:59 -04:00
rusefillc e3fd84ed08 minor trigger refactoring 2022-11-06 00:32:38 -04:00
rusefillc cd77afe464 minor fix: will be invoked downstream 2022-11-05 23:58:05 -04:00
rusefillc 2866ba54b8 minor fix: no need to assign same value twice 2022-11-05 23:50:03 -04:00
Andrey b57bf2903a minor trigger refactoring 2022-11-05 21:43:12 -04:00
Andrey G e7b06cbfca
compile warnings: signed vs unsigned and unused (#4713) 2022-10-30 09:47:53 -04:00
rusefillc 983f88709a progress: allow only exhaust cam input now that we have index parameter 2022-10-22 08:40:36 -04:00
rusefillc da0fa03f0a refactoring: wider usage of helper method 2022-10-22 08:39:55 -04:00
Matthew Kennedy aa881efe89
fix 36-2-1 trigger (#4645)
* fix

* test files

* test real 4b11

* test.mk

* better angle error math

* test GM too

* changelog
2022-10-09 21:22:05 -04:00
rusefillc 6a99469c8a
// todo: what is broken _exactly_? (#4531)
* // todo: what is broken _exactly_?

* hold on, why "float autoscale" at all here?

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-08 23:13:14 -04:00
Matthew Kennedy 940e0dc369
require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
rusefillc 57c804c6f5 there is no third trigger simulator channel right? 2022-10-03 00:18:11 -04:00
Matthew Kennedy ca623eb6ee
plumbing parts of 4621 (#4622)
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Andrey 9d27780974 Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Andrey 61cfff1e9e K progress - just a rename 2022-09-24 23:25:36 -04:00
Andrey cff779dd78 K progress 2022-09-24 23:18:57 -04:00
Matthew Kennedy dd41cf0a05
log tooth angle difference (#4613) 2022-09-23 23:49:28 -04:00
Matthew Kennedy 7139ddcda2
explicitly pass which edges we sync trigger on (#4607)
* require sync edge type

* s

* fix neon

* info printing

* put enums back

* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc efb232223f moving acceleration around 2022-09-16 00:06:57 -04:00
rusefillc 3104538022 just a rename & hiding unit test method 2022-09-15 23:07:08 -04:00
rusefillc 50cef9a201 tear down Engine god object #4511 2022-09-15 22:12:49 -04:00
rusefillc 85b170f84e dead idea 2022-09-15 14:55:32 -04:00
Andrey 0c87bb7260 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:45:31 -04:00
Andrey 0e91914266 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey 663c39afdc deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:24:41 -04:00
Andrey 2c0ce0ec7d deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey 12d857b99c deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:06:52 -04:00
Andrey 6cdb0dc0af deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey 82cda62bac inline method to reduce confusion 2022-09-14 01:34:52 -04:00
rusefillc 2a05a31550 refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc 851e8e48d3 refactoring: type safety 2022-09-11 02:57:35 -04:00
rusefillc cfb843b315 send more of Engine Sniffer data #4560
hello Kinetis it has been a while!
2022-09-11 00:18:08 -04:00
rusefillc 7b4a5c9be6 vvtBooleanForVerySpecialCases, tempBooleanForVerySpecialLogic 2022-09-09 17:52:54 -04:00
Matthew Kennedy 72299bd1ba
only report vvt position if we have full sync (#4547)
* only report vvt position if we have full sync

* comments

* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
Andrey 8e49542600 trigger: in corner cases like NB2 and VQ35 those are not revolutions 2022-09-07 22:24:28 -04:00
Andrey ab4b451195 os_access.h dead? 2022-09-07 15:56:45 -04:00
Andrey c1b218b772 refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
Andrey c28c876357 todo: what is broken _exactly_? 2022-09-03 06:55:47 -04:00
Andrey 5941ad8fb7 smaller step forward 2022-09-01 10:06:00 -04:00
Andrey 1d1fd2da43 Revert "smaller step forward"
This reverts commit f0e6bcc279.
2022-09-01 09:10:11 -04:00
Andrey e1b3c3380f Revert "smaller step forward"
This reverts commit f388163d2a.
2022-09-01 09:10:07 -04:00
Andrey f388163d2a smaller step forward 2022-09-01 08:51:13 -04:00
Andrey f0e6bcc279 smaller step forward 2022-09-01 08:44:46 -04:00
Andrey ce5e618e3f smaller step forward 2022-09-01 01:08:51 -04:00
Andrey 9e14073feb c63fb29aaf partial rollback 2022-09-01 00:46:54 -04:00
Andrey da66fa055c refactoring: enum name clean-up 2022-09-01 00:23:33 -04:00
Andrey c63fb29aaf refactoring: reducing outputChannels copy 2022-09-01 00:13:55 -04:00
Andrey 28d797d5c2 moving confusion further away from fuel control 2022-08-31 23:59:40 -04:00
Andrey 6d3a6dc2f8 readability 2022-08-31 23:29:47 -04:00
Matthew Kennedy ca4936d3fe
rename and fix skyactiv cam mode (#4505) 2022-08-31 22:12:45 -04:00