Commit Graph

1856 Commits

Author SHA1 Message Date
Matthew Kennedy 5c50ad2db4
infer useOnlyRisingEdge by trigger type (#4621)
* most of the plumbing

* easy tests

* trigger types that are rise only

* configs

* change mode of various triggers

* vvt

* 898 test is now impossible 🥳

* s

* instant rpm test

* actually remove useOnlyRisingEdgeForTrigger

* remove vvtCamSensorUseRise

* s

* print

* one happy test

* another test

* happy testSomethingWeird

* happy testCamInput

* maybe fix it a different way

* better

* quad cam

* nb2 happy

* bad merge

* vvt test

* trigger.test1995FordInline6TriggerDecoder

* hellen gm e67

* changelog
2022-11-08 21:48:39 -05:00
Matthew Kennedy 7bd9dbf89e
fix vvt logging logic (#4747)
* fix vvt logging logic

* put that back

* flip condition to avoid branch on uninitialized value
2022-11-07 10:52:17 -05:00
rusefi ec77afeaa0 reducing ugly 2022-11-06 20:47:57 -05:00
Andrey 1475ecf273 trigger refactoring: instance RPM fix #4740 2022-11-06 12:03:55 -05:00
Andrey 77a3f5d795 trigger refactoring: instance RPM #4740 2022-11-06 11:56:18 -05:00
Andrey 83e736b06a trigger refactoring: instance RPM #4740 2022-11-06 11:47:23 -05:00
Andrey 7b10b32958 trigger refactoring: instance RPM #4740 2022-11-06 11:45:51 -05:00
Andrey 79afd2b6fa trigger refactoring: instance RPM #4740 2022-11-06 11:41:27 -05:00
Andrey d75bf59cdc trigger refactoring: instance RPM #4740 2022-11-06 11:12:20 -05:00
Andrey a5136a0eae trigger refactoring: instance RPM #4740 2022-11-06 11:05:57 -05:00
Andrey b5796c121d trigger refactoring: instance RPM #4740 2022-11-06 10:58:04 -05:00
rusefillc 53d3c4a529 minor trigger refactoring 2022-11-06 01:32:59 -04:00
rusefillc 87d6aa2ed9 minor trigger refactoring 2022-11-06 01:11:33 -04:00
rusefillc e3fd84ed08 minor trigger refactoring 2022-11-06 00:32:38 -04:00
rusefillc a0c234c76d learning C++ 2022-11-06 00:17:24 -04:00
rusefillc d4bb6a3a5e more fancy 2022-11-06 00:10:50 -04:00
rusefillc cd77afe464 minor fix: will be invoked downstream 2022-11-05 23:58:05 -04:00
rusefillc 2866ba54b8 minor fix: no need to assign same value twice 2022-11-05 23:50:03 -04:00
rusefillc 43e3fce9b1 minor trigger refactoring 2022-11-05 22:42:33 -04:00
rusefillc fd86dc2b0f minor trigger refactoring 2022-11-05 22:30:08 -04:00
Andrey c6e34be447 A gem of dead code 2022-11-05 21:53:38 -04:00
Andrey b57bf2903a minor trigger refactoring 2022-11-05 21:43:12 -04:00
rusefillc 6c3899f401 dead lines 2022-11-05 17:21:30 -04:00
rusefillc 500b3e8678 dead lines 2022-11-05 15:20:02 -04:00
Andrey G e7b06cbfca
compile warnings: signed vs unsigned and unused (#4713) 2022-10-30 09:47:53 -04:00
rusefillc 0283351d6c send more of Engine Sniffer data #4560 2022-10-29 21:55:35 -04:00
GitHub gen-configs Action cb77801ed3 Auto-generated configs and docs 2022-10-28 14:09:22 +00:00
rusefillc a4aa280e90 SD card log fields list should be auto-generated #3985 2022-10-28 10:04:33 -04:00
GitHub gen-configs Action 6b28fee5ce Auto-generated configs and docs 2022-10-28 13:11:34 +00:00
rusefillc 5df60fd084 SD card log fields list should be auto-generated #3985 2022-10-28 09:06:15 -04:00
rusefillc cf75202ab6 Automation coverage for RPM not reading #4709 2022-10-28 02:44:38 -04:00
rusefillc 2677da2105 refactoring 2022-10-28 02:41:20 -04:00
rusefillc 983f88709a progress: allow only exhaust cam input now that we have index parameter 2022-10-22 08:40:36 -04:00
rusefillc da0fa03f0a refactoring: wider usage of helper method 2022-10-22 08:39:55 -04:00
rusefillc 905f59d561 progress: rpm register based on trigger input being none or not 2022-10-21 23:29:39 -04:00
Matthew Kennedy f760ae11c1
simplify initializeSkippedToothTrigger (#4674) 2022-10-17 16:05:27 -04:00
rusefillc 19b0f7e66e triggerImage: todo: support symmetrical crank 2022-10-16 12:10:58 -04:00
Matthew Kennedy aa881efe89
fix 36-2-1 trigger (#4645)
* fix

* test files

* test real 4b11

* test.mk

* better angle error math

* test GM too

* changelog
2022-10-09 21:22:05 -04:00
rusefillc 6a99469c8a
// todo: what is broken _exactly_? (#4531)
* // todo: what is broken _exactly_?

* hold on, why "float autoscale" at all here?

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-08 23:13:14 -04:00
GitHub gen-configs Action bd4ca6a805 Auto-generated configs and docs 2022-10-09 02:22:51 +00:00
rusefillc 86d3b16939
hold on, why "float autoscale" at all here? (#4647)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-08 22:11:34 -04:00
Matthew Kennedy a773b3249a
remove 2jz trigger that's really 12 tooth crank (#4637)
* remove 2jz trigger that's really 12 tooth crank

* triggerimage hardcoded name
2022-10-05 21:59:17 -04:00
Matthew Kennedy 6e021fb880
change triggers that need RiseOnly (#4636)
* triggers that need RiseOnly

* skipped tooth

* s
2022-10-05 20:10:27 -04:00
Matthew Kennedy 940e0dc369
require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
rusefillc 57c804c6f5 there is no third trigger simulator channel right? 2022-10-03 00:18:11 -04:00
Matthew Kennedy cb86c014cf
fix instant rpm clearing bug (#4629)
* improve instant rpm

* changelog
2022-09-29 07:15:59 -04:00
Andrey 36113d6f66 nicer fatal message if that ever happens 2022-09-28 19:47:14 -04:00
GitHub gen-configs Action 1b56415c56 Auto-generated configs and docs 2022-09-25 22:54:41 +00:00
Matthew Kennedy ca623eb6ee
plumbing parts of 4621 (#4622)
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy 26356adf92
also invert trigger stim if you have trigger input inverted (#4612) 2022-09-25 10:10:31 -04:00