rusefillc
30c48389c7
sporadic HighRevTest testV12 #3806
...
let's attempt to guess his intentions
2022-01-25 17:24:38 -05:00
rusefillc
aef0995871
sporadic HighRevTest testV12 #3806
...
is this bug here?
2022-01-25 10:28:35 -05:00
Matthew Kennedy
4e639480ff
fix ( #3833 )
2022-01-24 18:15:18 -05:00
Andrey
9f5188bf30
Better handling of RPM during stop of cranking #3803
2022-01-17 21:27:10 -05:00
Andrey
a1374062f0
Better handling of RPM during stop of cranking #3803
...
reuse existing magic constant
2022-01-17 21:18:43 -05:00
rusefillc
bc66096574
Better handling of RPM during stop of cranking #3803
...
refactoring: reusing existing method
2022-01-17 21:00:49 -05:00
Matthew Kennedy
d5c4b79b1a
Nb2 crank sync special case ( #3727 )
...
* extract isSyncPoint
* test because why not
* check vvt resync nb2
* custom nb decoder
* test only resyncs once!
* good job valgrind, you found a bug!
2021-12-31 15:47:25 -05:00
Matthew Kennedy
c3b712aa3b
remove vvtSyncTimeNt ( #3722 )
...
* s
* poke
* poke again for science
* kick for science
* kick
* kick
* comment kick
* s
* don't try to compare the array decay pointer to 0 (!)
* collateral damage
* adjust miata sync
* reset trigger states correctly on engine stop
* s
* check synchronized bit
* now we don't need it at all?!
* and *NOT* synced
* start VVT sync earlier
2021-12-28 00:00:26 -05:00
rusefillc
4292c2fb1d
MAP phase sensing fix #3544
...
removing dead implementation
2021-12-16 21:28:27 -05:00
rusefillc
06ccf524dd
MAP phase sensing #3544
...
removing dead implementation
2021-12-16 21:13:55 -05:00
rusefillc
17879ef7de
MAP phase sensing #3544
2021-12-09 22:16:42 -05:00
Andrey
50038167d8
MAP phase sensing #3544
...
new implementation seems complete?
2021-12-07 21:08:25 -05:00
Andrey
e72d57438a
MAP phase sensing #3544
...
new implementation
2021-12-07 20:00:04 -05:00
Andrey
6e49d66385
MAP phase sensing #3544
...
look new unit test!
2021-12-07 16:58:10 -05:00
rusefillc
2f45ed205c
MAP phase sensing #3544
...
option to look for high and low peaks
2021-12-05 14:25:26 -05:00
rusefillc
85da6d6ad1
MAP phase sensing #3544
2021-12-04 18:47:14 -05:00
rusefillc
0c91e77749
MAP phase sensing #3544
...
taking a step back to happy place
2021-12-04 18:21:10 -05:00
rusefillc
45a95db67f
MAP phase sensing #3544
...
trying longer average
2021-12-04 17:06:59 -05:00
rusefillc
e896afe2f6
Engine phase wrap around in log #3645
...
refactoring & docs
2021-12-02 17:06:20 -05:00
Andrey
48ed80ffb9
MAP phase sensing #3544
2021-11-24 23:06:52 -05:00
Andrey
e2fa1af527
MAP phase sensing #3544
2021-11-24 22:36:36 -05:00
Scott Smith
cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* ( #3560 )
...
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*
for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
git grep -l "$i" | xargs sed -i "s/$i//g"
done
git grep -l "inject" | xargs sed -i "/inject[(][)]/d"
for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done
git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h
* Review fixups.
2021-11-16 16:52:11 -05:00
Matthew Kennedy
8cdac4cac0
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
Andrey
655b77dc3f
random refactoring: trigger central encapsulation
2021-11-15 20:22:05 -05:00
Matthew Kennedy
145316c497
less macro, more c++ ( #3549 )
...
* less macro
* s
2021-11-15 12:44:40 +01:00
rusefi
e8aebc313a
Something something Automatic Compression Release #3442
2021-11-14 15:04:10 -05:00
Matthew Kennedy
59e9d05fc7
extract engine phase function ( #3456 )
...
* extract getCurrentEnginePhase
* inject engine ref
* never invalid RPM, use 0 instead
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-04 05:46:16 -04:00
rusefi
274a6d8ba6
triggerinfo progress
2021-10-23 19:01:31 -04:00
rusefillc
c1275af29c
reduce chance of invalid CAM setting fix #3105
2021-08-03 22:15:40 -04:00
Andrey
cf2e2a6451
Nissan VVT trigger decoder #2887
...
that looks like one bug
2021-07-05 22:44:20 -04:00
Matthew Kennedy
5c60973dd8
Consolidate hwHandleShaftSignal ( #2875 )
...
* consolidate trigger input
* merge functions
* comment
* dead
* hw vs. not hw
* stray comma
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-28 10:06:22 -04:00
Andrey
21c06e1514
refactoring maybe making code reuse more possible in the future
2021-06-27 13:00:01 -04:00
Andrey
66b091a5a5
Trigger: warning code on normal engine start up #669
...
making more code unit-testable
2021-06-25 11:30:06 -04:00
rusefillc
be931e41d5
docs
2021-05-02 23:46:30 -04:00
rusefi
3c9f7174ba
improving QC process
2021-04-23 00:45:36 -04:00
Matthew Kennedy
c26987b96b
Destroy all shared logger ( #2574 )
...
* most of shared logger
* a few more
* one more
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 14:28:48 -04:00
Matthew Kennedy
1c473934b9
plumbing for multiple vvt ( #2488 )
...
* plumb multiple vvt
* fix test
* s
* fix barra while we're at it
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-25 07:39:23 -04:00
Matthew Kennedy
5a4c24f9a5
virtual zero timer ( #2426 )
...
* virtual zero timer
* it would help to call the correct function
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-07 15:32:41 -05:00
rusefillc
081357ca5e
M62T vanos support #2243
2021-02-08 22:07:14 -05:00
rusefi
0d6dfbb501
M62T vanos support #2243
2021-02-08 21:28:57 -05:00
rusefi
6793b5d8fc
M62T vanos support #2243
2021-02-08 20:38:38 -05:00
Matthew Kennedy
870857df36
add option to disable ETB if engine not spinning ( #2280 )
...
* config/ui
* trigger central mods
* implement
2021-02-05 17:19:57 -06:00
rusefillc
4bb9762e2e
extracting runtime state from trigger central
2021-01-31 22:41:17 -05:00
rusefillc
869e4cfc49
vvt/cam events to pass index
2021-01-31 22:24:45 -05:00
rusefillc
dc80e4e6cb
M62T vanos support #2243
2021-01-26 22:54:25 -05:00
rusefillc
e219638f60
M62T vanos support #2243
2021-01-26 21:43:23 -05:00
rusefillc
b6f5e5f34d
M62T vanos support #2243
2021-01-26 21:16:47 -05:00
Andrey G
2af32084f4
gpio helper ( #2195 )
...
* gpios: isBrainPinValid helper
* LCD HD44780: do not touch pins if DM_NONE or invalid gpio
* Fix isEnabled checks for GPS and Joystick
* LCD HD44780: writePad use this method wider
2021-01-08 20:01:26 -05:00
Matthew Kennedy
f4dcf0f397
generate triggers.txt from parametric test ( #2186 )
...
* add new test
* comment
* remove old
* main cleanup
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-05 17:58:34 -05:00
rusefillc
e6bfd9a2ed
trigger lifecycle
2020-12-09 12:19:25 -05:00